ci: add create-release-pr workflow action #1084

fadi-george · 2025-10-27T18:28:36Z

Description

One Line Summary

adds create release pr workflow

Details

removes release-drafter logic in favor a custom release workflow pr
custom create workflow file has 3 inputs (cordova version, android version (optional), ios version (optional))
- gets merged prs for building out release notes
- creates a release branch
  - if cordova version has alpha or beta in it, the release branch will be something like rel/5.3.0-alpha (no alpha/beta number)
  - otherwise release branch would look like rel/5.2.0
- updates versions (package json, plugin.xml, etc.)
  - if ios version was updated, we update the examples pod lock file
  - runs bunx cap synx in examples folder
- creates a pr to main (if stable) otherwise makes a pr to rel/ branch

Motivation

want to automate release process

Affected code checklist

Checklist

Overview

I have filled out all REQUIRED sections above
PR does one thing
- If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
Any Public API changes are explained in the PR details and conform to existing APIs

Testing

I have included test coverage for these changes, or explained why they are not needed
All automated tests pass, or I explained why that is not possible
I have personally tested this on my device, or explained why that is not possible

Final pass

Code is as readable as possible.
- Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
I have reviewed this PR myself, ensuring it meets each checklist item
- WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is

abdulraqeeb33 · 2025-10-27T18:38:53Z

.github/workflows/ci.yml

    steps:
      - uses: actions/checkout@v5

+      - uses: amannn/action-semantic-pull-request@v6


are we ok to use actions from third party libraries?

does github action have any standard action that we can use instead?

Ive removed it.

abdulraqeeb33 · 2025-10-27T18:40:06Z

.github/workflows/create-release-pr.yml

+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              state: 'closed',
+              base: 'main',


what is if its a non release branch?

Ive updated to check if cordova version is prerelease and use rel/ e.g. rel/5.3.0-beta (minus the beta number)

abdulraqeeb33 · 2025-10-28T19:57:32Z

.github/workflows/create-release-pr.yml

+              per_page: 100
+            });
+
+            // Filter and process PRs


i am thinking if we can standardize this across all PRs? that way we haev one way of doing it everywhere.

Ive added a call to get prs merged into rel/

abdulraqeeb33 · 2025-10-28T19:58:48Z

.github/workflows/create-release-pr.yml

+            const hasFeatures = mergedPrs.some(pr => /^feat/i.test(pr.title));
+            core.setOutput('isFeature', hasFeatures);
+
+      - name: Calculate new version


why should we calculate new version? cant we just manually enter the version?
anything that i am missing here?

Agreed, this isn't something we should have to re-invent. There are tools that exist for this purpose, which will cut down on our overhead.

Ive added a cordova-input instead of new version calculation. Though if we expect this to be called from android-sdk (in the future) wed need to programmatically determine the new version.

abdulraqeeb33 · 2025-10-29T18:32:53Z

.github/workflows/create-release-pr.yml

+          RELEASE=$(curl -s -H "Authorization: token ${{ github.token }}" \
+            "https://api.github.com/repos/OneSignal/OneSignal-Android-SDK/releases/tags/v${VERSION}")
+
+          if echo "$RELEASE" | grep -q "\"id\""; then


is this a safe validation? have you tested it?

Will test when its merged

.github/workflows/create-release-pr.yml

fadi-george requested a review from jkasten2 October 27, 2025 18:28

fadi-george assigned nan-li Oct 27, 2025

fadi-george requested review from abdulraqeeb33 and sherwinski October 27, 2025 18:29

fadi-george force-pushed the fg/release branch from 39b418e to 27ab3b9 Compare October 27, 2025 18:34

fadi-george requested a review from nan-li October 27, 2025 20:45

fadi-george force-pushed the fg/release branch 3 times, most recently from dc11e39 to 33b22c2 Compare October 27, 2025 22:59

fadi-george force-pushed the fg/more-tests branch 4 times, most recently from 9d144c1 to 2bf66ce Compare October 28, 2025 19:05

Base automatically changed from fg/more-tests to main October 28, 2025 19:33

abdulraqeeb33 reviewed Oct 28, 2025

View reviewed changes

fadi-george force-pushed the fg/release branch 5 times, most recently from 43a536f to 73ea2b0 Compare October 29, 2025 17:59

abdulraqeeb33 approved these changes Oct 29, 2025

View reviewed changes

fadi-george added 5 commits October 29, 2025 11:48

add concurrency

fbe4d4d

remove release drafters and add semantic pr title check

b1a61e7

create release workflow

75b3e8e

use semver and get rid of alpha

b8f0374

allow passing custom cordova version

aeaf864

fadi-george force-pushed the fg/release branch from 73ea2b0 to 658a6eb Compare October 29, 2025 18:49

fadi-george changed the title ~~ci: add create-release-pr workflow~~ ci: add create-release-pr workflow action Oct 29, 2025

fadi-george changed the title ~~ci: add create-release-pr workflow action~~ ciz: add create-release-pr workflow action Oct 29, 2025

clean up logic

243127a

fadi-george force-pushed the fg/release branch from 658a6eb to 243127a Compare October 29, 2025 18:55

fadi-george changed the title ~~ciz: add create-release-pr workflow action~~ ci add create-release-pr workflow action Oct 29, 2025

fadi-george changed the title ~~ci add create-release-pr workflow action~~ ci: add create-release-pr workflow action Oct 29, 2025

fadi-george merged commit 35e921c into main Oct 29, 2025
4 of 5 checks passed

fadi-george deleted the fg/release branch October 29, 2025 19:01

fadi-george added a commit that referenced this pull request Oct 29, 2025

ci: add create-release-pr workflow action (#1084)

ed1daa5

fadi-george added a commit that referenced this pull request Oct 29, 2025

ci: add create-release-pr workflow action (#1084)

a9e9e17

fadi-george added a commit that referenced this pull request Oct 29, 2025

ci: add create-release-pr workflow action (#1084)

0f8f981

fadi-george added a commit that referenced this pull request Oct 29, 2025

ci: add create-release-pr workflow action (#1084)

f03cb0a

fadi-george added a commit that referenced this pull request Oct 29, 2025

ci: add create-release-pr workflow action (#1084)

fe32667

fadi-george added a commit that referenced this pull request Oct 29, 2025

ci: add create-release-pr workflow action (#1084)

cbb7271

fadi-george added a commit that referenced this pull request Oct 29, 2025

ci: add create-release-pr workflow action (#1084)

879304a

fadi-george added a commit that referenced this pull request Oct 29, 2025

ci: add create-release-pr workflow action (#1084)

8261eda

ci: add create-release-pr workflow action #1084

ci: add create-release-pr workflow action #1084

Uh oh!

Conversation

fadi-george commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

One Line Summary

Details

Motivation

Affected code checklist

Checklist

Overview

Testing

Final pass

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fadi-george commented Oct 27, 2025 •

edited

Loading