Skip to content

Commit 67ef02b

Browse files
authored
Merge pull request #1382 from OneSignal/fix/OneSignalCore_naming
Rename `OneSignalCore` class to prevent conflict with the framework name
2 parents caf6dd9 + 240876e commit 67ef02b

File tree

16 files changed

+32
-32
lines changed

16 files changed

+32
-32
lines changed

iOS_SDK/OneSignalSDK/OneSignalCore/Source/OneSignalCore.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
#import <OneSignalCore/OSLocation.h>
5959

6060
// TODO: Testing: Should this class be defined in this file?
61-
@interface OneSignalCore : NSObject
61+
@interface OneSignalCoreImpl : NSObject
6262

6363
+ (void)setSharedClient:(nonnull id<IOneSignalClient>)client;
6464
+ (nonnull id<IOneSignalClient>)sharedClient;

iOS_SDK/OneSignalSDK/OneSignalCore/Source/OneSignalCore.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
#import <Foundation/Foundation.h>
2929
#import "OneSignalCore.h"
3030

31-
@implementation OneSignalCore
31+
@implementation OneSignalCoreImpl
3232

3333
static id<IOneSignalClient> _sharedClient;
3434
+ (id<IOneSignalClient>)sharedClient {

iOS_SDK/OneSignalSDK/OneSignalExtension/OneSignalReceiveReceiptsController.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ - (void)sendReceiveReceiptWithPlayerId:(nonnull NSString *)playerId
9797
dispatch_time_t dispatchTime = dispatch_time(DISPATCH_TIME_NOW, delay * NSEC_PER_SEC);
9898
dispatch_after(dispatchTime, dispatch_get_main_queue(), ^{
9999
[OneSignalLog onesignalLog:ONE_S_LL_VERBOSE message:[NSString stringWithFormat:@"OneSignal sendReceiveReceiptWithPlayerId now sending confirmed delievery after: %i second delay", delay]];
100-
[OneSignalCore.sharedClient executeRequest:request onSuccess:^(NSDictionary *result) {
100+
[OneSignalCoreImpl.sharedClient executeRequest:request onSuccess:^(NSDictionary *result) {
101101
if (success) {
102102
success(result);
103103
}

iOS_SDK/OneSignalSDK/OneSignalInAppMessages/Controller/OSInAppMessageController.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,13 @@ - (void)loadMessageHTMLContentWithResult:(OSResultSuccessBlock _Nullable)success
4646

4747
let request = [OSRequestLoadInAppMessageContent withAppId:[OneSignalConfigManager getAppId] withMessageId:self.messageId withVariantId:variantId];
4848

49-
[OneSignalCore.sharedClient executeRequest:request onSuccess:successBlock onFailure:failureBlock];
49+
[OneSignalCoreImpl.sharedClient executeRequest:request onSuccess:successBlock onFailure:failureBlock];
5050
}
5151

5252
- (void)loadPreviewMessageHTMLContentWithUUID:(NSString * _Nonnull)previewUUID success:(OSResultSuccessBlock _Nullable)successBlock failure:(OSFailureBlock _Nullable)failureBlock {
5353
let request = [OSRequestLoadInAppMessagePreviewContent withAppId:[OneSignalConfigManager getAppId] previewUUID:previewUUID];
5454

55-
[OneSignalCore.sharedClient executeRequest:request onSuccess:successBlock onFailure:failureBlock];
55+
[OneSignalCoreImpl.sharedClient executeRequest:request onSuccess:successBlock onFailure:failureBlock];
5656
}
5757

5858
/**

iOS_SDK/OneSignalSDK/OneSignalInAppMessages/Controller/OSMessagingController.m

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ - (void)getInAppMessagesFromServer:(NSString *)subscriptionId {
245245
}
246246

247247
OSRequestGetInAppMessages *request = [OSRequestGetInAppMessages withSubscriptionId:subscriptionId];
248-
[OneSignalCore.sharedClient executeRequest:request onSuccess:^(NSDictionary *result) {
248+
[OneSignalCoreImpl.sharedClient executeRequest:request onSuccess:^(NSDictionary *result) {
249249
dispatch_async(dispatch_get_main_queue(), ^{
250250
[OneSignalLog onesignalLog:ONE_S_LL_VERBOSE message:@"getInAppMessagesFromServer success"];
251251
if (result[@"in_app_messages"]) { // when there are no IAMs, will this still be there?
@@ -510,7 +510,7 @@ - (void)messageViewPageImpressionRequest:(OSInAppMessageInternal *)message withP
510510
withPageId:pageId
511511
forVariantId:message.variantId];
512512

513-
[OneSignalCore.sharedClient executeRequest:metricsRequest
513+
[OneSignalCoreImpl.sharedClient executeRequest:metricsRequest
514514
onSuccess:^(NSDictionary *result) {
515515
NSString *successMessage = [NSString stringWithFormat:@"In App Message with message id: %@ and page id: %@, successful POST page impression update with result: %@", message.messageId, pageId, result];
516516
[OneSignalLog onesignalLog:ONE_S_LL_DEBUG message:successMessage];
@@ -549,7 +549,7 @@ - (void)messageViewImpressionRequest:(OSInAppMessageInternal *)message {
549549
withMessageId:message.messageId
550550
forVariantId:message.variantId];
551551

552-
[OneSignalCore.sharedClient executeRequest:metricsRequest
552+
[OneSignalCoreImpl.sharedClient executeRequest:metricsRequest
553553
onSuccess:^(NSDictionary *result) {
554554
NSString *successMessage = [NSString stringWithFormat:@"In App Message with id: %@, successful POST impression update with result: %@", message.messageId, result];
555555
[OneSignalLog onesignalLog:ONE_S_LL_DEBUG message:successMessage];
@@ -951,7 +951,7 @@ - (void)sendClickRESTCall:(OSInAppMessageInternal *)message withAction:(OSInAppM
951951
forVariantId:message.variantId
952952
withAction:action];
953953

954-
[OneSignalCore.sharedClient executeRequest:metricsRequest
954+
[OneSignalCoreImpl.sharedClient executeRequest:metricsRequest
955955
onSuccess:^(NSDictionary *result) {
956956
NSString *successMessage = [NSString stringWithFormat:@"In App Message with id: %@, successful POST click update for click id: %@, with result: %@", message.messageId, action.clickId, result];
957957
[OneSignalLog onesignalLog:ONE_S_LL_DEBUG message:successMessage];

iOS_SDK/OneSignalSDK/OneSignalNotifications/OSNotificationsManager.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -716,7 +716,7 @@ + (void)submitNotificationOpened:(NSString*)messageId {
716716
NSString* lastMessageId = [standardUserDefaults getSavedStringForKey:OSUD_LAST_MESSAGE_OPENED defaultValue:nil];
717717
//Only submit request if messageId not nil and: (lastMessage is nil or not equal to current one)
718718
if(messageId && (!lastMessageId || ![lastMessageId isEqualToString:messageId])) {
719-
[OneSignalCore.sharedClient executeRequest:[OSRequestSubmitNotificationOpened withUserId:[self pushSubscriptionId]
719+
[OneSignalCoreImpl.sharedClient executeRequest:[OSRequestSubmitNotificationOpened withUserId:[self pushSubscriptionId]
720720
appId:[OneSignalConfigManager getAppId]
721721
wasOpened:YES
722722
messageId:messageId

iOS_SDK/OneSignalSDK/OneSignalOutcomes/Source/OutcomeEvents/Controller/V1/OSOutcomeEventsV1Repository.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ - (void)requestMeasureOutcomeEventWithAppId:(NSString *)appId
6565
return;
6666
}
6767

68-
[OneSignalCore.sharedClient executeRequest:request onSuccess:successBlock onFailure:failureBlock];
68+
[OneSignalCoreImpl.sharedClient executeRequest:request onSuccess:successBlock onFailure:failureBlock];
6969
}
7070

7171
@end

iOS_SDK/OneSignalSDK/OneSignalOutcomes/Source/OutcomeEvents/Controller/V2/OSOutcomeEventsV2Repository.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ - (void)requestMeasureOutcomeEventWithAppId:(NSString *)appId
4343
appId:appId
4444
deviceType:deviceType];
4545

46-
[OneSignalCore.sharedClient executeRequest:request onSuccess:successBlock onFailure:failureBlock];
46+
[OneSignalCoreImpl.sharedClient executeRequest:request onSuccess:successBlock onFailure:failureBlock];
4747
}
4848

4949
@end

iOS_SDK/OneSignalSDK/OneSignalOutcomes/Source/OutcomeEvents/OneSignalOutcomeEventsController.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ - (void)sendSessionEndOutcomes:(NSNumber * _Nonnull)timeElapsed
111111
influenceParams:(NSArray<OSFocusInfluenceParam *> * _Nonnull)influenceParams
112112
onSuccess:(OSResultSuccessBlock _Nonnull)successBlock
113113
onFailure:(OSFailureBlock _Nonnull)failureBlock {
114-
[OneSignalCore.sharedClient executeRequest:[OSRequestSendSessionEndOutcomes
114+
[OneSignalCoreImpl.sharedClient executeRequest:[OSRequestSendSessionEndOutcomes
115115
withActiveTime:timeElapsed
116116
appId:appId
117117
pushSubscriptionId:pushSubscriptionId

iOS_SDK/OneSignalSDK/OneSignalUser/Source/Executors/OSIdentityOperationExecutor.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ class OSIdentityOperationExecutor: OSOperationExecutor {
179179
OSBackgroundTaskManager.beginBackgroundTask(backgroundTaskIdentifier)
180180
}
181181

182-
OneSignalCore.sharedClient().execute(request) { _ in
182+
OneSignalCoreImpl.sharedClient().execute(request) { _ in
183183
// No hydration from response
184184
// On success, remove request from cache
185185
self.addRequestQueue.removeAll(where: { $0 == request})
@@ -234,7 +234,7 @@ class OSIdentityOperationExecutor: OSOperationExecutor {
234234
OSBackgroundTaskManager.beginBackgroundTask(backgroundTaskIdentifier)
235235
}
236236

237-
OneSignalCore.sharedClient().execute(request) { _ in
237+
OneSignalCoreImpl.sharedClient().execute(request) { _ in
238238
// There is nothing to hydrate
239239
// On success, remove request from cache
240240
self.removeRequestQueue.removeAll(where: { $0 == request})

0 commit comments

Comments
 (0)