Do a migration in Core of the cached SDK versions

Author: nan-li

iOS_SDK/OneSignalSDK/OneSignalCore/Source/OneSignalCore.h

@@ -62,6 +62,7 @@
 // TODO: Testing: Should this class be defined in this file?
 @interface OneSignalCoreImpl : NSObject
 
++ (void)migrate;
 + (void)setSharedClient:(nonnull id<IOneSignalClient>)client;
 + (nonnull id<IOneSignalClient>)sharedClient;
 

iOS_SDK/OneSignalSDK/OneSignalCore/Source/OneSignalCore.m

@@ -30,6 +30,33 @@
 
 @implementation OneSignalCoreImpl
 
++ (void)migrate {
+    [self migrateCachedSdkVersion];
+    [self saveCurrentSDKVersion];
+}
+
+/// Every module should be responsible for its own migration, as it is possible for one module
+/// to finish migrating without another undergoing migration yet. See PR xxxxxxxx.
++ (void)migrateCachedSdkVersion {
+    if (![OneSignalUserDefaults.initShared keyExists:OSUD_LEGACY_CACHED_SDK_VERSION_FOR_MIGRATION]) {
+        return;
+    }
+    
+    // The default value should never be used, however the getSavedIntegerForKey method requires it
+    long sdkVersion = [OneSignalUserDefaults.initShared getSavedIntegerForKey:OSUD_LEGACY_CACHED_SDK_VERSION_FOR_MIGRATION defaultValue:0];
+    [OneSignalLog onesignalLog:ONE_S_LL_DEBUG message:[NSString stringWithFormat:@"OneSignalCoreImpl migrating cached SDK versions from version: %ld", sdkVersion]];
+
+    [OneSignalUserDefaults.initShared saveIntegerForKey:OSUD_CACHED_SDK_VERSION_FOR_CORE withValue:sdkVersion];
+    [OneSignalUserDefaults.initShared saveIntegerForKey:OSUD_CACHED_SDK_VERSION_FOR_OUTCOMES withValue:sdkVersion];
+    [OneSignalUserDefaults.initShared saveIntegerForKey:OSUD_CACHED_SDK_VERSION_FOR_IAM withValue:sdkVersion];
+    [OneSignalUserDefaults.initShared removeValueForKey:OSUD_LEGACY_CACHED_SDK_VERSION_FOR_MIGRATION];
+}
+
++ (void)saveCurrentSDKVersion {
+    int currentVersion = [ONESIGNAL_VERSION intValue];
+    [OneSignalUserDefaults.initShared saveIntegerForKey:OSUD_CACHED_SDK_VERSION_FOR_CORE withValue:currentVersion];
+}
+
 static id<IOneSignalClient> _sharedClient;
 + (id<IOneSignalClient>)sharedClient {
     if (!_sharedClient) {

iOS_SDK/OneSignalSDK/OneSignalExtension/OneSignalNotificationServiceExtensionHandler.m

@@ -132,6 +132,7 @@ + (void)addActionButtonsToExtentionRequest:(UNNotificationRequest*)request
 + (void)onNotificationReceived:(NSString *)receivedNotificationId withBlockingTask:(dispatch_semaphore_t)semaphore {
     if (receivedNotificationId && ![receivedNotificationId isEqualToString:@""]) {
         // If update was made without app being initialized/launched before -> migrate
+        [OneSignalCoreImpl migrate];
         [OSOutcomes migrate];
         [OneSignalLog onesignalLog:ONE_S_LL_VERBOSE message:[NSString stringWithFormat:@"NSE request received, sessionManager: %@", [OSSessionManager sharedSessionManager]]];
         // Save received notification id

iOS_SDK/OneSignalSDK/Source/OSMigrationController.m

@@ -40,6 +40,7 @@ + (OSOutcomeEventsCache *)outcomeEventsCache;
 @implementation OSMigrationController
 
 - (void)migrate {
+    [OneSignalCoreImpl migrate];
     [OSOutcomes migrate];
     let oneSignalInAppMessages = NSClassFromString(ONE_SIGNAL_IN_APP_MESSAGES_CLASS_NAME);
     if (oneSignalInAppMessages != nil && [oneSignalInAppMessages respondsToSelector:@selector(migrate)]) {