Skip to content

Commit dbc7c39

Browse files
committed
Move UIApplication+OneSignal from OneSIgnal > In App
* This extension on UIApplication is only used in the OneSignalInAppMessages framework, there is no need to keep it in the umbrella OneSignalFramework framework, which causes errors if only OneSignalInAppMessages is tested (without also importing OneSignalFramework).
1 parent 3745009 commit dbc7c39

File tree

5 files changed

+7
-15
lines changed

5 files changed

+7
-15
lines changed

iOS_SDK/OneSignalSDK/OneSignal.xcodeproj/project.pbxproj

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -361,9 +361,6 @@
361361
DE16C14524D3724700670EFA /* OneSignalLifecycleObserver.m in Sources */ = {isa = PBXBuildFile; fileRef = DE16C14324D3724700670EFA /* OneSignalLifecycleObserver.m */; };
362362
DE16C14724D3727200670EFA /* OneSignalLifecycleObserver.h in Headers */ = {isa = PBXBuildFile; fileRef = DE16C14624D3727200670EFA /* OneSignalLifecycleObserver.h */; };
363363
DE16C17024D3989A00670EFA /* OneSignalLifecycleObserver.m in Sources */ = {isa = PBXBuildFile; fileRef = DE16C14324D3724700670EFA /* OneSignalLifecycleObserver.m */; };
364-
DE20425E24E21C2C00350E4F /* UIApplication+OneSignal.m in Sources */ = {isa = PBXBuildFile; fileRef = DE20425D24E21C2C00350E4F /* UIApplication+OneSignal.m */; };
365-
DE20425F24E21C2C00350E4F /* UIApplication+OneSignal.m in Sources */ = {isa = PBXBuildFile; fileRef = DE20425D24E21C2C00350E4F /* UIApplication+OneSignal.m */; };
366-
DE20426024E21C2C00350E4F /* UIApplication+OneSignal.m in Sources */ = {isa = PBXBuildFile; fileRef = DE20425D24E21C2C00350E4F /* UIApplication+OneSignal.m */; };
367364
DE2D8F452947D85800844084 /* OneSignalExtension.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = DE7D17F927026BA3002D3A5D /* OneSignalExtension.framework */; };
368365
DE2D8F4A2947D86200844084 /* OneSignalOutcomes.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = DE7D188027037F43002D3A5D /* OneSignalOutcomes.framework */; };
369366
DE3784842888CFF900453A8E /* OneSignalUser.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = DE69E19B282ED8060090BB3D /* OneSignalUser.framework */; };
@@ -570,7 +567,6 @@
570567
DEC08B012947D4E900C81DA3 /* OneSignalSwiftInterface.swift in Sources */ = {isa = PBXBuildFile; fileRef = DEC08AFF2947D4E900C81DA3 /* OneSignalSwiftInterface.swift */; };
571568
DEC08B022947D4E900C81DA3 /* OneSignalSwiftInterface.swift in Sources */ = {isa = PBXBuildFile; fileRef = DEC08AFF2947D4E900C81DA3 /* OneSignalSwiftInterface.swift */; };
572569
DECE6F5B28C90821007058EE /* OneSignalOSCore.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 3C115161289A259500565C41 /* OneSignalOSCore.framework */; };
573-
DEE8198D24E21DF000868CBA /* UIApplication+OneSignal.h in Headers */ = {isa = PBXBuildFile; fileRef = DE20425C24E21C1500350E4F /* UIApplication+OneSignal.h */; };
574570
DEF5CCF52539321A0003E9CC /* AppDelegate.m in Sources */ = {isa = PBXBuildFile; fileRef = DEF5CCF42539321A0003E9CC /* AppDelegate.m */; };
575571
DEF5CCFB2539321A0003E9CC /* ViewController.m in Sources */ = {isa = PBXBuildFile; fileRef = DEF5CCFA2539321A0003E9CC /* ViewController.m */; };
576572
DEF5CCFE2539321A0003E9CC /* Main.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = DEF5CCFC2539321A0003E9CC /* Main.storyboard */; };
@@ -1580,8 +1576,6 @@
15801576
CACBAAAB218A662B000ACAA5 /* WebKit.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = WebKit.framework; path = System/Library/Frameworks/WebKit.framework; sourceTree = SDKROOT; };
15811577
DE16C14324D3724700670EFA /* OneSignalLifecycleObserver.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = OneSignalLifecycleObserver.m; sourceTree = "<group>"; };
15821578
DE16C14624D3727200670EFA /* OneSignalLifecycleObserver.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = OneSignalLifecycleObserver.h; sourceTree = "<group>"; };
1583-
DE20425C24E21C1500350E4F /* UIApplication+OneSignal.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = "UIApplication+OneSignal.h"; sourceTree = "<group>"; };
1584-
DE20425D24E21C2C00350E4F /* UIApplication+OneSignal.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = "UIApplication+OneSignal.m"; sourceTree = "<group>"; };
15851579
DE3CD2FE270FA9F200A5BECD /* OSOutcomes.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = OSOutcomes.m; sourceTree = "<group>"; };
15861580
DE51DDE3294262AB0073D5C4 /* OSRemoteParamController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = OSRemoteParamController.m; sourceTree = "<group>"; };
15871581
DE51DDE4294262AB0073D5C4 /* OSRemoteParamController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = OSRemoteParamController.h; sourceTree = "<group>"; };
@@ -1756,6 +1750,7 @@
17561750
/* End PBXFileSystemSynchronizedBuildFileExceptionSet section */
17571751

17581752
/* Begin PBXFileSystemSynchronizedRootGroup section */
1753+
3C1300472D46D59100CD690D /* Categories */ = {isa = PBXFileSystemSynchronizedRootGroup; explicitFileTypes = {}; explicitFolders = (); path = Categories; sourceTree = "<group>"; };
17591754
3C4398622D38C70400EFBD2C /* OneSignalInAppMessagesMocks */ = {isa = PBXFileSystemSynchronizedRootGroup; exceptions = (3C43986C2D38C70400EFBD2C /* PBXFileSystemSynchronizedBuildFileExceptionSet */, ); explicitFileTypes = {}; explicitFolders = (); path = OneSignalInAppMessagesMocks; sourceTree = "<group>"; };
17601755
/* End PBXFileSystemSynchronizedRootGroup section */
17611756

@@ -2576,8 +2571,6 @@
25762571
CA1A6E6820DC2E31001C41B9 /* OneSignalDialogController.m */,
25772572
CA1A6E6D20DC2E73001C41B9 /* OneSignalDialogRequest.h */,
25782573
CA1A6E6E20DC2E73001C41B9 /* OneSignalDialogRequest.m */,
2579-
DE20425C24E21C1500350E4F /* UIApplication+OneSignal.h */,
2580-
DE20425D24E21C2C00350E4F /* UIApplication+OneSignal.m */,
25812574
);
25822575
name = Categories;
25832576
sourceTree = "<group>";
@@ -2960,6 +2953,7 @@
29602953
DEBAAE292A4211DA00BF2C1C /* OneSignalInAppMessages */ = {
29612954
isa = PBXGroup;
29622955
children = (
2956+
3C1300472D46D59100CD690D /* Categories */,
29632957
DEBAAE4F2A4216A100BF2C1C /* Requests */,
29642958
DEBAAE4E2A42159000BF2C1C /* Model */,
29652959
DEBAAE4D2A42158600BF2C1C /* Controller */,
@@ -3175,7 +3169,6 @@
31753169
9124123D1E73342200E41FD7 /* UIApplicationDelegate+OneSignal.h in Headers */,
31763170
7AF9865324451F3900C36EAE /* OSFocusCallParams.h in Headers */,
31773171
DE7D18DD2703B44B002D3A5D /* OSFocusRequests.h in Headers */,
3178-
DEE8198D24E21DF000868CBA /* UIApplication+OneSignal.h in Headers */,
31793172
7AECE59C23675F5700537907 /* OSFocusTimeProcessorFactory.h in Headers */,
31803173
7AECE59A23674ADC00537907 /* OSUnattributedFocusTimeProcessor.h in Headers */,
31813174
9124121D1E73342200E41FD7 /* OneSignalJailbreakDetection.h in Headers */,
@@ -3780,6 +3773,9 @@
37803773
DEBAAE442A42121800BF2C1C /* PBXTargetDependency */,
37813774
DEBAAE482A42122000BF2C1C /* PBXTargetDependency */,
37823775
);
3776+
fileSystemSynchronizedGroups = (
3777+
3C1300472D46D59100CD690D /* Categories */,
3778+
);
37833779
name = OneSignalInAppMessages;
37843780
productName = OneSignalInAppMessages;
37853781
productReference = DEBAAE282A4211D900BF2C1C /* OneSignalInAppMessages.framework */;
@@ -4255,7 +4251,6 @@
42554251
7AFE856B2368DDB80091D6A5 /* OSFocusCallParams.m in Sources */,
42564252
7AECE59E23675F6300537907 /* OSFocusTimeProcessorFactory.m in Sources */,
42574253
7A93269C25AF4F0200BBEC27 /* OSPendingCallbacks.m in Sources */,
4258-
DE20425E24E21C2C00350E4F /* UIApplication+OneSignal.m in Sources */,
42594254
7AECE59623674AB700537907 /* OSUnattributedFocusTimeProcessor.m in Sources */,
42604255
3C448B9E2936ADFD002F96BC /* OSBackgroundTaskHandlerImpl.m in Sources */,
42614256
7AECE59023674A9700537907 /* OSAttributedFocusTimeProcessor.m in Sources */,
@@ -4380,7 +4375,6 @@
43804375
7A674F1C2360D82E001F9ACD /* OSBaseFocusTimeProcessor.m in Sources */,
43814376
7AFE856C2368DDB80091D6A5 /* OSFocusCallParams.m in Sources */,
43824377
7A93269D25AF4F0200BBEC27 /* OSPendingCallbacks.m in Sources */,
4383-
DE20425F24E21C2C00350E4F /* UIApplication+OneSignal.m in Sources */,
43844378
3C448B9F2936ADFD002F96BC /* OSBackgroundTaskHandlerImpl.m in Sources */,
43854379
912412371E73342200E41FD7 /* OneSignalTrackIAP.m in Sources */,
43864380
7AECE59123674A9700537907 /* OSAttributedFocusTimeProcessor.m in Sources */,
@@ -4463,7 +4457,6 @@
44634457
7AECE59223674A9700537907 /* OSAttributedFocusTimeProcessor.m in Sources */,
44644458
912412341E73342200E41FD7 /* OneSignalTracker.m in Sources */,
44654459
03866CBD2378A33B0009C1D8 /* OutcomeIntegrationTests.m in Sources */,
4466-
DE20426024E21C2C00350E4F /* UIApplication+OneSignal.m in Sources */,
44674460
03389F691FB548A0006537F0 /* OneSignalTrackFirebaseAnalyticsOverrider.m in Sources */,
44684461
7ABAF9D62457D3FF0074DFA0 /* ChannelTrackersTests.m in Sources */,
44694462
4529DED51FA823B900CEAB1D /* TestHelperFunctions.m in Sources */,

iOS_SDK/OneSignalSDK/OneSignalInAppMessages/Controller/OSMessagingController.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@
2626
*/
2727

2828
#import "OSMessagingController.h"
29-
#import "UIApplication+OneSignal.h" // Previously imported via "OneSignalHelper.h"
30-
#import "NSDateFormatter+OneSignal.h" // Previously imported via "OneSignalHelper.h"
29+
#import "UIApplication+OneSignal.h"
30+
#import "NSDateFormatter+OneSignal.h"
3131
#import <OneSignalCore/OneSignalCore.h>
3232
#import "OSInAppMessageClickResult.h"
3333
#import "OSInAppMessageClickEvent.h"

iOS_SDK/OneSignalSDK/Source/OneSignalLifecycleObserver.m

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ of this software and associated documentation files (the "Software"), to deal
3131
#import "OneSignalCommonDefines.h"
3232
#import "OneSignalTracker.h"
3333
#import <OneSignalLocation/OneSignalLocationManager.h>
34-
#import "UIApplication+OneSignal.h"
3534

3635
@implementation OneSignalLifecycleObserver
3736

0 commit comments

Comments
 (0)