rephrase and include a unit test

Author: HansVRP

openeo/extra/job_management/_manager.py

@@ -157,8 +157,8 @@ def start_job(
             - get_error_log_path
             - get_job_metadata_path
 
-    :param auto_download_results:
-        Optional disable the automated download of job results.
+    :param download_results:
+        Boolean to enable the automated download of job results once completed by the job manager.
 
     :param cancel_running_job_after:
         Optional temporal limit (in seconds) after which running jobs should be canceled
@@ -197,7 +197,7 @@ def __init__(
         poll_sleep: int = 60,
         root_dir: Optional[Union[str, Path]] = ".",
         *,
-        auto_download_results: bool = True,
+        download_results: bool = True,
         cancel_running_job_after: Optional[int] = None,
     ):
         """Create a MultiBackendJobManager."""
@@ -209,7 +209,7 @@ def __init__(
         # An explicit None or "" should also default to "."
         self._root_dir = Path(root_dir or ".")
 
-        self.auto_download_results = auto_download_results
+        self._download_results = download_results
 
         self._cancel_running_job_after = (
             datetime.timedelta(seconds=cancel_running_job_after) if cancel_running_job_after is not None else None
@@ -719,7 +719,7 @@ def on_job_done(self, job: BatchJob, row):
         :param row: DataFrame row containing the job's metadata.
         """
         # TODO: param `row` is never accessed in this method. Remove it? Is this intended for future use?
-        if self.auto_download_results:
+        if self._download_results:
             job_metadata = job.describe()
             job_dir = self.get_job_dir(job.job_id)
             metadata_path = self.get_job_metadata_path(job.job_id)

tests/extra/job_management/test_manager.py

@@ -897,3 +897,77 @@ def test_refresh_bearer_token_before_start(
         # Because of proactive+throttled token refreshing,
         # we should have 2 additional token requests now
         assert len(oidc_mock.grant_request_history) == 4
+
+    def test_on_job_done_boolean_download(
+        self, tmp_path, job_manager_root_dir, requests_mock
+    ):
+        """Test that job results are only downloaded when download_results=True"""
+
+        # Setup backend and connection
+        backend = "http://foo.test"
+        job_id = "job-test-123"
+        
+        requests_mock.get(backend, json={"api_version": "1.1.0"})
+        requests_mock.get(f"{backend}/jobs/{job_id}", json={
+            "id": job_id, 
+            "status": "finished",
+            "title": "Test Job"
+        })
+        requests_mock.get(f"{backend}/jobs/{job_id}/results", json={
+            "assets": {
+                "result.tif": {
+                    "href": f"{backend}/jobs/{job_id}/results/result.tif",
+                    "type": "image/tiff"
+                }
+            }
+        })
+        # Mock the actual file download
+        requests_mock.head(f"{backend}/jobs/{job_id}/results/result.tif", headers={"Content-Length": "100"})
+        requests_mock.get(f"{backend}/jobs/{job_id}/results/result.tif", content=b"fake_tiff_data")
+        
+        # Test with auto_download_results=False
+        manager_no_download = MultiBackendJobManager(
+            root_dir=job_manager_root_dir, 
+            download_results=False
+        )
+        connection = openeo.connect(backend)
+        manager_no_download.add_backend("foo", connection=connection)
+        
+        df = pd.DataFrame({"year": [2020]})
+        job = BatchJob(job_id=job_id, connection=connection)
+        row = df.loc[0]
+        
+        # Call on_job_done
+        manager_no_download.on_job_done(job=job, row=row)
+        
+        # Verify no files were downloaded and no directory was created
+        job_dir = manager_no_download.get_job_dir(job_id)
+        metadata_path = manager_no_download.get_job_metadata_path(job_id)
+        
+        assert not job_dir.exists(), "Job directory should not exist when auto_download_results=False"
+        assert not metadata_path.exists(), "Metadata file should not exist when auto_download_results=False"
+        
+        # Now test with auto_download_results=True
+        manager_with_download = MultiBackendJobManager(
+            root_dir=job_manager_root_dir, 
+            download_results=True
+        )
+        manager_with_download.add_backend("foo", connection=connection)
+        
+        # Call on_job_done
+        manager_with_download.on_job_done(job=job, row=row)
+        
+        # Verify files were downloaded and directory was created
+        assert job_dir.exists(), "Job directory should exist when auto_download_results=True"
+        assert metadata_path.exists(), "Metadata file should exist when auto_download_results=True"
+        
+        # Verify metadata content
+        with metadata_path.open("r", encoding="utf-8") as f:
+            metadata = json.load(f)
+        assert metadata["id"] == job_id
+        assert metadata["status"] == "finished"
+        
+        # Verify result file was downloaded
+        result_file = job_dir / "result.tif"
+        assert result_file.exists(), "Result file should be downloaded"
+        assert result_file.read_bytes() == b"fake_tiff_data"