Catch Throwable instead of Exception

[JohannesLichtenberger]

net.openhft.chronicle.core.Jvm.maxDirectMemory0 should catch Throwable instead of Exception, otherwise I can't create a usable native image of my DBS project: oracle/graal#8406 (comment)

[tgd]

Hi @JohannesLichtenberger thanks for bringing this to our attention - I've had a quick look through the linked thread but can you please summarize why this change needs to be made / how it blocks use of native image?

We do read issues created here but I can't share a resolution timeline yet, the more info we have the better regarding how this may impact users. We offer commercial support which we prioritize - if you need to expedite that please let me know directly or here - https://chronicle.software/contact-us/

[JohannesLichtenberger]

@tgd The issue is described here: oracle/graal#8406 (comment)

[JohannesLichtenberger]

@tgd it should be really easy to fix, plus I don't get any money with SirixDB (only spending money so far...) :-)

At some point however I'd be probably interested in spending some money on performance improvements, just because it's interesting to learn for me :)

[tgd]

Hi @JohannesLichtenberger - I've taken a look and yes indeed changing this call site is not much work. However, there are plenty of other callsites where we catch Exception and not Throwable. Will you run into the same issue there?

In general we are not focused on supporting graal at this time - as mentioned in the other thread we are depending on a number of JVM internals which may well cause further issues running on SubstrateVM.

But let's use this issue to detail some of the requirements and we can figure out where this sits in our roadmap.

[JohannesLichtenberger]

Sounds great. In any case, I'm also thinking about switching to MemorySegments or some lightweight abstraction on top, but I guess for now it would be easier to still use Chronicle Bytes (mostly I'm simply using Bytes.allocateElasticOnHeap(), so probably I won't run into other issues).

Would be wort a try IMHO if you could release a new patch version.

[JerryShea]

hi @JohannesLichtenberger - I've made the change in this branch. As @tgd says, there are other places that the same change may need to be made. Can I suggest you build that branch locally and try it out?