Code review #1
Description
First things to see:
- This is reaaaally insecure. I can inject any string there https://github.com/OpenNewsLabs/offline_speech_to_text/blob/master/pocketsphinx.js#L38 even delete the filesystem
- Standarize the code style. You can install something like http://jshint.com/install/ to help with this
- Either move the main.js to index.js or set main.js as your
mainfile into the package.json - https://github.com/OpenNewsLabs/offline_speech_to_text/blob/master/main.js#L9 you are usually not handling errors
- This will work only on mac right? https://github.com/OpenNewsLabs/offline_speech_to_text/blob/master/pocketsphinx.js#L34
- you can expose this as exports.convert https://github.com/OpenNewsLabs/offline_speech_to_text/blob/master/pocketsphinx.js#L69 also it can be the only thing you export using
module.exports = pocketSphinx;