feat: adds global nodes management form #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
louisgreiner
left a comment
louisgreiner
left a comment
There was a problem hiding this comment.
Looks very nice and the search bar is really good.
I wonder if we could ask user's confirmation when checking the box for all the nodes at once? This component already exists in the application I think, we can reuse it.
PS: you should make your PR into mrd/new-nodes-management-system I think, we use this as feature branch
...ditor-edit-tools-view-component/global-nodes-management/global-nodes-management.component.ts
Outdated
Show resolved
Hide resolved
clarani
reviewed
Nov 12, 2025
...tor-edit-tools-view-component/global-nodes-management/global-nodes-management.component.html
Outdated
Show resolved
Hide resolved
13 tasks
jacomyal
added a commit
that referenced
this pull request
Nov 13, 2025
This commit handles various feedbacks from reviewers on PR: #613 Details: - Fixes some FR translations - Renames "visible nodes" as "matching nodes" - Caches the matching nodes array - Adds a confirmation modal when clicking the global checkbox
jacomyal
changed the base branch from
main
to
mrd/new-nodes-management-system
louisgreiner
approved these changes
Nov 17, 2025
...ditor-edit-tools-view-component/global-nodes-management/global-nodes-management.component.ts
Outdated
Show resolved
Hide resolved
Math-R
pushed a commit
that referenced
this pull request
Nov 27, 2025
This commit handles various feedbacks from reviewers on PR: #613 Details: - Fixes some FR translations - Renames "visible nodes" as "matching nodes" - Caches the matching nodes array - Adds a confirmation modal when clicking the global checkbox
louisgreiner
reviewed
Dec 1, 2025
...tor-edit-tools-view-component/global-nodes-management/global-nodes-management.component.html
Show resolved
Hide resolved
louisgreiner
pushed a commit
that referenced
this pull request
Dec 4, 2025
This commit handles various feedbacks from reviewers on PR: #613 Details: - Fixes some FR translations - Renames "visible nodes" as "matching nodes" - Caches the matching nodes array - Adds a confirmation modal when clicking the global checkbox
louisgreiner
reviewed
Dec 4, 2025
...ditor-edit-tools-view-component/global-nodes-management/global-nodes-management.component.ts
Outdated
Show resolved
Hide resolved
jacomyal
added a commit
that referenced
this pull request
Dec 5, 2025
This commit handles various feedbacks from reviewers on PR: #613 Details: - Fixes some FR translations - Renames "visible nodes" as "matching nodes" - Caches the matching nodes array - Adds a confirmation modal when clicking the global checkbox
jacomyal
added a commit
that referenced
this pull request
Dec 5, 2025
This commit handles various feedbacks from reviewers on PR: #613 Details: - Fixes some EN translation - Fixes onClickGlobalCheckbox final apply process - Makes component no longer standalone, to fit other components declaration - Adds more space between name and short name columns
jacomyal
force-pushed
the
ajy/global-nodes-management
branch
from
dcfaea2 to
91f53ba
Compare
Contributor
|
Many thanks for the last changes, this looks very good to me now :) |
This commit addresses issue: OpenRailAssociation/osrd#13292 Details: - Adds new component GlobalNodesManagementComponent in app/view/editor-edit-tools-view-component - The new component controls the isCollapsed state of the nodes - Adds EN and FR translations for the new component - Adds the new component to the existing EditorEditToolsViewComponent panel
jacomyal
force-pushed
the
ajy/global-nodes-management
branch
from
91f53ba to
1873eec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR depends on PR #554. It should only be merged once #554 is merged as well.
This PR adds a new block in the "Edit" side panel, to allow controlling the
isCollapsedstate of the nodes.This form displays:
isCollapsedstateIssues
Checklist
documentation/