Skip to content

Commit a14bd86

Browse files
committed
Use the right Makefile syntax for not signing plugins on macOS.
1 parent a0c81d6 commit a14bd86

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

building/macos32x86/common/Makefile.plugin

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,10 +178,11 @@ $(PLUGINLIB): $(PLUGINREQS) $(VMDIR) $(OBJDIR) $(LIBOBJ) $(PLUGINFWKS)
178178

179179
# Either link with normal compiler/linker or with CXX compiler/linker. If
180180
# LINK_WITH_CXX is set, use e.g. clang++
181-
$(PLUGINBUNDLE): $(PLUGINREQS) $(PLUGINEXE) $(PLUGINICONS) $(PLUGINPLIST) $(PLUGINFWKS)
182181
ifeq ($(SIGNING_IDENTITY),)
182+
$(PLUGINBUNDLE): $(PLUGINREQS) $(PLUGINEXE) $(PLUGINICONS) $(PLUGINPLIST) $(PLUGINFWKS)
183183
echo "No signing identity found (SIGNING_IDENTITY unset). Not signing bundle."
184184
else
185+
$(PLUGINBUNDLE): $(PLUGINREQS) $(PLUGINEXE) $(PLUGINICONS) $(PLUGINPLIST) $(PLUGINFWKS)
185186
codesign --force --deep -s "$(SIGNING_IDENTITY)" $(PLUGINBUNDLE)
186187
endif
187188

building/macos64ARMv8/common/Makefile.plugin

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,10 +173,11 @@ $(PLUGINLIB): $(PLUGINREQS) $(VMDIR) $(OBJDIR) $(LIBOBJ) $(PLUGINFWKS)
173173

174174
# Either link with normal compiler/linker or with CXX compiler/linker. If
175175
# LINK_WITH_CXX is set, use e.g. clang++
176-
$(PLUGINBUNDLE): $(PLUGINREQS) $(PLUGINEXE) $(PLUGINICONS) $(PLUGINPLIST) $(PLUGINFWKS)
177176
ifeq ($(SIGNING_IDENTITY),)
177+
$(PLUGINBUNDLE): $(PLUGINREQS) $(PLUGINEXE) $(PLUGINICONS) $(PLUGINPLIST) $(PLUGINFWKS)
178178
echo "No signing identity found (SIGNING_IDENTITY unset). Not signing bundle."
179179
else
180+
$(PLUGINBUNDLE): $(PLUGINREQS) $(PLUGINEXE) $(PLUGINICONS) $(PLUGINPLIST) $(PLUGINFWKS)
180181
codesign --force --deep -s "$(SIGNING_IDENTITY)" \
181182
--timestamp --options=runtime \
182183
--entitlements $(ENTITLEMENTS_FILE) \

building/macos64x64/common/Makefile.plugin

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,10 +173,11 @@ $(PLUGINLIB): $(PLUGINREQS) $(VMDIR) $(OBJDIR) $(LIBOBJ) $(PLUGINFWKS)
173173

174174
# Either link with normal compiler/linker or with CXX compiler/linker. If
175175
# LINK_WITH_CXX is set, use e.g. clang++
176-
$(PLUGINBUNDLE): $(PLUGINREQS) $(PLUGINEXE) $(PLUGINICONS) $(PLUGINPLIST) $(PLUGINFWKS)
177176
ifeq ($(SIGNING_IDENTITY),)
177+
$(PLUGINBUNDLE): $(PLUGINREQS) $(PLUGINEXE) $(PLUGINICONS) $(PLUGINPLIST) $(PLUGINFWKS)
178178
echo "No signing identity found (SIGNING_IDENTITY unset). Not signing bundle."
179179
else
180+
$(PLUGINBUNDLE): $(PLUGINREQS) $(PLUGINEXE) $(PLUGINICONS) $(PLUGINPLIST) $(PLUGINFWKS)
180181
codesign --force --deep -s "$(SIGNING_IDENTITY)" \
181182
--timestamp --options=runtime \
182183
--entitlements $(ENTITLEMENTS_FILE) \

0 commit comments

Comments
 (0)