Skip to content

Commit adfd8fb

Browse files
jakub-wojciechowskifrangio
authored andcommitted
Warning in approve method documentation.
1 parent 98f672b commit adfd8fb

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

contracts/token/StandardToken.sol

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,11 @@ contract StandardToken is ERC20, BasicToken {
4040

4141
/**
4242
* @dev Approve the passed address to spend the specified amount of tokens on behalf of msg.sender.
43+
*
44+
* Beware that changing an allowance with this method brings the risk that someone may use both the old
45+
* and the new allowance by unfortunate transaction ordering. One possible solution to mitigate this
46+
* race condition is to first reduce the spender's allowance to 0 and set the desired value afterwards:
47+
* https://github.com/ethereum/EIPs/issues/20#issuecomment-263524729
4348
* @param _spender The address which will spend the funds.
4449
* @param _value The amount of tokens to be spent.
4550
*/

0 commit comments

Comments
 (0)