🚀 [Refactor]: Update GitHubAppInstallation constructor to use hashtable for property assignment; enhance GitHubAppContext to handle null permissions and app objects; improve parameter sets in Get-GitHubAppInstallation function for clarity.

Author: MariusStorhaug

src/classes/public/App/GitHubAppInstallation.ps1

@@ -48,9 +48,10 @@
 
     GitHubAppInstallation([PSCustomObject] $Object) {
         $this.ID = $Object.id
-        $this.App = [GitHubApp]::new()
-        $this.App.ClientID = $Object.client_id
-        $this.App.Slug = $Object.app_slug
+        $this.App = [GitHubApp]@{
+            ClientID = $Object.client_id
+            Slug     = $Object.app_slug
+        }
         $this.Target = [GitHubOwner]::new($Object.account)
         $this.Type = $Object.target_type
         $this.RepositorySelection = $Object.repository_selection
@@ -84,9 +85,10 @@
 
     GitHubAppInstallation([PSCustomObject] $Object, [string] $Target, [string] $Type, [string] $HostName) {
         $this.ID = $Object.id
-        $this.App = [GitHubApp]::new()
-        $this.App.ClientID = $Object.client_id
-        $this.App.Slug = $Object.app_slug
+        $this.App = [GitHubApp]@{
+            ClientID = $Object.client_id
+            Slug     = $Object.app_slug
+        }
         $this.Target = [GitHubOwner]@{
             Name = $Target
             Type = $Type

src/classes/public/Context/GitHubContext/GitHubAppContext.ps1

@@ -50,8 +50,12 @@
         $this.KeyVaultKeyReference = $Object.KeyVaultKeyReference
         $this.OwnerName = $Object.OwnerName
         $this.OwnerType = $Object.OwnerType
-        $this.Permissions = [GitHubPermission]::NewPermissionList($Object.Permissions)
+        if ($Object.Permissions) {
+            $this.Permissions = [GitHubPermission]::NewPermissionList($Object.Permissions)
+        }
         $this.Events = , ($Object.Events)
-        $this.App = [GitHubApp]::New($Object.App)
+        if ($Object.App) {
+            $this.App = [GitHubApp]::New($Object.App)
+        }
     }
 }

src/functions/private/Auth/Context/Set-GitHubContext.ps1

@@ -44,12 +44,14 @@
     }
 
     process {
-        Write-Debug 'Context:'
-        $contextObj | Out-String -Stream | ForEach-Object { Write-Debug $_ }
+        if ($DebugPreference -eq 'Continue') {
+            Write-Debug 'Context:'
+            $contextObj | Out-String -Stream | ForEach-Object { Write-Debug $_ }
+            Write-Debug "Getting info on the context [$($contextObj['AuthType'])]."
+        }
 
         # Run functions to get info on the temporary context.
         try {
-            Write-Debug "Getting info on the context [$($contextObj['AuthType'])]."
             switch -Regex (($contextObj['AuthType'])) {
                 'PAT|UAT|IAT' {
                     $viewer = Get-GitHubViewer -Context $contextObj
@@ -79,9 +81,9 @@
                         try {
                             $app = Get-GitHubApp -Slug $contextObj['Username'] -Context $contextObj
                             $contextObj['DisplayName'] = [string]$app.Name
-                            # TODO: $contextObj['App'] = $app
+                            $contextObj['App'] = $app
                         } catch {
-                            Write-Warning "Failed to get the GitHub App with the slug: [$($contextObj['Username'])]."
+                            Write-Warning "Unable to get the GitHub App: [$($contextObj['Username'])]."
                         }
                     }
                     if ($script:IsGitHubActions) {
@@ -114,12 +116,9 @@
                         if ([string]::IsNullOrEmpty($contextObj['InstallationName'])) {
                             $contextObj['InstallationName'] = [string]$installationName
                         }
-                        $contextObj['Name'] = "$($contextObj['HostName'])/$($contextObj['Username'])/" +
-                        "$($contextObj['InstallationType'])/$($contextObj['InstallationName'])"
-                    } else {
-                        $contextObj['Name'] = "$($contextObj['HostName'])/$($contextObj['Username'])/" +
-                        "$($contextObj['InstallationType'])/$($contextObj['InstallationName'])"
                     }
+                    $contextObj['Name'] = "$($contextObj['HostName'])/$($contextObj['Username'])/" +
+                    "$($contextObj['InstallationType'])/$($contextObj['InstallationName'])"
                 }
                 'App' {
                     $app = Get-GitHubApp -Context $contextObj
@@ -132,18 +131,20 @@
                     $contextObj['Events'] = [string[]]$app.Events
                     $contextObj['OwnerName'] = [string]$app.Owner.Name
                     $contextObj['OwnerType'] = [string]$app.Owner.Type
-                    $contextObj['App'] = $app
+                    $contextObj['App'] = [GitHubApp]$app
                     $contextObj['Type'] = 'App'
                 }
                 default {
                     throw 'Failed to get info on the context. Unknown logon type.'
                 }
             }
-            Write-Debug "Found [$($contextObj['Type'])] with login: [$($contextObj['Name'])]"
-            $contextObj | Out-String -Stream | ForEach-Object { Write-Debug $_ }
-            Write-Debug '----------------------------------------------------'
-            if ($PSCmdlet.ShouldProcess('Context', 'Set')) {
+            if ($DebugPreference -eq 'Continue') {
+                Write-Debug "Found [$($contextObj['Type'])] with login: [$($contextObj['Name'])]"
+                $contextObj | Out-String -Stream | ForEach-Object { Write-Debug $_ }
+                Write-Debug '----------------------------------------------------'
                 Write-Debug "Saving context: [$($contextObj['Name'])]"
+            }
+            if ($PSCmdlet.ShouldProcess('Context', 'Set')) {
                 Set-Context -ID $($contextObj['Name']) -Context $contextObj -Vault $script:GitHub.ContextVault
                 if ($Default) {
                     Switch-GitHubContext -Context $contextObj['Name']

src/functions/public/Apps/GitHub App Installations/Get-GitHubAppInstallation.ps1

@@ -45,7 +45,9 @@
         [int] $ID,
 
         # The number of results per page (max 100).
-        [Parameter()]
+        [Parameter(ParameterSetName = 'List installations for the authenticated app')]
+        [Parameter(ParameterSetName = 'List installations on an Enterprise Organization')]
+        [Parameter(ParameterSetName = 'List installations on an Organization')]
         [System.Nullable[int]] $PerPage,
 
         # The context to run the command in. Used to get the details for the API call.
@@ -80,12 +82,12 @@
                 }
                 Get-GitHubAppInstallationForOrganization @params
             }
-            'Get installation for the authenticated app by ID' {
-                Get-GitHubAppInstallationForAuthenticatedAppByID -ID $ID -Context $Context
-            }
             'List installations for the authenticated app' {
                 Get-GitHubAppInstallationForAuthenticatedAppAsList @params
             }
+            'Get installation for the authenticated app by ID' {
+                Get-GitHubAppInstallationForAuthenticatedAppByID -ID $ID -Context $Context
+            }
         }
     }