Skip to content

Commit 5bde93c

Browse files
🚀 [Breaking pre-release]: Remove AppID from GitHubApp (#523)
## Description This pull request removes the `AppID` property from the `GitHubApp` class and eliminates its usage throughout the codebase. The changes help simplify the class structure and ensure consistency in object construction. Class structure simplification: * Removed the `AppID` property from the `GitHubApp` class definition in `src/classes/public/App/GitHubApp.ps1`. * Removed assignment of `AppID` in the `GitHubApp` constructor in `src/classes/public/App/GitHubApp.ps1`. Object construction consistency: * Removed the `app_id` property when creating `GitHubApp` objects in both constructors of the `GitHubAppInstallation` class in `src/classes/public/App/GitHubAppInstallation.ps1`. [[1]](diffhunk://#diff-c1442a9fa3e51d2f0bf378039e97400122a24423d72d534112ca6f7c06a5ffaeL54) [[2]](diffhunk://#diff-c1442a9fa3e51d2f0bf378039e97400122a24423d72d534112ca6f7c06a5ffaeL94) ## Type of change <!-- Use the check-boxes [x] on the options that are relevant. --> - [ ] 📖 [Docs] - [ ] 🪲 [Fix] - [ ] 🩹 [Patch] - [ ] ⚠️ [Security fix] - [x] 🚀 [Feature] - [ ] 🌟 [Breaking change] ## Checklist <!-- Use the check-boxes [x] on the options that are relevant. --> - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas
1 parent e66d934 commit 5bde93c

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

src/classes/public/App/GitHubApp.ps1

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@
55
# The Client ID of the app
66
[string] $ClientID
77

8-
# The App ID of the app
9-
[System.Nullable[UInt64]] $AppID
10-
118
# The Slug of the app
129
[string] $Slug
1310

@@ -49,7 +46,6 @@
4946
GitHubApp([object]$Object) {
5047
$this.ID = $Object.id
5148
$this.ClientID = $Object.client_id
52-
$this.AppID = $Object.app_id
5349
$this.Slug = $Object.app_slug ?? $Object.slug
5450
$this.NodeID = $Object.node_id
5551
$this.Owner = [GitHubOwner]::new($Object.owner)

src/classes/public/App/GitHubAppInstallation.ps1

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@
5151
$this.App = [GitHubApp]::new(
5252
[PSCustomObject]@{
5353
client_id = $Object.client_id
54-
app_id = $Object.app_id
5554
app_slug = $Object.app_slug
5655
}
5756
)
@@ -91,7 +90,6 @@
9190
$this.App = [GitHubApp]::new(
9291
[PSCustomObject]@{
9392
client_id = $Object.client_id
94-
app_id = $Object.app_id
9593
app_slug = $Object.app_slug
9694
}
9795
)

0 commit comments

Comments
 (0)