Skip to content

Commit d00ee18

Browse files
MariusStorhaugMariusStorhaug
authored
🩹 [Patch]: Update formats so Name properties link to URL (#427)
## Description This pull request updates multiple PowerShell XML format files to enhance the display of `Name` and related fields as clickable hyperlinks pointing to their respective URLs. It also removes redundant `Url` columns from the tables for a cleaner and more concise output. - Fixes #425 ### Enhancements to hyperlink display: * Updated the `Name` field in several format files (`GitHubArtifact.Format.ps1xml`, `GitHubEnvironment.Format.ps1xml`, `GitHubLicense.Format.ps1xml`, `GitHubOwner.Format.ps1xml`, `GitHubRelease.Format.ps1xml`, `GitHubRepository.Format.ps1xml`, `GitHubTeam.Format.ps1xml`, `GitHubWorkflow.Format.ps1xml`, `GitHubWorkflowRun.Format.ps1xml`) to render as clickable hyperlinks using the URL property. * Removed redundant `Url` columns from the tables in the format files to streamline the display. ## Type of change <!-- Use the check-boxes [x] on the options that are relevant. --> - [ ] 📖 [Docs] - [ ] 🪲 [Fix] - [x] 🩹 [Patch] - [ ] ⚠️ [Security fix] - [ ] 🚀 [Feature] - [ ] 🌟 [Breaking change] ## Checklist <!-- Use the check-boxes [x] on the options that are relevant. --> - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas
1 parent eac0ed1 commit d00ee18

10 files changed

+10
-40
lines changed

‎src/formats/GitHubArtifact.Format.ps1xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
<PropertyName>ID</PropertyName>
3535
</TableColumnItem>
3636
<TableColumnItem>
37-
<PropertyName>Name</PropertyName>
37+
<ScriptBlock>"`e]8;;$($_.Url)`e\$($_.Name)`e]8;;`e\"</ScriptBlock>
3838
</TableColumnItem>
3939
<TableColumnItem>
4040
<ScriptBlock>'{0:F2}' -f ([math]::Round($_.Size / 1KB, 2))</ScriptBlock>

‎src/formats/GitHubEnvironment.Format.ps1xml‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,25 +17,19 @@
1717
<TableColumnHeader>
1818
<Label>Owner</Label>
1919
</TableColumnHeader>
20-
<TableColumnHeader>
21-
<Label>Url</Label>
22-
</TableColumnHeader>
2320
</TableHeaders>
2421
<TableRowEntries>
2522
<TableRowEntry>
2623
<TableColumnItems>
2724
<TableColumnItem>
28-
<PropertyName>Name</PropertyName>
25+
<ScriptBlock>"`e]8;;$($_.Url)`e\$($_.Name)`e]8;;`e\"</ScriptBlock>
2926
</TableColumnItem>
3027
<TableColumnItem>
3128
<PropertyName>Repository</PropertyName>
3229
</TableColumnItem>
3330
<TableColumnItem>
3431
<PropertyName>Owner</PropertyName>
3532
</TableColumnItem>
36-
<TableColumnItem>
37-
<PropertyName>Url</PropertyName>
38-
</TableColumnItem>
3933
</TableColumnItems>
4034
</TableRowEntry>
4135
</TableRowEntries>

‎src/formats/GitHubLicense.Format.ps1xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
<PropertyName>Key</PropertyName>
3232
</TableColumnItem>
3333
<TableColumnItem>
34-
<PropertyName>Name</PropertyName>
34+
<ScriptBlock>"`e]8;;$($_.Url)`e\$($_.Name)`e]8;;`e\"</ScriptBlock>
3535
</TableColumnItem>
3636
<TableColumnItem>
3737
<PropertyName>SpdxId</PropertyName>

‎src/formats/GitHubOwner.Format.ps1xml‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,12 @@
2323
<TableColumnHeader>
2424
<Label>Plan</Label>
2525
</TableColumnHeader>
26-
<TableColumnHeader>
27-
<Label>Url</Label>
28-
</TableColumnHeader>
2926
</TableHeaders>
3027
<TableRowEntries>
3128
<TableRowEntry>
3229
<TableColumnItems>
3330
<TableColumnItem>
34-
<PropertyName>Name</PropertyName>
31+
<ScriptBlock>"`e]8;;$($_.Url)`e\$($_.Name)`e]8;;`e\"</ScriptBlock>
3532
</TableColumnItem>
3633
<TableColumnItem>
3734
<PropertyName>ID</PropertyName>
@@ -45,9 +42,6 @@
4542
<TableColumnItem>
4643
<PropertyName>Plan</PropertyName>
4744
</TableColumnItem>
48-
<TableColumnItem>
49-
<PropertyName>Url</PropertyName>
50-
</TableColumnItem>
5145
</TableColumnItems>
5246
</TableRowEntry>
5347
</TableRowEntries>

‎src/formats/GitHubRelease.Format.ps1xml‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,6 @@
1717
<TableColumnHeader>
1818
<Label>Repository</Label>
1919
</TableColumnHeader>
20-
<TableColumnHeader>
21-
<Label>Url</Label>
22-
</TableColumnHeader>
2320
<TableColumnHeader>
2421
<Label>IsLatest</Label>
2522
</TableColumnHeader>
@@ -34,17 +31,14 @@
3431
<TableRowEntry>
3532
<TableColumnItems>
3633
<TableColumnItem>
37-
<PropertyName>Tag</PropertyName>
34+
<ScriptBlock>"`e]8;;$($_.Url)`e\$($_.Tag)`e]8;;`e\"</ScriptBlock>
3835
</TableColumnItem>
3936
<TableColumnItem>
4037
<PropertyName>Owner</PropertyName>
4138
</TableColumnItem>
4239
<TableColumnItem>
4340
<PropertyName>Repository</PropertyName>
4441
</TableColumnItem>
45-
<TableColumnItem>
46-
<PropertyName>Url</PropertyName>
47-
</TableColumnItem>
4842
<TableColumnItem>
4943
<PropertyName>IsLatest</PropertyName>
5044
</TableColumnItem>

‎src/formats/GitHubRepository.Format.ps1xml‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,6 @@
1717
<TableColumnHeader>
1818
<Label>Visibility</Label>
1919
</TableColumnHeader>
20-
<TableColumnHeader>
21-
<Label>Url</Label>
22-
</TableColumnHeader>
2320
<TableColumnHeader>
2421
<Label>Size (MB)</Label>
2522
</TableColumnHeader>
@@ -28,17 +25,14 @@
2825
<TableRowEntry>
2926
<TableColumnItems>
3027
<TableColumnItem>
31-
<PropertyName>Name</PropertyName>
28+
<ScriptBlock>"`e]8;;$($_.Url)`e\$($_.Name)`e]8;;`e\"</ScriptBlock>
3229
</TableColumnItem>
3330
<TableColumnItem>
3431
<PropertyName>Owner</PropertyName>
3532
</TableColumnItem>
3633
<TableColumnItem>
3734
<PropertyName>Visibility</PropertyName>
3835
</TableColumnItem>
39-
<TableColumnItem>
40-
<PropertyName>Url</PropertyName>
41-
</TableColumnItem>
4236
<TableColumnItem>
4337
<ScriptBlock>'{0:F2}' -f ([math]::Round($_.Size / 1KB, 2))</ScriptBlock>
4438
<Alignment>Right</Alignment>

‎src/formats/GitHubTeam.Format.ps1xml‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,22 +14,16 @@
1414
<TableColumnHeader>
1515
<Label>Owner</Label>
1616
</TableColumnHeader>
17-
<TableColumnHeader>
18-
<Label>Url</Label>
19-
</TableColumnHeader>
2017
</TableHeaders>
2118
<TableRowEntries>
2219
<TableRowEntry>
2320
<TableColumnItems>
2421
<TableColumnItem>
25-
<PropertyName>Name</PropertyName>
22+
<ScriptBlock>"`e]8;;$($_.Url)`e\$($_.Name)`e]8;;`e\"</ScriptBlock>
2623
</TableColumnItem>
2724
<TableColumnItem>
2825
<PropertyName>Owner</PropertyName>
2926
</TableColumnItem>
30-
<TableColumnItem>
31-
<PropertyName>Url</PropertyName>
32-
</TableColumnItem>
3327
</TableColumnItems>
3428
</TableRowEntry>
3529
</TableRowEntries>

‎src/formats/GitHubWorkflow.Format.ps1xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
</ScriptBlock>
4545
</TableColumnItem>
4646
<TableColumnItem>
47-
<PropertyName>Name</PropertyName>
47+
<ScriptBlock>"`e]8;;$($_.Url)`e\$($_.Name)`e]8;;`e\"</ScriptBlock>
4848
</TableColumnItem>
4949
<TableColumnItem>
5050
<PropertyName>ID</PropertyName>

‎src/formats/GitHubWorkflowRun.Format.ps1xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
</ScriptBlock>
4646
</TableColumnItem>
4747
<TableColumnItem>
48-
<PropertyName>Name</PropertyName>
48+
<ScriptBlock>"`e]8;;$($_.Url)`e\$($_.Name)`e]8;;`e\"</ScriptBlock>
4949
</TableColumnItem>
5050
<TableColumnItem>
5151
<PropertyName>ID</PropertyName>

‎tests/GitHub.Tests.ps1‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -351,7 +351,7 @@ ghadelimiter_6f9f5610-74ad-4b25-8ef3-7f3e9e764fa2
351351
Get-GitHubOutput
352352
} | Should -Not -Throw
353353
Write-Host (Get-GitHubOutput | Format-List | Out-String)
354-
}
354+
}
355355
It 'Reset-GitHubOutput - Should clear the outputs from the output file' {
356356
Set-GitHubOutput -Name 'TestOutput' -Value 'TestValue'
357357
(Get-GitHubOutput).TestOutput | Should -Be 'TestValue'

0 commit comments

Comments
 (0)