ICE Control Module: Added option to use VTOL transition state to trig… #25948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ger ICE on/off states Signed-off-by: Mf-ff99 <[email protected]>
dakejahl
previously approved these changes
Nov 19, 2025
src/modules/internal_combustion_engine_control/InternalCombustionEngineControl.cpp
Outdated
Show resolved
Hide resolved
Contributor
|
Hi Mark! Run |
Signed-off-by: Mf-ff99 <[email protected]>
…ionEngineControl.cpp to initialize vtol_vehicle_status_s correctly Initialize appropriately Co-authored-by: Jacob Dahl <[email protected]>
sfuhrer
requested changes
Nov 27, 2025
Contributor
sfuhrer
left a comment
sfuhrer
left a comment
There was a problem hiding this comment.
Makes sense! Just some details to figure out, but the intent makes sense.
| if ((vtol_status.vehicle_vtol_state == vtol_vehicle_status_s::VEHICLE_VTOL_STATE_FW || | ||
| vtol_status.vehicle_vtol_state == vtol_vehicle_status_s::VEHICLE_VTOL_STATE_TRANSITION_TO_FW) && | ||
| vehicle_status.arming_state == vehicle_status_s::ARMING_STATE_ARMED) { | ||
| user_request = UserOnOffRequest::On; |
Contributor
There was a problem hiding this comment.
Suggested change
| user_request = UserOnOffRequest::On; | |
| _user_request = UserOnOffRequest::On; |
As it changed 2 weeks ago in https://github.com/PX4/PX4-Autopilot/pull/25923/files
Contributor
There was a problem hiding this comment.
You can just do
_user_request = vehilce_status.vehicle_type == VEHICLE_TYPE_FIXED_WING || vehilce_status.in_transition_to_fw;
| #include <uORB/topics/vehicle_status.h> | ||
| #include <uORB/topics/rpm.h> | ||
| #include <uORB/topics/actuator_motors.h> | ||
| #include <uORB/topics/vtol_vehicle_status.h> |
Contributor
There was a problem hiding this comment.
You have all the info you need already in vehicle_status, see my other comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users the option to configure the ICE Control Module to trigger on/off states based on VTOL transition state for VTOLs utilizing a combustion engine
Tested in SITL
https://review.px4.io/plot_app?log=94bf9ec5-d621-4667-b77a-f19f2972ced0