feat: diff editor improvements #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jonathanlab
commented
Dec 4, 2025
jonathanlab
commented
- collapsible Lines
- the ability to restore your changes made (per line, not per file yet)
- fixed a bug with scroll view
- basic handlers for file writing
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
joshsny
approved these changes
Dec 4, 2025
| return document.createElement("span"); | ||
| } | ||
|
|
||
| const button = document.createElement("button"); |
Contributor
Author
There was a problem hiding this comment.
yup, haven't figured out styling in the merge editor yet. It's a bit painful since we're working with pure DOM elements, not react, but you could probably spawn a react element here instead. This might be worth using: https://github.com/uiwjs/react-codemirror
Contributor
Author
Merge activity
|
jonathanlab
changed the base branch from
12-04-feat_session_viewer
to
graphite-base/196
- collapsible Lines - the ability to restore your changes made (per line, not per file yet) - fixed a bug with scroll view - basic handlers for file writing
jonathanlab
force-pushed
the
12-04-feat_diff_editor_improvements
branch
from
14e7fac to
b274472
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.