feat: continuous deviation checker (#114)

MarconLP · web-flow · commit 6a55835b0d12 · 2025-11-27T18:29:16.000+01:00
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -1,5 +1,8 @@
 name: Lint
 
+permissions:
+  contents: read
+
 on:
   push:
     branches: [main]
diff --git a/.github/workflows/migrate.yml b/.github/workflows/migrate.yml
@@ -1,4 +1,8 @@
 name: Deploy
+
+permissions:
+  contents: read
+
 on:
   push:
     paths:
diff --git a/.github/workflows/runScheduledJobs.yml b/.github/workflows/runScheduledJobs.yml
@@ -1,4 +1,5 @@
 name: Run scheduled jobs
+permissions: {}
 on:
   schedule:
     - cron: '*/10 12 * * *' # every 10 minutes at 12:00 PM UTC
diff --git a/.github/workflows/salaryDeviationChecker.yml b/.github/workflows/salaryDeviationChecker.yml
@@ -0,0 +1,23 @@
+name: Salary Deviation Checker
+permissions: {}
+on:
+  schedule:
+    - cron: '0 14 * * *'
+  workflow_dispatch:
+
+jobs:
+  salaryDeviationChecker:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Call salaryDeviationChecker endpoint
+        id: salaryDeviationChecker
+        uses: fjogeleit/http-request-action@v1
+        with:
+          url: '${{ vars.BASE_URL }}/salaryDeviationChecker'
+          method: 'POST'
+          customHeaders: '{"Authorization": "Bearer ${{ secrets.SYNC_ENDPOINT_KEY }}"}'
+          timeout: 30000
+      - name: Show Response
+        run: |
+          echo ${{ steps.salaryDeviationChecker.outputs.status }}
+          echo ${{ steps.salaryDeviationChecker.outputs.response }}
diff --git a/.github/workflows/scheduleCheckIns.yml b/.github/workflows/scheduleCheckIns.yml
@@ -1,7 +1,8 @@
 name: Schedule check-ins
+permissions: {}
 on:
   schedule:
-    - cron: '0 12 * * *'
+    - cron: '0 13 * * *'
   workflow_dispatch:
 
 jobs:
diff --git a/.github/workflows/syncDeelEmployees.yml b/.github/workflows/syncDeelEmployees.yml
@@ -1,4 +1,5 @@
 name: Sync Deel Employees
+permissions: {}
 on:
   schedule:
     - cron: '0 12 * * *'
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -1,5 +1,8 @@
 name: Test
 
+permissions:
+  contents: read
+
 on:
   push:
     branches: [main]
diff --git a/prisma/migrations/20251127163411_add_deviation_checker_fields/migration.sql b/prisma/migrations/20251127163411_add_deviation_checker_fields/migration.sql
@@ -0,0 +1,6 @@
+-- CreateEnum
+CREATE TYPE "SalaryDeviationStatus" AS ENUM ('IN_SYNC', 'DEVIATED');
+
+-- AlterTable
+ALTER TABLE "Employee" ADD COLUMN     "salaryDeviationCheckedAt" TIMESTAMP(3) NOT NULL DEFAULT CURRENT_TIMESTAMP,
+ADD COLUMN     "salaryDeviationStatus" "SalaryDeviationStatus";
diff --git a/prisma/schema.prisma b/prisma/schema.prisma
@@ -14,19 +14,26 @@ datasource db {
 }
 
 model Employee {
-  id                           String               @id @default(cuid())
+  id                           String                 @id @default(cuid())
   priority                     Priority
   reviewed                     Boolean
-  email                        String               @unique
+  email                        String                 @unique
   salaries                     Salary[]
   deelEmployee                 DeelEmployee?
-  keeperTestFeedback           KeeperTestFeedback[] @relation("employee")
+  keeperTestFeedback           KeeperTestFeedback[]   @relation("employee")
   checkIn30DaysScheduled       Boolean
   checkIn60DaysScheduled       Boolean
   checkIn80DaysScheduled       Boolean
-  proposedHires                ProposedHire[]       @relation("manager")
+  proposedHires                ProposedHire[]         @relation("manager")
   proposedHiresAsTalentPartner ProposedHire[]
-  keeperTestFeedbackSubmitted  KeeperTestFeedback[] @relation("manager")
+  keeperTestFeedbackSubmitted  KeeperTestFeedback[]   @relation("manager")
+  salaryDeviationStatus        SalaryDeviationStatus?
+  salaryDeviationCheckedAt     DateTime               @default(now())
+}
+
+enum SalaryDeviationStatus {
+  IN_SYNC
+  DEVIATED
 }
 
 model DeelEmployee {
diff --git a/src/routeTree.gen.ts b/src/routeTree.gen.ts
@@ -11,6 +11,7 @@
 import { Route as rootRouteImport } from './routes/__root'
 import { Route as SyncDeelEmployeesRouteImport } from './routes/syncDeelEmployees'
 import { Route as ScheduleCheckInsRouteImport } from './routes/scheduleCheckIns'
+import { Route as SalaryDeviationCheckerRouteImport } from './routes/salaryDeviationChecker'
 import { Route as RunScheduledJobsRouteImport } from './routes/runScheduledJobs'
 import { Route as ReceiveKeeperTestResultsRouteImport } from './routes/receiveKeeperTestResults'
 import { Route as ProposedHiresRouteImport } from './routes/proposed-hires'
@@ -34,6 +35,11 @@ const ScheduleCheckInsRoute = ScheduleCheckInsRouteImport.update({
   path: '/scheduleCheckIns',
   getParentRoute: () => rootRouteImport,
 } as any)
+const SalaryDeviationCheckerRoute = SalaryDeviationCheckerRouteImport.update({
+  id: '/salaryDeviationChecker',
+  path: '/salaryDeviationChecker',
+  getParentRoute: () => rootRouteImport,
+} as any)
 const RunScheduledJobsRoute = RunScheduledJobsRouteImport.update({
   id: '/runScheduledJobs',
   path: '/runScheduledJobs',
@@ -107,6 +113,7 @@ export interface FileRoutesByFullPath {
   '/proposed-hires': typeof ProposedHiresRoute
   '/receiveKeeperTestResults': typeof ReceiveKeeperTestResultsRoute
   '/runScheduledJobs': typeof RunScheduledJobsRoute
+  '/salaryDeviationChecker': typeof SalaryDeviationCheckerRoute
   '/scheduleCheckIns': typeof ScheduleCheckInsRoute
   '/syncDeelEmployees': typeof SyncDeelEmployeesRoute
   '/employee/$employeeId': typeof EmployeeEmployeeIdRoute
@@ -123,6 +130,7 @@ export interface FileRoutesByTo {
   '/proposed-hires': typeof ProposedHiresRoute
   '/receiveKeeperTestResults': typeof ReceiveKeeperTestResultsRoute
   '/runScheduledJobs': typeof RunScheduledJobsRoute
+  '/salaryDeviationChecker': typeof SalaryDeviationCheckerRoute
   '/scheduleCheckIns': typeof ScheduleCheckInsRoute
   '/syncDeelEmployees': typeof SyncDeelEmployeesRoute
   '/employee/$employeeId': typeof EmployeeEmployeeIdRoute
@@ -140,6 +148,7 @@ export interface FileRoutesById {
   '/proposed-hires': typeof ProposedHiresRoute
   '/receiveKeeperTestResults': typeof ReceiveKeeperTestResultsRoute
   '/runScheduledJobs': typeof RunScheduledJobsRoute
+  '/salaryDeviationChecker': typeof SalaryDeviationCheckerRoute
   '/scheduleCheckIns': typeof ScheduleCheckInsRoute
   '/syncDeelEmployees': typeof SyncDeelEmployeesRoute
   '/employee/$employeeId': typeof EmployeeEmployeeIdRoute
@@ -158,6 +167,7 @@ export interface FileRouteTypes {
     | '/proposed-hires'
     | '/receiveKeeperTestResults'
     | '/runScheduledJobs'
+    | '/salaryDeviationChecker'
     | '/scheduleCheckIns'
     | '/syncDeelEmployees'
     | '/employee/$employeeId'
@@ -174,6 +184,7 @@ export interface FileRouteTypes {
     | '/proposed-hires'
     | '/receiveKeeperTestResults'
     | '/runScheduledJobs'
+    | '/salaryDeviationChecker'
     | '/scheduleCheckIns'
     | '/syncDeelEmployees'
     | '/employee/$employeeId'
@@ -190,6 +201,7 @@ export interface FileRouteTypes {
     | '/proposed-hires'
     | '/receiveKeeperTestResults'
     | '/runScheduledJobs'
+    | '/salaryDeviationChecker'
     | '/scheduleCheckIns'
     | '/syncDeelEmployees'
     | '/employee/$employeeId'
@@ -207,6 +219,7 @@ export interface RootRouteChildren {
   ProposedHiresRoute: typeof ProposedHiresRoute
   ReceiveKeeperTestResultsRoute: typeof ReceiveKeeperTestResultsRoute
   RunScheduledJobsRoute: typeof RunScheduledJobsRoute
+  SalaryDeviationCheckerRoute: typeof SalaryDeviationCheckerRoute
   ScheduleCheckInsRoute: typeof ScheduleCheckInsRoute
   SyncDeelEmployeesRoute: typeof SyncDeelEmployeesRoute
   EmployeeEmployeeIdRoute: typeof EmployeeEmployeeIdRoute
@@ -229,6 +242,13 @@ declare module '@tanstack/react-router' {
       preLoaderRoute: typeof ScheduleCheckInsRouteImport
       parentRoute: typeof rootRouteImport
     }
+    '/salaryDeviationChecker': {
+      id: '/salaryDeviationChecker'
+      path: '/salaryDeviationChecker'
+      fullPath: '/salaryDeviationChecker'
+      preLoaderRoute: typeof SalaryDeviationCheckerRouteImport
+      parentRoute: typeof rootRouteImport
+    }
     '/runScheduledJobs': {
       id: '/runScheduledJobs'
       path: '/runScheduledJobs'
@@ -327,6 +347,7 @@ const rootRouteChildren: RootRouteChildren = {
   ProposedHiresRoute: ProposedHiresRoute,
   ReceiveKeeperTestResultsRoute: ReceiveKeeperTestResultsRoute,
   RunScheduledJobsRoute: RunScheduledJobsRoute,
+  SalaryDeviationCheckerRoute: SalaryDeviationCheckerRoute,
   ScheduleCheckInsRoute: ScheduleCheckInsRoute,
   SyncDeelEmployeesRoute: SyncDeelEmployeesRoute,
   EmployeeEmployeeIdRoute: EmployeeEmployeeIdRoute,
diff --git a/src/routes/management.tsx b/src/routes/management.tsx
@@ -36,26 +36,6 @@ export const Route = createFileRoute('/management')({
   component: RouteComponent,
 })
 
-const fetchDeelContract = async (id: string) => {
-  const response = await fetch(
-    `https://api.letsdeel.com/rest/v2/contracts/${id}`,
-    {
-      method: 'GET',
-      headers: {
-        Authorization: `Bearer ${process.env.DEEL_API_KEY}`,
-      },
-    },
-  )
-
-  if (response.status !== 200) {
-    throw new Error(`Failed to fetch contract: ${response.statusText}`)
-  }
-
-  const data = await response.json()
-
-  return data.data
-}
-
 const getUsers = createAuthenticatedFn({
   method: 'GET',
 }).handler(async () => {
@@ -87,101 +67,6 @@ const startReviewCycle = createAuthenticatedFn({
   })
 })
 
-const checkSalaryDeviation = createAuthenticatedFn({
-  method: 'POST',
-}).handler(async () => {
-  const deelEmployees = await fetchDeelEmployees()
-  const employees = await prisma.employee.findMany({
-    where: {
-      salaries: { some: {} },
-      deelEmployee: { isNot: null },
-    },
-    include: {
-      salaries: {
-        orderBy: {
-          timestamp: 'desc',
-        },
-      },
-    },
-  })
-
-  const results: Array<{
-    email: string
-    salary: number
-    deelSalary: number
-    deviation: number
-    deviationPercentage: number
-    compensation_details: any
-    team: string
-  }> = []
-  const errors: Array<string> = []
-
-  for (const employee of employees) {
-    try {
-      const localDeelEmployee = deelEmployees.find(
-        (x) => x.workEmail === employee.email,
-      )
-      const { compensation_details } = await fetchDeelContract(
-        localDeelEmployee?.contractId ?? '',
-      )
-
-      const calcDeelSalary = (compensation_details: any) => {
-        if (compensation_details.gross_annual_salary != 0) {
-          return Number(compensation_details.gross_annual_salary)
-        }
-
-        if (compensation_details.scale === 'monthly') {
-          return Number(compensation_details.amount) * 12
-        }
-        return Number(compensation_details.amount)
-      }
-
-      results.push({
-        email: employee.email,
-        salary: employee.salaries[0].actualSalaryLocal,
-        deelSalary: calcDeelSalary(compensation_details),
-        deviation:
-          employee.salaries[0].actualSalaryLocal -
-          calcDeelSalary(compensation_details),
-        deviationPercentage:
-          Math.abs(
-            employee.salaries[0].actualSalaryLocal -
-              calcDeelSalary(compensation_details),
-          ) / employee.salaries[0].actualSalaryLocal,
-        compensation_details: compensation_details,
-        team: localDeelEmployee?.team ?? '',
-      })
-      console.log('processed employee: ' + employee.email)
-    } catch (error) {
-      const errorMessage =
-        error instanceof Error ? error.message : 'Unknown error'
-      errors.push(
-        `Error processing employee ${employee.email}: ${errorMessage}`,
-      )
-      console.error(
-        'Error processing employee: ' + employee.email + ' - ' + errorMessage,
-      )
-    }
-  }
-
-  return {
-    allResults: results,
-    filteredResultsNote: 'Deviation percentage > 0.1%',
-    filteredResults: results
-      .filter((x) => x.deviationPercentage > 0.001)
-      .map((x) => ({
-        deelSalary: x.deelSalary,
-        deviation: x.deviation,
-        deviationPercentage: x.deviationPercentage,
-        email: x.email,
-        salary: x.salary,
-        currency: x.compensation_details.currency_code,
-        team: x.team,
-      })),
-    errors,
-  }
-})
-
 const populateInitialEmployeeSalaries = createAuthenticatedFn({
   method: 'POST',
 }).handler(async () => {
@@ -503,31 +388,6 @@ function RouteComponent() {
           >
             Populate initial employee salaries
           </Button>
-          <Button
-            onClick={async () => {
-              createToast(
-                'Checking salary deviation... (this may take a while). Results will be logged in the console.',
-                {
-                  timeout: 10000,
-                },
-              )
-              const results = await checkSalaryDeviation()
-              console.log(results)
-              router.invalidate()
-
-              createToast('Salary deviation checked successfully.', {
-                timeout: 10000,
-                action: {
-                  text: 'Close',
-                  callback(toast) {
-                    toast.destroy()
-                  },
-                },
-              })
-            }}
-          >
-            Check salary deviation compared to Deel
-          </Button>
           <KeeperTestManagement />
         </div>
       </div>
diff --git a/src/routes/receiveKeeperTestResults.tsx b/src/routes/receiveKeeperTestResults.tsx
@@ -7,7 +7,7 @@ export const Route = createFileRoute('/receiveKeeperTestResults')({
       POST: async ({ request }) => {
         const token = new URL(request.url).searchParams.get('token')
         if (token !== process.env.SYNC_ENDPOINT_KEY) {
-          return new Response('Unauthorized' + token, { status: 401 })
+          return new Response('Unauthorized', { status: 401 })
         }
 
         const formData = await request.formData()
diff --git a/src/routes/runScheduledJobs.tsx b/src/routes/runScheduledJobs.tsx
@@ -31,7 +31,7 @@ export const Route = createFileRoute('/runScheduledJobs')({
       POST: async ({ request }) => {
         const token = request.headers.get('Authorization')?.split(' ')[1]
         if (token !== process.env.SYNC_ENDPOINT_KEY) {
-          return new Response('Unauthorized' + token, { status: 401 })
+          return new Response('Unauthorized', { status: 401 })
         }
 
         const getSlackMessageBody = (
diff --git a/src/routes/salaryDeviationChecker.tsx b/src/routes/salaryDeviationChecker.tsx
diff --git a/src/routes/scheduleCheckIns.tsx b/src/routes/scheduleCheckIns.tsx
diff --git a/src/routes/syncDeelEmployees.tsx b/src/routes/syncDeelEmployees.tsx

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`name: Run scheduled jobs`
	`2`	`+permissions: {}`
`2`	`3`	`on:`
`3`	`4`	`schedule:`
`4`	`5`	`- cron: '/10 12 * *' # every 10 minutes at 12:00 PM UTC`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`name: Sync Deel Employees`
	`2`	`+permissions: {}`
`2`	`3`	`on:`
`3`	`4`	`schedule:`
`4`	`5`	`- cron: '0 12 * * *'`