-
Notifications
You must be signed in to change notification settings - Fork 32
included evaluated_at properties in $feature_flag_called events
#321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 4 commits
61df3c1
02b1ada
23f3877
74cbc55
35c666b
045d504
f8c74b0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,4 +34,18 @@ public interface PostHogFeatureFlagsInterface { | |
| public fun shutDown() { | ||
| // no-op by default | ||
| } | ||
|
|
||
| public fun getRequestId( | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's a |
||
| distinctId: String? = null, | ||
| groups: Map<String, String>? = null, | ||
| personProperties: Map<String, Any?>? = null, | ||
| groupProperties: Map<String, Map<String, Any?>>? = null, | ||
| ): String? | ||
|
|
||
| public fun getEvaluatedAt( | ||
| distinctId: String? = null, | ||
| groups: Map<String, String>? = null, | ||
| personProperties: Map<String, Any?>? = null, | ||
| groupProperties: Map<String, Map<String, Any?>>? = null, | ||
| ): Long? | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,6 +10,8 @@ import org.codehaus.mojo.animal_sniffer.IgnoreJRERequirement | |
| * @property featureFlagPayloads the feature flag payloads | ||
| * @property flags the feature flags. | ||
| * @property quotaLimited array of quota limited features | ||
| * @property requestId the request id generated by the flags server on evaluation | ||
| * @property evaluatedAt the evaluated at timestamp generated by the flags server on evaluation | ||
| */ | ||
| @IgnoreJRERequirement | ||
| @PostHogInternal | ||
|
|
@@ -21,4 +23,5 @@ public data class PostHogFlagsResponse( | |
| val flags: Map<String, FeatureFlag>? = null, | ||
| val quotaLimited: List<String>? = null, | ||
| val requestId: String?, | ||
| val evaluatedAt: Long?, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. will do! |
||
| ) : PostHogRemoteConfigResponse() | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is either a long or a string depending on whether or not
evaluatedAtis null. Does this introduce a chance of creating the$feature_flag_evaluated_atproperty definition with the wrong type? If so, maybe we only write it when it's non-nullThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d'oh; you're so right