chore: Endpoints cleanup ✨ #42216
Merged
chore: Endpoints cleanup ✨ #42216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakce
force-pushed
the
chore/endpoints-cleanup
branch
from
608e6ee to
b82fc34
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
sakce
changed the title
Contributor
|
Size Change: -119 B (0%) Total Size: 3.41 MB ℹ️ View Unchanged
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sakce
commented
Nov 27, 2025
| if not saved_query.table: | ||
| return False | ||
|
|
||
| # Check if materialized data is stale |
| }, | ||
| confirmToggleActive: ({ endpoint }) => { | ||
| const isActivating = !endpoint.is_active | ||
| LemonDialog.open({ |
Contributor
Author
There was a problem hiding this comment.
i can smell someone shouting at me for putting a dialog here 👀
|
|
||
| const handleEditQuery = (): void => { | ||
| newTab(urls.sqlEditor(hogqlQuery.query)) | ||
| newTab(urls.sqlEditor(hogqlQuery.query, undefined, undefined, undefined, OutputTab.Endpoint, endpoint.name)) |
Contributor
Author
There was a problem hiding this comment.
This is so sexy now - if you want to edit a SQL query behind an Endpoint, this button takes you straight to the Endpoint outputTab with the endpoint name set and the toggle set to 'update existing' 🤤
| }, | ||
| createdAtColumn<EndpointType>() as LemonTableColumn<EndpointType, keyof EndpointType | undefined>, | ||
| createdByColumn<EndpointType>() as LemonTableColumn<EndpointType, keyof EndpointType | undefined>, | ||
| { |
Contributor
Author
There was a problem hiding this comment.
not quite sure - but I wanted to see what order I liked more
this is what the PR does
And this is what's in prod atm
Gilbert09
approved these changes
Nov 27, 2025
sakce
force-pushed
the
chore/endpoints-cleanup
branch
3 times, most recently
from
e265b5e to
be07752
Compare
Co-authored-by: sakovic.fx <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
sakce
force-pushed
the
chore/endpoints-cleanup
branch
from
be07752 to
779dee3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
found my room to be slightly messier than I like it
Changes
How did you test this code?
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Changelog: (features only) Is this feature complete?
not just yett