chore(data-warehouse): Use increased timeout limits for append syncs too

[Gilbert09]

Changes

• Use increased timeout/retry limits for append syncs

[greptile-apps]

_{2 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[Copilot]

Pull request overview

This PR extends increased timeout and retry limits to append-type syncs in addition to incremental syncs. Previously, only incremental syncs received extended timeouts (1 week timeout, 9 retry attempts), while append syncs used the default limits (24 hours timeout, 3 retry attempts).

• Updated the return value from create_external_data_job_model_activity to include both incremental and append sync types
• Renamed the incremental variable to incremental_or_append for clarity in the workflow
• Modified the timeout parameter selection logic to apply extended limits for both incremental and append syncs

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
posthog/temporal/data_imports/workflow_activities/create_job_model.py	Updated return value to check both is_incremental and is_append flags
posthog/temporal/data_imports/external_data_job.py	Renamed variable to incremental_or_append and updated conditional logic to apply extended timeout limits for append syncs

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

[Copilot]

Consider using the existing schema.should_use_incremental_field property instead of schema.is_incremental or schema.is_append. The model already defines this property (line 90-91 in external_data_schema.py) with the same logic, which would improve consistency and maintainability.

Suggested change

	return str(job.id), schema.is_incremental or schema.is_append, source.source_type
	return str(job.id), schema.should_use_incremental_field, source.source_type