Add Test case and more info

Author: JustinGrote

README.md

@@ -152,6 +152,9 @@ The focus of the rename support is on quick updates to variables or functions wi
 ❌ Scoped variables (e.g. $SCRIPT:test) are not currently supported
 ❌ Renaming a variable inside of a scriptblock that is used in unscoped operations like `Foreach-Parallel` or `Start-Job` and the variable is not defined within the scriptblock is not supported and can have unexpected results.
 ❌ Scriptblocks part of an assignment are considered isolated scopes. For example `$a = 5; $x = {$a}; & $x` does not consider the two $a to be related, even though in execution this reference matches.
+❌ Scriptblocks that are part of a parameter are assumed to not be executing in a different runspace. For example, the renaming behavior will treat `ForEach-Object -Parallel {$x}` the same as `Foreach-Object {$x}` for purposes of finding scope definitions. To avoid unexpected renaming, define/redefine all your variables in the scriptblock using a param block.
+❌ A lot of the logic relies on the position of items, so for example, defining a variable in a `begin` block and placing it after a `process` block, while technically correct in PowerShell, will not rename as expected. 
+❌ Similarly, defining a function, and having the function rely on a variable that is assigned outside the function and after the function definition, will not find the outer variable reference.
 
 📄📄 Filing a Rename Issue
 

test/PowerShellEditorServices.Test.Shared/Refactoring/Variables/VariableDefinedInParamBlock.ps1

@@ -0,0 +1,12 @@
+$x = 1
+function test {
+    begin {
+        $x = 5
+    }
+    process {
+        $x
+    }
+    end {
+        $x
+    }
+}

test/PowerShellEditorServices.Test.Shared/Refactoring/Variables/VariableDefinedInParamBlockRenamed.ps1

@@ -0,0 +1,12 @@
+$x = 1
+function test {
+    begin {
+        $Renamed = 5
+    }
+    process {
+        $Renamed
+    }
+    end {
+        $Renamed
+    }
+}

test/PowerShellEditorServices.Test.Shared/Refactoring/Variables/_RefactorVariableTestCases.cs

@@ -15,6 +15,7 @@ public class RefactorVariableTestCases
         new ("VariableCommandParameter.ps1",                   Line: 10, Column: 10),
         new ("VariableCommandParameterSplatted.ps1",           Line:  3, Column: 19 ),
         new ("VariableCommandParameterSplatted.ps1",           Line: 21, Column: 12),
+        new ("VariableDefinedInParamBlock.ps1",                Line: 10, Column:  9),
         new ("VariableDotNotationFromInnerFunction.ps1",       Line:  1, Column:  1),
         new ("VariableDotNotationFromInnerFunction.ps1",       Line: 11, Column: 26),
         new ("VariableInForeachDuplicateAssignment.ps1",       Line:  6, Column: 18),