Memory Optimization #12
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion-v2 # Conflicts: # Quill/Canvas.cs
Contributor
|
Thanks for this! Just started reviewing it, found an exception, if you open the demo and press an arrow key to shift to the other demo's the SVG Demo throws an exception in Mesh.cs. 
|
…ion-v2 # Conflicts: # Quill/Canvas.cs # Quill/External/LibTessDotNet/Dict.cs # Quill/External/LibTessDotNet/Mesh.cs # Quill/External/LibTessDotNet/MeshUtils.cs # Quill/External/LibTessDotNet/PriorityHeap.cs # Quill/External/LibTessDotNet/PriorityQueue.cs # Quill/External/LibTessDotNet/Sweep.cs # Quill/External/LibTessDotNet/Tess.cs # Quill/PolylineMesher.cs
Author
|
In order to fix everything, I just restarted from scratch. The performance improvement is not quite as high (only ~200-300 fps instead of ~300-400 fps), but the GC pressure seems to be reduced. It works with all of the examples provided in the canvas demo as well, so that is also a big improvement. I only need to implement support for .NET 2.1 now, and it's good for another review :) |
|
Is this still going to be integrated or are we waiting on Exanite to merge his PR first? |
Contributor
|
Ah, honestly, I had forgotten about this. I'll review it tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there was a lot of GC going on, so I went through the code base and did a lot of optimizations. Everything should be working exactly the same as before, just with much better memory usage.
There are a lot of changes here, and it's possible that I may have misunderstood some important aspects of the code. Functionally, the output is the same, so I think that it's okay, but it needs to be checked just in case.
Before
Allocation Rate: 995 MiB
Allocations: ~3327/frame
GC Events: Avg ~300/second
After
Allocation Rate: 43.88 MiB
Allocations: ~201/frame
GC Events: Avg ~3/second