Code cleanups for readability, bugfix: add in check to allow updating of previously null column values

Jareth Hein · Jareth Hein · commit 503cda03a105 · 2016-10-11T18:42:33.000-06:00
diff --git a/Intuit.QuickBase.Client/IQRecord.cs b/Intuit.QuickBase.Client/IQRecord.cs
@@ -27,7 +27,7 @@ public interface IQRecord
 
     internal interface IQRecord_int
     {
-        void ForceUpdateState(int RecordId);
+        void ForceUpdateState(int recId);
         void ForceUpdateState();
         int GetColumnIndex(string colName);
     }
diff --git a/Intuit.QuickBase.Client/QRecord.cs b/Intuit.QuickBase.Client/QRecord.cs
@@ -152,7 +152,7 @@ public void AcceptChanges()
             {
                 foreach (var field in _fields)
                 {
-                    if (field.Column.ColumnLookup == true) continue; //don't try to update values that are results of lookups
+                    if (field.Column.ColumnLookup) continue; //don't try to update values that are results of lookups
                     if (field.Update)
                     {
                         IField qField = new Field(field.FieldId, field.Type, field.QBValue);
@@ -172,7 +172,7 @@ public void AcceptChanges()
             {
                 foreach (var field in _fields)
                 {
-                    if (field.Column.ColumnLookup == true) continue; //don't try to update values that are results of lookups
+                    if (field.Column.ColumnLookup) continue; //don't try to update values that are results of lookups
                     IField qField = new Field(field.FieldId, field.Type, field.QBValue);
                     if (field.Type == FieldType.file)
                     {
@@ -219,9 +219,9 @@ private string CSVQuoter(string inStr)
                 return inStr;
         }
 
-        public void ForceUpdateState(int RecID)
+        public void ForceUpdateState(int recId)
         {
-            RecordId = RecID;
+            RecordId = recId;
         }
 
         public void ForceUpdateState()
@@ -345,7 +345,7 @@ private void SetExistingField(int index, int fieldIndex, object value)
             }
             else
             {
-                if (!_fields[fieldIndex].Value.Equals(value))
+                if (_fields[fieldIndex].Value == null || !_fields[fieldIndex].Value.Equals(value))
                 {
                     _fields[fieldIndex].Value = value;
                     if (RecordState != RecordState.New)

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ public interface IQRecord`
`27`	`27`
`28`	`28`	`internal interface IQRecord_int`
`29`	`29`	`{`
`30`		`- void ForceUpdateState(int RecordId);`
	`30`	`+ void ForceUpdateState(int recId);`
`31`	`31`	`void ForceUpdateState();`
`32`	`32`	`int GetColumnIndex(string colName);`
`33`	`33`	`}`
Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ public void AcceptChanges()`
`152`	`152`	`{`
`153`	`153`	`foreach (var field in _fields)`
`154`	`154`	`{`
`155`		`- if (field.Column.ColumnLookup == true) continue; //don't try to update values that are results of lookups`
	`155`	`+ if (field.Column.ColumnLookup) continue; //don't try to update values that are results of lookups`
`156`	`156`	`if (field.Update)`
`157`	`157`	`{`
`158`	`158`	`IField qField = new Field(field.FieldId, field.Type, field.QBValue);`
`@@ -172,7 +172,7 @@ public void AcceptChanges()`
`172`	`172`	`{`
`173`	`173`	`foreach (var field in _fields)`
`174`	`174`	`{`
`175`		`- if (field.Column.ColumnLookup == true) continue; //don't try to update values that are results of lookups`
	`175`	`+ if (field.Column.ColumnLookup) continue; //don't try to update values that are results of lookups`
`176`	`176`	`IField qField = new Field(field.FieldId, field.Type, field.QBValue);`
`177`	`177`	`if (field.Type == FieldType.file)`
`178`	`178`	`{`
`@@ -219,9 +219,9 @@ private string CSVQuoter(string inStr)`
`219`	`219`	`return inStr;`
`220`	`220`	`}`
`221`	`221`
`222`		`- public void ForceUpdateState(int RecID)`
	`222`	`+ public void ForceUpdateState(int recId)`
`223`	`223`	`{`
`224`		`- RecordId = RecID;`
	`224`	`+ RecordId = recId;`
`225`	`225`	`}`
`226`	`226`
`227`	`227`	`public void ForceUpdateState()`
`@@ -345,7 +345,7 @@ private void SetExistingField(int index, int fieldIndex, object value)`
`345`	`345`	`}`
`346`	`346`	`else`
`347`	`347`	`{`
`348`		`- if (!_fields[fieldIndex].Value.Equals(value))`
	`348`	`+ if (_fields[fieldIndex].Value == null \|\| !_fields[fieldIndex].Value.Equals(value))`
`349`	`349`	`{`
`350`	`350`	`_fields[fieldIndex].Value = value;`
`351`	`351`	`if (RecordState != RecordState.New)`