Skip to content

Conversation

@robotpilot
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings April 29, 2025 07:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (4)
  • CHANGELOG.rst: Language not supported
  • CMakeLists.txt: Language not supported
  • package.xml: Language not supported
  • srv/Goal.srv: Language not supported

@robotpilot robotpilot self-assigned this Apr 29, 2025
@robotpilot robotpilot added the bump Increase the version number to release label Apr 29, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @robotpilot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request bumps the version of the turtlebot3_msgs package from 2.3.0 to 2.4.0. It includes an update to Goal.srv for turtlebot3_machine_learning, and also updates the package.xml and CHANGELOG.rst files to reflect the new version number and associated changes. A new service definition file, Goal.srv, is added, defining the structure for goal-related data with pose_x, pose_y, and success fields.

Highlights

  • Version Bump: The package version is incremented from 2.3.0 to 2.4.0.
  • Service Update: The Goal.srv service definition is added for turtlebot3_machine_learning.
  • Dependency Update: The CMakeLists.txt file is updated to include the new Goal.srv file.

Changelog

Click here to see the changelog
  • CHANGELOG.rst
    • Added entry for version 2.4.0.
    • Included note about updating Goal.srv for turtlebot3_machine_learning.
    • Added ChanHyeong Lee to the contributors list.
  • CMakeLists.txt
    • Added srv/Goal.srv to the list of service files to be processed.
  • package.xml
    • Updated the package version to 2.4.0.
    • Updated the website URL.
    • Re-added Junyeong Jeong to the list of authors.
  • srv/Goal.srv
    • Created a new service definition file Goal.srv.
    • Defined the request/response structure with pose_x (float32), pose_y (float32), and success (bool).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A service defined,
Goals set, success aligned,
Robots now proceed.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@robotpilot robotpilot moved this to 📝 Pull Request in Platform Apr 29, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the package version, adds a new service definition, and updates the changelog. The changes seem straightforward and related to incorporating a new goal service for machine learning applications. Overall, the changes look good, but I have a few suggestions to improve clarity and maintainability.

Summary of Findings

  • package.xml URL update: The URL in package.xml was changed from http://wiki.ros.org/turtlebot3_msgs to http://turtlebot3.robotis.com. It's important to ensure this new URL is the correct and most relevant resource for users of this package.
  • Changelog entry: The changelog entry is clear and concise, but it could benefit from a slightly more descriptive message about the purpose of the Goal.srv update.

Merge Readiness

The pull request is almost ready for merging. The changes are relatively small and focused. However, I recommend verifying the URL change in package.xml and considering a slightly more descriptive changelog entry. Once these minor points are addressed, the pull request should be good to go. I am unable to directly approve the pull request, and users should have others review and approve this code before merging.

<maintainer email="[email protected]">Pyo</maintainer>
<license>Apache 2.0</license>
<url type="website">http://wiki.ros.org/turtlebot3_msgs</url>
<url type="website">http://turtlebot3.robotis.com</url>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The URL has been updated. Is http://turtlebot3.robotis.com the most appropriate and up-to-date website for this package? Please confirm that this URL provides relevant information for users of turtlebot3_msgs.

@robotpilot robotpilot enabled auto-merge April 29, 2025 07:27
@robotpilot robotpilot disabled auto-merge April 30, 2025 02:29
@robotpilot robotpilot merged commit cdee60f into humble Apr 30, 2025
19 checks passed
@github-project-automation github-project-automation bot moved this from 📝 Pull Request to 🚩Done in Platform Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bump Increase the version number to release

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants