Fix @local_xla//xla/stream_executor/rocm:rocm_timer_test_gpu_amd_any

draganmladjenovic · draganmladjenovic · commit 07cab8c96937 · 2024-10-15T07:30:57.000Z
diff --git a/third_party/xla/xla/stream_executor/rocm/BUILD b/third_party/xla/xla/stream_executor/rocm/BUILD
@@ -1092,7 +1092,6 @@ xla_test(
         "//xla/stream_executor:platform_manager",
         "//xla/stream_executor:stream",
         "//xla/stream_executor:typed_kernel_factory",
-        "//xla/stream_executor/gpu:gpu_stream",
         "//xla/stream_executor/gpu:gpu_test_kernels_rocm",
         "@com_google_absl//absl/status",
         "@com_google_absl//absl/time",
diff --git a/third_party/xla/xla/stream_executor/rocm/rocm_timer.cc b/third_party/xla/xla/stream_executor/rocm/rocm_timer.cc
@@ -61,7 +61,7 @@ RocmTimer::RocmTimer(Context* context, RocmEvent start_event,
 
 absl::StatusOr<absl::Duration> RocmTimer::GetElapsedDuration() {
   if (is_stopped_) {
-    return absl::InternalError("Measuring inactive timer");
+    return absl::FailedPreconditionError("Measuring inactive timer");
   }
   TF_RETURN_IF_ERROR(stream_->RecordEvent(&stop_event_));
   TF_ASSIGN_OR_RETURN(float elapsed_milliseconds,

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ RocmTimer::RocmTimer(Context* context, RocmEvent start_event,`
`61`	`61`
`62`	`62`	`absl::StatusOr<absl::Duration> RocmTimer::GetElapsedDuration() {`
`63`	`63`	`if (is_stopped_) {`
`64`		`- return absl::InternalError("Measuring inactive timer");`
	`64`	`+ return absl::FailedPreconditionError("Measuring inactive timer");`
`65`	`65`	`}`
`66`	`66`	`TF_RETURN_IF_ERROR(stream_->RecordEvent(&stop_event_));`
`67`	`67`	`TF_ASSIGN_OR_RETURN(float elapsed_milliseconds,`