repo: improve debugging & extent it to gmod

Related to #27

Author: RaphaelIT7

source/lua.cpp

@@ -93,6 +93,14 @@ void Lua::Shutdown()
 void Lua::FinalShutdown()
 {
 	g_Lua = NULL;
+	
+	for (auto& ref : Util::g_pReference)
+	{
+		if (Util::holylib_debug_mainutil.GetBool())
+			Msg("holylib: Discarding of old reference %i\n", ref);
+	}
+
+	Util::g_pReference.clear();
 }
 
 void Lua::ManualShutdown()

source/symbols.cpp

@@ -106,6 +106,16 @@ namespace Symbols
 		NULL_SIGNATURE, // ToDo
 	};
 
+	const std::vector<Symbol> CLuaInterface_ReferenceFreeSym = {
+		Symbol::FromName("_ZN13CLuaInterface13ReferenceFreeEi"),
+		NULL_SIGNATURE, // ToDo
+	};
+
+	const std::vector<Symbol> CLuaInterface_ReferenceCreateSym = {
+		Symbol::FromName("_ZN13CLuaInterface15ReferenceCreateEv"),
+		NULL_SIGNATURE, // ToDo
+	};
+
 	//---------------------------------------------------------------------------------
 	// Purpose: gameevent Symbols
 	//---------------------------------------------------------------------------------

source/symbols.h

@@ -152,6 +152,12 @@ namespace Symbols
 	typedef void (GMCOMMON_CALLING_CONVENTION* CBaseEntity_SetMoveType)(void* ent, int, int);
 	extern const std::vector<Symbol> CBaseEntity_SetMoveTypeSym;
 
+	typedef int (GMCOMMON_CALLING_CONVENTION* CLuaInterface_ReferenceCreate)(void* lua);
+	extern const std::vector<Symbol> CLuaInterface_ReferenceCreateSym;
+
+	typedef void (GMCOMMON_CALLING_CONVENTION* CLuaInterface_ReferenceFree)(void* lua, int ref);
+	extern const std::vector<Symbol> CLuaInterface_ReferenceFreeSym;
+
 	//---------------------------------------------------------------------------------
 	// Purpose: gameevent Symbols
 	//---------------------------------------------------------------------------------

source/util.cpp

@@ -197,6 +197,46 @@ static void hook_CSteam3Server_NotifyClientDisconnect(void* pServer, CBaseClient
 	detour_CSteam3Server_NotifyClientDisconnect.GetTrampoline<Symbols::CSteam3Server_NotifyClientDisconnect>()(pServer, pClient);
 }
 
+bool Util::bOurReferenceCall = false;
+static std::unordered_set<int> g_pGmodReference;
+static Detouring::Hook detour_CLuaInterface_ReferenceCreate;
+static int hook_CLuaInterface_ReferenceCreate(void* lua)
+{
+	int ref = detour_CLuaInterface_ReferenceCreate.GetTrampoline<Symbols::CLuaInterface_ReferenceCreate>()(lua);
+
+	if (Util::holylib_debug_mainutil.GetBool())
+		Msg("holylib: Created reference %i\n", ref);
+
+	if (Util::bOurReferenceCall)
+	{
+		auto it = Util::g_pReference.find(ref);
+		if (it != Util::g_pReference.end())
+		{
+			Error("holylib - gmd: Created a reference when we already holded it. How. Crash this shit.\n"); // If this happens maybe gmod does some weird shit?
+		}
+	}
+
+	return ref;
+}
+
+static Detouring::Hook detour_CLuaInterface_ReferenceFree;
+static void hook_CLuaInterface_ReferenceFree(void* lua, int ref)
+{
+	if (Util::holylib_debug_mainutil.GetBool())
+		Msg("holylib - gmod: Freed reference %i\n", ref);
+
+	if (Util::bOurReferenceCall)
+	{
+		auto it = Util::g_pReference.find(ref);
+		if (it == Util::g_pReference.end())
+		{
+			Error("holylib - gmod: Freed a reference when we didn't holded it. How. Crash this shit.\n"); // If this happens I'm happy.
+		}
+	}
+
+	detour_CLuaInterface_ReferenceFree.GetTrampoline<Symbols::CLuaInterface_ReferenceFree>()(lua, ref);
+}
+
 IGet* Util::get;
 CBaseEntityList* g_pEntityList = NULL;
 Symbols::lua_rawseti Util::func_lua_rawseti;
@@ -270,6 +310,18 @@ void Util::AddDetour()
 	func_lua_rawgeti = (Symbols::lua_rawgeti)Detour::GetFunction(lua_shared_loader.GetModule(), Symbols::lua_rawgetiSym);
 	Detour::CheckFunction((void*)func_lua_rawgeti, "lua_rawgeti");
 
+	Detour::Create(
+		&detour_CLuaInterface_ReferenceCreate, "CLuaInterface::ReferenceCreate",
+		lua_shared_loader.GetModule(), Symbols::CLuaInterface_ReferenceCreateSym,
+		(void*)hook_CLuaInterface_ReferenceCreate, 0
+	);
+
+	Detour::Create(
+		&detour_CLuaInterface_ReferenceFree, "CLuaInterface::ReferenceFree",
+		lua_shared_loader.GetModule(), Symbols::CLuaInterface_ReferenceFreeSym,
+		(void*)hook_CLuaInterface_ReferenceFree, 0
+	);
+
 	pEntityList = g_pModuleManager.FindModuleByName("entitylist");
 
 	/*

source/util.h

@@ -73,11 +73,14 @@ namespace Util
 	/*
 	 * Pure debugging
 	 */
+	extern bool bOurReferenceCall;
 	extern std::unordered_set<int> g_pReference;
 	extern ConVar holylib_debug_mainutil;
 	inline int ReferenceCreate(const char* reason)
 	{
+		bOurReferenceCall = true;
 		int iReference = g_Lua->ReferenceCreate();
+		bOurReferenceCall = false;
 
 		if (holylib_debug_mainutil.GetBool())
 			Msg("holylib: Created reference %i (%s)\n", iReference, reason);
@@ -105,7 +108,9 @@ namespace Util
 		}
 
 		g_pReference.erase(it);
+		bOurReferenceCall = true;
 		g_Lua->ReferenceFree(iReference);
+		bOurReferenceCall = false;
 	}
 
 	inline void StartTable() {