repo: try to fix a few warnings

Author: RaphaelIT7

README.md

@@ -83,6 +83,7 @@ On the next startup the ghostinj will update holylib to use the new file.
 \- [#] Optimized `CCvar::FindVar` (50x faster in average).  
 \- [#] Fixed `pvs.RemoveAllEntityFromTransmit` possibly causing stack issues.  
 \- [#] Completely changed how we Push/Manage Lua userdata to reduce memory leaks.  
+\- [#] Fixed a filesystem issue which could rarely result in a crash. (Issue: #23)  
 \- [-] Removed `holylib_filesystem_optimizedfixpath` since it was implemented into gmod itself.  
 
 You can see all changes here:  

source/lua/CLuaInterface.cpp

@@ -10,6 +10,11 @@
 #include "GarrysMod/Lua/LuaShared.h"
 #include "lua/PooledStrings.h"
 
+#if defined(__clang__) || defined(__GNUC__)
+#define POINT_UNREACHABLE   __builtin_unreachable()
+#else
+#define POINT_UNREACHABLE   __assume(false)
+#endif
 
 int g_iTypeNum = 0;
 
@@ -261,10 +266,11 @@ void* CLuaInterface::NewUserdata(unsigned int iSize)
 	return lua_newuserdata(state, iSize);
 }
 
-void CLuaInterface::ThrowError(const char* strError)
+[[noreturn]] void CLuaInterface::ThrowError(const char* strError)
 {
 	::DebugPrint(2, "CLuaInterface::ThrowError %s\n", strError);
 	luaL_error(state, "%s", strError);
+	POINT_UNREACHABLE;
 }
 
 void CLuaInterface::CheckType(int iStackPos, int iType)
@@ -279,10 +285,11 @@ void CLuaInterface::CheckType(int iStackPos, int iType)
 	}
 }
 
-void CLuaInterface::ArgError(int iArgNum, const char* strMessage)
+[[noreturn]] void CLuaInterface::ArgError(int iArgNum, const char* strMessage)
 {
 	::DebugPrint(2, "CLuaInterface::ArgError\n");
 	luaL_argerror(state, iArgNum, strMessage);
+	POINT_UNREACHABLE;
 }
 
 void CLuaInterface::RawGet(int iStackPos)

source/lua/ILuaInterface.h

@@ -529,6 +529,9 @@ namespace GarrysMod::Lua
 		virtual const char* CheckStringOpt( int iStackPos, const char* def ) = 0;
 		virtual double CheckNumberOpt( int iStackPos, double def ) = 0;
 		virtual void RegisterMetaTable( const char* name, ILuaObject* obj ) = 0;
+
+		// Not in gmod? Anyways.
+		virtual ~ILuaInterface() {}
 	};
 }
 #endif

source/modules/networking.cpp

@@ -610,7 +610,7 @@ bool entityHasOverride[MAX_EDICTS] {};
 class SendpropOverrideModule : public EntityModule, public AutoList<SendpropOverrideModule>
 {
 public:
-	SendpropOverrideModule(CBaseEntity *entity) : EntityModule(entity), entity(entity) {}
+	SendpropOverrideModule(CBaseEntity *pEntity) : EntityModule(pEntity), m_pEntity(pEntity) {}
 
 	~SendpropOverrideModule();
 
@@ -619,13 +619,13 @@ class SendpropOverrideModule : public EntityModule, public AutoList<SendpropOver
 
 	void RemoveOverride(int id);
 
-	CBaseEntity *entity;
+	CBaseEntity *m_pEntity;
 	std::vector<PropOverride> propOverrides;
 };
 
 SendpropOverrideModule::~SendpropOverrideModule()
 {
-	entityHasOverride[entity->entindex()] = false;
+	entityHasOverride[m_pEntity->entindex()] = false;
 }
 
 struct DatatableProxyOffset
@@ -719,14 +719,14 @@ int FindSendPropPrecalcIndex(SendTable *table, const std::string &name, int inde
 int SendpropOverrideModule::AddOverride(SendPropOverrideCallback callback, const std::string &name, int index, uintptr_t data)
 {
 	SendProp *prop = nullptr;
-	return this->AddOverride(callback, FindSendPropPrecalcIndex(entity->GetServerClass()->m_pTable, name, index, prop), prop, data);
+	return this->AddOverride(callback, FindSendPropPrecalcIndex(m_pEntity->GetServerClass()->m_pTable, name, index, prop), prop, data);
 }
 
 int SendpropOverrideModule::AddOverride(SendPropOverrideCallback callback, int indexProp, SendProp *prop, uintptr_t data)
 {
 	if (indexProp != -1) {
 		if (prop == nullptr) {
-			prop = (SendProp *) entity->GetServerClass()->m_pTable->m_pPrecalc->m_Props[indexProp];
+			prop = (SendProp *) m_pEntity->GetServerClass()->m_pTable->m_pPrecalc->m_Props[indexProp];
 		}
 		auto insertPos = propOverrides.end();
 		for (auto it = propOverrides.begin(); it != propOverrides.end(); it++) {
@@ -735,7 +735,7 @@ int SendpropOverrideModule::AddOverride(SendPropOverrideCallback callback, int i
 		PropOverride overr {++propOverrideId, callback, prop, indexProp, data};
 		propOverrides.insert(insertPos, overr);
 
-		entityHasOverride[entity->entindex()] = true;
+		entityHasOverride[m_pEntity->entindex()] = true;
 		return propOverrideId;
 	}
 	return -1;
@@ -1057,6 +1057,7 @@ int hook_SendTable_CalcDelta(
 	return count;
 }
 
+#if 0
 thread_local PackedEntity *preOldPack = nullptr;
 thread_local CEntityWriteInfo *writeInfo = nullptr;
 static Detouring::Hook detour_SV_DetermineUpdateType;
@@ -1112,6 +1113,7 @@ int hook_PackedEntity_GetPropsChangedAfterTick(PackedEntity* pPacked, int tick,
 
 	return result;
 }
+#endif
 
 static Detouring::Hook detour_CGameServer_SendClientMessages;
 static Symbols::CGameServer_SendClientMessages CGameServer_SendClientMessages_func;
@@ -1128,7 +1130,7 @@ void hook_CGameServer_SendClientMessages(CBaseServer* pServer, bool sendSnapshot
 		}
 
 		if (mod->propOverrides.empty())
-			entityHasOverride[mod->entity->entindex()] = false;
+			entityHasOverride[mod->m_pEntity->entindex()] = false;
 	}
 }
 
@@ -1280,6 +1282,11 @@ inline bool CCServerNetworkProperty::IsInPVS( const CCheckTransmitInfo *pInfo )
 	return false;		// not visible
 }
 
+inline CBaseEntity* CCServerNetworkProperty::GetBaseEntity()
+{
+	return m_pOuter;
+}
+
 /*
  * For now this is called from the pvs module meaning we RELY on it.
  * What did we change? basicly nothing yet. I'm just testing around.