steamworks: debug a issue

CGet seems to cache something which might be the cause.

Author: RaphaelIT7

source/modules/steamworks.cpp

@@ -25,7 +25,7 @@ static Symbols::SV_InitGameServerSteam func_SV_InitGameServerSteam;
 
 static Detouring::Hook detour_CSteam3Server_OnLoggedOff;
 static void hook_CSteam3Server_OnLoggedOff(CSteam3Server* srv, SteamServersDisconnected_t* info)
-{		
+{
 	detour_CSteam3Server_OnLoggedOff.GetTrampoline<Symbols::CSteam3Server_OnLoggedOff>()(srv, info);
 
 	if (Lua::PushHook("HolyLib:OnSteamDisconnect"))
@@ -37,7 +37,7 @@ static void hook_CSteam3Server_OnLoggedOff(CSteam3Server* srv, SteamServersDisco
 
 static Detouring::Hook detour_CSteam3Server_OnLogonSuccess;
 static void hook_CSteam3Server_OnLogonSuccess(CSteam3Server* srv, SteamServersConnected_t* info)
-{		
+{
 	detour_CSteam3Server_OnLogonSuccess.GetTrampoline<Symbols::CSteam3Server_OnLogonSuccess>()(srv, info);
 
 	if (Lua::PushHook("HolyLib:OnSteamConnect"))
@@ -139,6 +139,25 @@ void CSteamWorksModule::LuaShutdown()
 	}
 }
 
+static Detouring::Hook detour_CGet_SteamUGC;
+static void* hook_CGet_SteamUGC(IGet* pGet)
+{
+	void* pRet = detour_CGet_SteamUGC.GetTrampoline<Symbols::CGet_SteamUGC>()(pGet);
+	if (func_Steam3Server)
+	{
+		CSteam3Server& server = func_Steam3Server();
+
+		// pRet normally matches the SteamUGC but when the server was cleared like when it was Shutdown
+		// it gets apparent that CGet caches the value, which now is invalid.
+		Msg("holylib - Called CGet::SteamUGC %p - %p\n", pRet, server.SteamUGC());
+
+		if (!server.SteamUGC()) // If this is NULL then return NULL, most likely the CSteam3Server was cleared.
+			return NULL;
+	}
+
+	return pRet;
+}
+
 void CSteamWorksModule::InitDetour(bool bPreServer)
 {
 	if ( bPreServer ) { return; }
@@ -156,6 +175,12 @@ void CSteamWorksModule::InitDetour(bool bPreServer)
 		(void*)hook_CSteam3Server_OnLogonSuccess, m_pID
 	);
 
+	Detour::Create(
+		&detour_CGet_SteamUGC, "CGet::SteamUGC",
+		engine_loader.GetModule(), Symbols::CGet_SteamUGCSym,
+		(void*)hook_CGet_SteamUGC, m_pID
+	);
+
 	func_Steam3Server = (Symbols::Steam3ServerT)Detour::GetFunction(engine_loader.GetModule(), Symbols::Steam3ServerSym);
 	func_CSteam3Server_Shutdown = (Symbols::CSteam3Server_Shutdown)Detour::GetFunction(engine_loader.GetModule(), Symbols::CSteam3Server_ShutdownSym);
 	func_CSteam3Server_Activate = (Symbols::CSteam3Server_Activate)Detour::GetFunction(engine_loader.GetModule(), Symbols::CSteam3Server_ActivateSym);

source/symbols.cpp

@@ -560,6 +560,11 @@ namespace Symbols
 		Symbol::FromSignature("\x55\x48\x89\xE5\x53\x48\x83\xEC\x08\x48\x8B\x1D********\x00\x00\x01"), // 55 48 89 E5 53 48 83 EC 08 48 8B 1D ?? ?? ?? ?? ?? ?? ?? ?? 00 00 01
 	};
 
+	const std::vector<Symbol> CGet_SteamUGCSym = {
+		Symbol::FromName("_ZN4CGet8SteamUGCEv"),
+		NULL_SIGNATURE,
+	};
+
 	//---------------------------------------------------------------------------------
 	// Purpose: pas Symbols
 	//---------------------------------------------------------------------------------

source/symbols.h

@@ -429,6 +429,9 @@ namespace Symbols
 	typedef void (*SV_InitGameServerSteam)();
 	extern const std::vector<Symbol> SV_InitGameServerSteamSym;
 
+	typedef void* (*CGet_SteamUGC)(void*);
+	extern const std::vector<Symbol> CGet_SteamUGCSym;
+
 	//---------------------------------------------------------------------------------
 	// Purpose: pas Symbols
 	//---------------------------------------------------------------------------------