Skip to content

Commit fda27bb

Browse files
authored
WebGPUBackend: Remove redundant dispose handlers. (mrdoob#31603)
* WebGPUBackend: Remove redundant dispose handlers. * Textures: Delete backend data in `onDispose()`.
1 parent 3ebc5c3 commit fda27bb

File tree

2 files changed

+2
-18
lines changed

2 files changed

+2
-18
lines changed

src/renderers/common/Textures.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,7 @@ class Textures extends DataMap {
179179
}
180180

181181
this.delete( renderTarget );
182+
this.backend.delete( renderTarget );
182183

183184
};
184185

src/renderers/webgpu/WebGPUBackend.js

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,6 @@ class WebGPUBackend extends Backend {
390390
if ( descriptors === undefined ||
391391
renderTargetData.width !== renderTarget.width ||
392392
renderTargetData.height !== renderTarget.height ||
393-
renderTargetData.dimensions !== renderTarget.dimensions ||
394393
renderTargetData.activeMipmapLevel !== renderContext.activeMipmapLevel ||
395394
renderTargetData.activeCubeFace !== renderContext.activeCubeFace ||
396395
renderTargetData.samples !== renderTarget.samples
@@ -400,21 +399,6 @@ class WebGPUBackend extends Backend {
400399

401400
renderTargetData.descriptors = descriptors;
402401

403-
// dispose
404-
405-
const onDispose = () => {
406-
407-
renderTarget.removeEventListener( 'dispose', onDispose );
408-
this.delete( renderTarget );
409-
410-
};
411-
412-
if ( renderTarget.hasEventListener( 'dispose', onDispose ) === false ) {
413-
414-
renderTarget.addEventListener( 'dispose', onDispose );
415-
416-
}
417-
418402
}
419403

420404
const cacheKey = renderContext.getCacheKey();
@@ -534,7 +518,6 @@ class WebGPUBackend extends Backend {
534518
renderTargetData.samples = renderTarget.samples;
535519
renderTargetData.activeMipmapLevel = renderContext.activeMipmapLevel;
536520
renderTargetData.activeCubeFace = renderContext.activeCubeFace;
537-
renderTargetData.dimensions = renderTarget.dimensions;
538521

539522
}
540523

@@ -2230,7 +2213,7 @@ class WebGPUBackend extends Backend {
22302213
}
22312214

22322215
/**
2233-
* Checks if the given feature is supported by the backend.
2216+
* Checks if the given feature is supported by the backend.
22342217
*
22352218
* @param {string} name - The feature's name.
22362219
* @return {boolean} Whether the feature is supported or not.

0 commit comments

Comments
 (0)