In 1.2, entities representing files in root must have relative IDs, and vice versa

[elichad]

This is a new requirement in 1.2.

https://www.researchobject.org/ro-crate/specification/1.2/data-entities.html#core-metadata-for-data-entities

For an Attached RO-Crate Package:

• @id MUST be one of either: a. A relative URI, indicating that a file MUST be present at the path @id relative to the RO-Crate Root. b. ...

...
Note that if a local file is intended to be packaged within an Attached RO-Crate Package, the @id property MUST be a URI Path relative to the RO Crate Root...

#211 (comment)

The thing about relative IDs having corresponding existing files might need some changes. Relevant issues are #73 and #135.

[simleo]

I went throuhgh #136 (the fix for #135) again and I think that the current behavior (see the description of #136) is already compliant with the 1.2 requirements. The corner case described in #73 is still supported, while users must explicitly set the source of the missing file to None in order to write an invalid crate, and they get a warning anyway.

The vice versa is automatically true because the path generated for writing a local file is constructed by joining the output crate's root path with the file's id, see

ro-crate-py/rocrate/model/file.py

Line 74 in 8d115ea

out_file_path = Path(base_path) / unquote(self.id)

@elichad could you please double check and, if you agree, close this issue?