Skip to content

Conversation

@bhagyashreewagh
Copy link

Summary

Adds a single, additive IAM statement to allow iam:PassRole for the App Runner service-linked role.
This unblocks App Runner VPC connector creation (previously failing with AccessDenied).

List of Changes

  • Added infra/iam_app_runner_policy_addition.json (policy delta)
  • Added infra/README.md

Related Issues

Internal deployment blocker: App Runner VPC connector creation failed due to missing PassRole.

Detailed Description

App Runner needs permission for the deploy principal to iam:PassRole the App Runner service-linked role
during VPC connector creation/attachment. We scope this safely:
Resource: "*", with Condition: iam:AWSServiceName = apprunner.amazonaws.com.

No existing statements are replaced.

How to Test the Changes

  1. Admin merges this statement into the deploy user/group/role policy in IAM.

  2. Re-attempt creating the VPC connector in us-west-2

  3. Expect success (no AccessDenied on service-linked role).

    Screenshots

    N/A (infra policy change)

    Deployment Notes

    No code changes. Admin only needs to merge this statement into the existing deploy policy.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 29, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@netlify
Copy link

netlify bot commented Oct 29, 2025

Deploy Preview for antenna-preview ready!

Name Link
🔨 Latest commit 63e5f80
🔍 Latest deploy log https://app.netlify.com/projects/antenna-preview/deploys/690294f7b8a68d00084c468a
😎 Deploy Preview https://deploy-preview-1021--antenna-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 62 (🟢 up 31 from production)
Accessibility: 80 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Collaborator

@mihow mihow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhagyashreewagh this seems safe and helpful! Just one request, can we make the new infra/ folder more generic? move the policy to infra/aws/iam_app_runner_policy.json (unless it must go at the root), and update the README with a brief description of what will go in the infra/ directory. e.g. "Config files and documentation to assist with deployments of Antenna. All files must not contain sensitive information and should be generalizable for multiple organizations. Use environment variables or other means for configuration that is specific to a single deployment"

thank you!

@bhagyashreewagh bhagyashreewagh deleted the feat/apprunner-iam-passrole branch November 13, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants