Make DeviceSlice a newtype around [()] #44
Merged
+187
−127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RDambrosio016
requested changes
Feb 14, 2022
Member
RDambrosio016
left a comment
RDambrosio016
left a comment
There was a problem hiding this comment.
Great PR, couple of things that need to be sorted out, and the changes need to be documented in the changelog
Member
RDambrosio016
left a comment
RDambrosio016
left a comment
There was a problem hiding this comment.
Looks good, just needs changelog entries
beepster4096
force-pushed
the
dst_device_slice
branch
from
0e2685a to
eefda9c
Compare
Contributor
Author
|
Alright, changelog is upodated and merge conflicts are resolved |
Contributor
|
Hello! We are rebooting this project. Sorry for your PR not getting merged! Is this still relevant? |
Contributor
|
Thanks for this PR from a long time ago @beepster4096 ! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some unsoundness and fixes some of DeviceSlice's methods and docs not making any sense (such as from_raw_parts_mut)