[SQ] improvements

Author: samatstariongroup

CDP4Common.NetCore.Tests/Helpers/NestedElementTreeGeneratorTestFixture.cs

@@ -780,6 +780,8 @@ public void Verify_that_when_the_value_of_a_ValueArray_is_empty_the_algorithm_co
 
             var nestedElements = this.nestedElementTreeGenerator.Generate(option, system_engineering, false).ToList();
 
+            Assert.That(nestedElements, Is.Not.Empty);
+
             foreach (var nestedElement in nestedElements)
             {
                 Console.WriteLine($"NE: - {nestedElement.ShortName}:{nestedElement.Name}");

CDP4Common.Tests/Helpers/NestedElementTreeGeneratorTestFixture.cs

@@ -639,6 +639,8 @@ public void Verify_that_when_the_value_of_a_ValueArray_is_empty_the_algorithm_co
 
             var nestedElements = this.nestedElementTreeGenerator.Generate(option, system_engineering, false).ToList();
 
+            Assert.That(nestedElements, Is.Not.Empty);
+
             foreach (var nestedElement in nestedElements)
             {
                 Console.WriteLine($"NE: - {nestedElement.ShortName}:{nestedElement.Name}");

CDP4Common/Types/CacheKey.cs

@@ -120,15 +120,15 @@ public Guid? Iteration
         /// <summary>
         /// Indicates whether this instance and a specified object are equal.
         /// </summary>
-        /// <param name="other">
+        /// <param name="obj">
         /// The object to compare with the current instance.
         /// </param>
         /// <returns>
         /// true if obj and this instance are the same type and represent the same value; otherwise, false.
         /// </returns>
-        public override bool Equals(object other)
+        public override bool Equals(object obj)
         {
-            return (other is CacheKey cacheKey) && Equals(cacheKey);
+            return (obj is CacheKey cacheKey) && Equals(cacheKey);
         }
 
         /// <summary>

CDP4Dal/Composition/INameMetaData.cs

@@ -26,7 +26,7 @@ namespace CDP4Dal.Composition
 {
     /// <summary>
     /// The purpose of the <see cref="INameMetaData"/> interface is to define a Name property to be
-    /// used in conjunction with a custom <see cref="ExportAttribute"/>
+    /// used in conjunction with a custom <see cref="System.ComponentModel.Composition.ExportAttribute"/>
     /// </summary>
     public interface INameMetaData
     {

CDP4Dal/DAL/Dal.cs

@@ -97,7 +97,7 @@ protected Dal()
         /// <summary>
         /// Write all the <see cref="Operation"/>s from all the <see cref="OperationContainer"/>s asynchronously.
         /// </summary>
-        /// <param name="operationContainer">
+        /// <param name="operationContainers">
         /// The provided <see cref="OperationContainer"/> to write
         /// </param>
         /// <param name="files">
@@ -106,7 +106,7 @@ protected Dal()
         /// <returns>
         /// A list of <see cref="Thing"/>s that has been created or updated since the last Read or Write operation.
         /// </returns>
-        public abstract Task<IEnumerable<Thing>> Write(IEnumerable<OperationContainer> operationContainer, IEnumerable<string> files = null);
+        public abstract Task<IEnumerable<Thing>> Write(IEnumerable<OperationContainer> operationContainers, IEnumerable<string> files = null);
 
         /// <summary>
         /// Write all the <see cref="Operation"/>s from an <see cref="OperationContainer"/> asynchronously.
@@ -147,7 +147,7 @@ protected Dal()
         /// <param name="thing">
         /// An instance of <see cref="Thing"/> that needs to be read from the data-source
         /// </param>
-        /// <param name="token">
+        /// <param name="cancellationToken">
         /// The <see cref="CancellationToken"/>
         /// </param>
         /// <param name="attributes">
@@ -156,7 +156,7 @@ protected Dal()
         /// <returns>
         /// a list of <see cref="Thing"/> that are contained by the provided <see cref="Thing"/> including the <see cref="Thing"/> itself
         /// </returns>
-        public abstract Task<IEnumerable<Thing>> Read<T>(T thing, CancellationToken token, IQueryAttributes attributes = null) where T : Thing;
+        public abstract Task<IEnumerable<Thing>> Read<T>(T thing, CancellationToken cancellationToken, IQueryAttributes attributes = null) where T : Thing;
 
         /// <summary>
         /// Reads the data related to the provided <see cref="CDP4Common.DTO.Iteration"/> from the data-source

CDP4Dal/Operations/IThingTransaction.cs

@@ -123,9 +123,9 @@ public interface IThingTransaction
         /// <summary>
         /// Creates a <see cref="Thing"/> deletion operation
         /// </summary>
-        /// <param name="thing">The clone of the <see cref="Thing"/> to delete</param>
+        /// <param name="clone">The clone of the <see cref="Thing"/> to delete</param>
         /// <param name="containerClone">The clone of the container (mandatory in dialogs)</param>
-        void Delete(Thing thing, Thing containerClone = null);
+        void Delete(Thing clone, Thing containerClone = null);
 
         /// <summary>
         /// Registers the provided clone of a <see cref="Thing"/> as a copy with its destination

CDP4ServicesDal/CdpServicesDal.cs

@@ -238,11 +238,13 @@ public override async Task<IEnumerable<Thing>> Write(OperationContainer operatio
                             Logger.Info("JSON Deserializer completed in {0} [ms]", deserializationWatch.ElapsedMilliseconds);
                             break;
                         case ContentTypeKind.MESSAGEPACK:
-                            Logger.Info("Deserializing MESSAGEPACK response");
-                            var cts = new CancellationTokenSource();
-                            var things = await this.MessagePackSerializer.DeserializeAsync(resultStream, cts.Token);
-                            result.AddRange(things);
-                            Logger.Info("MESSAGEPACK Deserializer completed in {0} [ms]", deserializationWatch.ElapsedMilliseconds);
+                            using (var cts = new CancellationTokenSource())
+                            {
+                                Logger.Info("Deserializing MESSAGEPACK response");
+                                var things = await this.MessagePackSerializer.DeserializeAsync(resultStream, cts.Token);
+                                result.AddRange(things);
+                                Logger.Info("MESSAGEPACK Deserializer completed in {0} [ms]", deserializationWatch.ElapsedMilliseconds);
+                            }
                             break;
                     }