Skip to content
This repository was archived by the owner on Aug 25, 2025. It is now read-only.

Conversation

@gdalle
Copy link
Contributor

@gdalle gdalle commented Sep 26, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Following the recent release of DI v0.6, here are some changes that need to happen in OptimizationBase (supersedes #107):

  • Move the extras (now called prep) before the ADTypes backend object in every operator call
  • Refactor all pushforward, pullback and hvp calls to use tuples for their tangents
  • Do the same for all extensions (why are they still here?)
  • Use Constant context arguments for the Hessian

We also need to perform the following changes to accommodate Enzyme v0.13:

  • Annotate function in autodiff_deferred

@gdalle
Copy link
Contributor Author

gdalle commented Sep 28, 2024

@Vaibhavdixit02 do you think you can take it from here?

@Vaibhavdixit02
Copy link
Member

Yup I got it, thanks a lot for starting this!

@Vaibhavdixit02 Vaibhavdixit02 changed the base branch from main to DIv6 September 29, 2024 16:08
@Vaibhavdixit02 Vaibhavdixit02 marked this pull request as ready for review September 29, 2024 16:08
@Vaibhavdixit02 Vaibhavdixit02 merged commit 3a592dc into SciML:DIv6 Sep 29, 2024
2 of 5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants