Skip to content

Removing mismatched tableaus #2896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2025
Merged

Removing mismatched tableaus #2896

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 1 addition & 53 deletions lib/OrdinaryDiffEqVerner/test/ode_verner_tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,40 +27,8 @@ prob_iip = ODEProblem(ODEFunction(f!; analytic = (u0, p, t) -> [exp(-t)]), [1.0]
# -------------------------------------------------------------
# Helper for convergence test consistency
function check_convergence(dts, prob, alg, order_expected)
alg_name = string(typeof(alg).name.name)
# println("\n" * "="^70)
# println("Testing: $alg_name (Expected Order: $order_expected)")
# println("="^70)

# # Compute errors for each dt
# errors = []
# println("\nComputing errors for each dt:")
# for dt in dts
# sol = solve(prob, alg, dt=dt, adaptive=false)
# if prob.f.analytic !== nothing
# error_val = norm(sol.u[end] - prob.f.analytic(prob.u0, prob.p, prob.tspan[2]))
# else
# error_val = norm(sol.u[end] - sol.prob.f.analytic(prob.u0, prob.p, prob.tspan[2]))
# end
# push!(errors, error_val)
# println(" dt = $dt: error = $error_val")
# end

# # Print convergence orders between consecutive dt values
# println("\nConvergence orders between consecutive dt values:")
# for i in 2:length(errors)
# if errors[i] > 0 && errors[i-1] > 0
# order = log(errors[i-1]/errors[i]) / log(dts[i-1]/dts[i])
# println(" Order between dt=$(dts[i-1]) and dt=$(dts[i]): $order")
# end
# end

# # Use DiffEqDevTools for overall convergence estimate
# Use DiffEqDevTools for overall convergence estimate
sim = test_convergence(dts, prob, alg)
# println("\nOverall convergence order estimate: $(sim.𝒪est[:final])")
# println("="^70)

# @test sim.𝒪est[:final] > order_expected
@test (sim.𝒪est[:final] > order_expected) || (abs(sim.𝒪est[:final] - order_expected) < testTol)

end
Expand Down Expand Up @@ -160,23 +128,3 @@ println("RKV76IIa")
dts = [2, 1, 0.5, 0.25]

check_convergence(dts, prob_oop, RKV76IIa(), 7)
# check_convergence(dts, prob_iip, RKV76IIa(), 7)

tabalg = ExplicitRK(tableau = constructVernerEfficient7(BigFloat))
sol1 = solve(probnumbig, RKV76IIa(); dt = 1 / 2^6, adaptive = false, save_everystep = false)

sol2 = solve(probnumbig, tabalg; dt = 1 / 2^6, adaptive = false, save_everystep = false)
@test abs(sol1.u[end] - sol2.u[end]) < 1e-10

sol1 = solve(probnumbig, RKV76IIa(); dt = 1 / 2^3, adaptive = false, save_everystep = false)

sol2 = solve(probnumbig, tabalg; dt = 1 / 2^3, adaptive = false, save_everystep = false)
diff = sol1.u[end] - sol2.u[end]
@test minimum(abs.(diff) .< 1e-10)

sol2 = solve(probnumbig, tabalg; dt = 1 / 2^6)
sol1 = solve(probnumbig, RKV76IIa(); dt = 1 / 2^6)

@test length(sol1) == length(sol2)
@test SciMLBase.successful_retcode(sol1)
@test SciMLBase.successful_retcode(sol2)
Loading