-
Notifications
You must be signed in to change notification settings - Fork 603
Description
Describe the bug
When requesting r2r to list documents via GET /v3/documents there are a few issues present. According to the docs you can specify a limit in integer of <= 1000 and >0. In the same entry it's noted that it can only be between 1 and 100. This is only a minor thing.
Also, according to the docs, there should be a total number of files in the response. This is missing, too. The property is entirely missing from the response.
To Reproduce
Steps to reproduce the behavior:
- Send a simple GET request to the server like mentioned in the docs in order to list the uploaded documents.
- Notice that "limit" in docs can be set >= 1 and <=1000 but <=1000 makes no sense since docs mention only values ranging from 1 to 100 are valid.
- Read the response, you'll notice that a total file count should be present according to docs. But there is no such property and the total amount is missing.
Expected behavior
The docs should be updated to fix the right limits of "limit" property. Also there should be a property "total_entries" in the response.
Desktop (please complete the following information):
- OS: Running on MacOS, self hosting
- Browser No browser needed
- Version 3.6.5 with latest commits pulled Allow passing explicit filename via metadata title #2219
Additional context
This is both a typo in the documentation and also a bug where the number of uploaded documents should be sent back which is not the case. I have no way to count the total number of uploaded files because the api won't tell me, though iterating and going through the list in steps of 100 is possible. So it's not a major bug.