Skip to content

Nmatrix compatibility #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
v0dro merged 35 commits into from
Mar 8, 2016
Merged

Nmatrix compatibility #33

v0dro merged 35 commits into from
Mar 8, 2016

Conversation

@v0dro
Copy link
Member

@v0dro v0dro commented Mar 2, 2016

@minad this makes rb-gsl compatible with both nmatrix and narray. Request review.

Will add GSL 2.0 functionality soon.

v0dro added 30 commits January 9, 2016 16:13
@v0dro
Started modifying tests for GSL NMatrix compatibility.
f344e12
@v0dro
wrote tests for data type conversion between nmatrix and GSL types
c977262
@v0dro
added tests for LU decomposition with NMatrix.
9aac93b
@v0dro
More tests for validating QR and SV factorizations with NMatrix argum…
b7bafbc 
…ents. Added verbosity to examples.
@v0dro
Wrote tests for symmetric eigen value decomposition functions
3b5dc71
@v0dro
Wrote tests for interp and spline with nmatrix
bfe11d8
@v0dro
Added nmatrix tests for cheb module.
92235e9
@v0dro
Wrote tests for GSL statistics with nmatrix.
d670931
@v0dro
Amend wavelength example. Write tests for randist.
3c7ec72
@v0dro
Starting with addition of nmatrix functions.
074fa59
@v0dro
Modified extconf so it can find nmatrix
ed9ad3a
@v0dro
adding nmatrix - gsl conversion functions
6210982
@v0dro
gsl-nmatrix conversion code compiling
8cccc89
@v0dro
GSL-NMatrix interconversions working now.
2ba1b92
@v0dro
LU decomposition accepting NMatrix
232ca42
@v0dro
nmatrix working with LU solve
674f32c
@v0dro
nmatrix works with linalg LU invert
c8566f0
@v0dro
LU det working with nmatrix
0382714
@v0dro
QR decomp working with nmatrix
2476250
@v0dro
QR factorization methods passin
9c9a4f5
@v0dro
QR decomposition works with nmatrix
62b1483
@v0dro
NMatrix working with cholesky
8916b28
@v0dro
householder solvers working with nmatrix
4d96474
@v0dro
nmatrix working with stats module
a14388f
@v0dro
nmatrix works with eigen
bd00194
@v0dro
nmatrix works with cheb and functions
ee6d65b
@v0dro
nmatrix working with spline and interp
f49770f
@v0dro
works with bsplines
c55dd44
@v0dro
all green
4d3e235
@v0dro
Some more fixes and compatibility resolutions. Added rdoc document fo…
abc50a2 
…r nmatrix and updated existing README with nmatrix how-tos.
@v0dro
Copy link
Member Author

v0dro commented Mar 3, 2016

@blackwinter could you also have a look?

@v0dro v0dro force-pushed the nmatrix_compatibility branch from d59e47d to 243c3dc Compare March 3, 2016 16:24
@minad
Copy link
Contributor

minad commented Mar 3, 2016

Quite a lot of code. Did you add nmatrix support to all the places where an narray could be used?

@v0dro v0dro force-pushed the nmatrix_compatibility branch from 243c3dc to 9c98a65 Compare March 3, 2016 17:11
@v0dro
Copy link
Member Author

v0dro commented Mar 3, 2016

Yep. Also made some optimizations here n there. Also, creating NArray views from GSL objects was causing GC problems so views will not be supported by NMatrix.

@v0dro v0dro force-pushed the nmatrix_compatibility branch 3 times, most recently from 5af7eac to 19717b1 Compare March 3, 2016 19:43
@v0dro
travis
abd9700 
travis

travis

travis

travis
travis changes

travis changes

travis changes

travis

travis

travis again

minor removal

travis

t
@v0dro v0dro force-pushed the nmatrix_compatibility branch from 19717b1 to abd9700 Compare March 3, 2016 20:16
@v0dro
Copy link
Member Author

v0dro commented Mar 3, 2016

I'll be adding GSL 2.0 support next. Any suggestions?

@v0dro
Copy link
Member Author

v0dro commented Mar 4, 2016

@ktns I have merged your GSL 2.1 changes from #30 for compatibility with GSL 2.1. I'm happy to say that rb-gsl is now comfortably working with all GSL versions post 1.15.

I also want to merge changes from #31 into the branch, but I think not have GSL_2_0_LATER guards around the code might break compatibility with previous GSL versions. @boutil could you please make the necessary changes ASAP?

@minad @blackwinter do you think this is fit for merging?

@minad
Copy link
Contributor

minad commented Mar 4, 2016

@v0dro Great! Concerning the commits, you could maybe split it into two bigger commits, one for the gsl2 compat and one for nmatrix? But if the rebasing would be too much effort it is not necessary.

@v0dro
Copy link
Member Author

v0dro commented Mar 4, 2016

It would be too much effort!

@minad
Copy link
Contributor

minad commented Mar 4, 2016

Ok but for the future I recommend that you work on separate branches if you do separate things. makes it easier in the long run when one inspects the git history. But not a big deal for now :)

@v0dro
Copy link
Member Author

v0dro commented Mar 4, 2016

Alright will do. Should I merge these changes?

Also, will it be possible for you to test this yourself by cloning my branch just to make sure that everything is working fine?

v0dro added a commit that referenced this pull request Mar 8, 2016
@v0dro
Merge pull request #33 from v0dro/nmatrix_compatibility
1f8e994 
Nmatrix compatibility
@v0dro v0dro merged commit 1f8e994 into SciRuby:master Mar 8, 2016
@v0dro
Copy link
Member Author

v0dro commented Mar 8, 2016

@minad could you release a new version on rubygems?

@v0dro
Copy link
Member Author

v0dro commented Mar 10, 2016

@minad could you release a new version?

@minad
Copy link
Contributor

minad commented Mar 11, 2016

@v0dro I added you as a owner of the gsl gem :)

This was referenced Mar 11, 2016
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@v0dro @minad