-
Notifications
You must be signed in to change notification settings - Fork 29
Open
Description
After #90, the SnowInstance is now created at import time.
WorkArena/src/browsergym/workarena/tasks/dashboard.py
Lines 33 to 38 in 4fa3ecc
| config = SNowInstance().report_filter_config | |
| if config is None: | |
| REPORT_DATE_FILTER = REPORT_TIME_FILTER = None | |
| else: | |
| REPORT_DATE_FILTER = config["report_date_filter"] | |
| REPORT_TIME_FILTER = config["report_time_filter"] |
I don't think this is good as:
- The instance must be running at import time. Some libraries, like BrowserGym, might have multiple benchmarks, so this will likely affect every run of the library, even if WorkArena is not launched.
- All the task accept an instance at init (good!), allowing other libraries to self create the instance (so env variables might not be present, or some other process must be done first)
As this is only to get some constants that are used inside the Dashboard task, I suggest to move this code inside init function.
Metadata
Metadata
Assignees
Labels
No labels