fix bugs and improve example

Author: AbdulRahmanAlHamali

examples/adaptive_with_net_http.rb

@@ -14,42 +14,44 @@
 
 # Configure a mock HTTP server endpoint
 # In real usage, this would be your actual service endpoint
-TEST_HOST = "httpbin.org"
-TEST_PORT = 443
+TEST_HOST = "localhost"
+TEST_PORT = 80
 
 # Configure Semian for the HTTP endpoint with adaptive circuit breaker
 puts "\nConfiguring Semian with adaptive circuit breaker..."
 
 # The Net::HTTP adapter will automatically use this configuration
 # when making requests to the specified host
-Semian.register(
-  "httpbin_service",
-  adaptive_circuit_breaker: true, # Enable adaptive circuit breaker
-  bulkhead: true,
-  tickets: 5,
-  timeout: 1,
-)
+SEMIAN_PARAMETERS = {
+  adaptive_circuit_breaker: true,
+  open_circuit_server_errors: true,
+}.freeze
+
+Semian::NetHTTP.semian_configuration = proc do |host, port|
+  if host == "localhost" && port == 80
+    SEMIAN_PARAMETERS.merge(name: "localhost_80")
+  end
+end
 
 # Helper method to make HTTP requests
 def make_request(path = "/status/200")
-  uri = URI("https://#{TEST_HOST}#{path}")
+  uri = URI("http://#{TEST_HOST}#{path}")
   http = Net::HTTP.new(uri.host, uri.port)
-  http.use_ssl = true
   http.read_timeout = 2
   http.open_timeout = 2
 
-  # Configure semian for this connection
-  # This would typically be done in your HTTP client configuration
-  http.singleton_class.class_eval do
-    def semian_identifier
-      "httpbin_service"
-    end
-
-    def semian_options
-      # Return the resource name to use the registered configuration
-      { name: "httpbin_service" }
-    end
-  end
+  # # Configure semian for this connection
+  # # This would typically be done in your HTTP client configuration
+  # http.singleton_class.class_eval do
+  #   def semian_identifier
+  #     "httpbin_service"
+  #   end
+
+  #   def semian_options
+  #     # Return the resource name to use the registered configuration
+  #     { name: "httpbin_service" }
+  #   end
+  # end
 
   request = Net::HTTP::Get.new(uri)
   response = http.request(request)
@@ -68,6 +70,7 @@ def semian_options
     puts "Request #{i + 1}: Success (HTTP #{code})"
   rescue => e
     puts "Request #{i + 1}: Error - #{e.class}: #{e.message}"
+    puts e.backtrace
   end
   sleep(0.5)
 end

lib/semian/adapter.rb

@@ -45,7 +45,7 @@ def acquire_semian_resource(scope:, adapter:, &block)
       end
     rescue ::Semian::OpenCircuitError => error
       last_error = semian_resource.circuit_breaker.last_error
-      message = "#{error.message} caused by #{last_error.message}"
+      message = "#{error.message} caused by #{last_error&.message}"
       last_error = nil unless last_error.is_a?(Exception) # Net::HTTPServerError is not an exception
       raise self.class::CircuitOpenError.new(semian_identifier, message), cause: last_error
     rescue ::Semian::BaseError => error

lib/semian/adaptive_circuit_breaker.rb

@@ -5,7 +5,7 @@
 module Semian
   # Adaptive Circuit Breaker that uses PID controller for dynamic rejection
   class AdaptiveCircuitBreaker
-    attr_reader :name, :pid_controller, :ping_thread, :update_thread
+    attr_reader :name, :pid_controller, :ping_thread, :update_thread, :last_error
 
     def initialize(name:, kp: 1.0, ki: 0.1, kd: 0.01,
       window_size: 10, history_duration: 3600,
@@ -17,6 +17,7 @@ def initialize(name:, kp: 1.0, ki: 0.1, kd: 0.01,
       @enable_background_ping = enable_background_ping
       @resource = nil
       @stopped = false
+      @last_error = nil
 
       # Create PID controller (thread-safe by default)
       @pid_controller = if thread_safe
@@ -62,6 +63,7 @@ def acquire(resource = nil, &block)
         result
       rescue => error
         @pid_controller.record_request(:error)
+        @last_error = error # Store the error for reporting
         raise error
       end
     end
@@ -70,6 +72,7 @@ def acquire(resource = nil, &block)
     def reset
       @pid_controller.reset
       @resource = nil
+      @last_error = nil
     end
 
     # Stop the background threads (called by destroy)
@@ -107,6 +110,27 @@ def half_open?
       !open? && !closed?
     end
 
+    # Mark a request as failed (for compatibility with ProtectedResource)
+    def mark_failed(error)
+      @last_error = error
+      @pid_controller.record_request(:error)
+    end
+
+    # Mark a request as successful (for compatibility with ProtectedResource)
+    def mark_success
+      @pid_controller.record_request(:success)
+    end
+
+    # Check if requests are allowed (for compatibility with ProtectedResource)
+    def request_allowed?
+      !@pid_controller.should_reject?
+    end
+
+    # Check if the circuit breaker is in use (for compatibility with ProtectedResource)
+    def in_use?
+      true
+    end
+
     private
 
     def start_ping_thread

lib/semian/net_http.rb

@@ -127,28 +127,25 @@ def with_resource_timeout(timeout)
     def unprotected_ping
       # Perform a simple HEAD request to check connectivity
       # First ensure we're connected
-      return false unless started?
 
-      begin
-        # Create a simple HEAD request
-        req = Net::HTTP::Head.new("/")
-
-        # Temporarily save semian state and disable it
-        saved_semian_enabled = @semian_enabled
-        @semian_enabled = false
-
-        # Make the request directly without going through Semian
-        # We just need to verify we can reach the server
-        request(req)
-
-        # Any response (even error responses) means the server is reachable
-        true
-      rescue => e
-        Semian.logger&.debug("[net_http] Unprotected ping failed: #{e.message}")
-        false
-      ensure
-        @semian_enabled = saved_semian_enabled
-      end
+      # Create a simple HEAD request
+      req = Net::HTTP::Head.new("/")
+
+      # Temporarily save semian state and disable it
+      saved_semian_enabled = @semian_enabled
+      @semian_enabled = false
+
+      # Make the request directly without going through Semian
+      # We just need to verify we can reach the server
+      request(req)
+
+      # Any response (even error responses) means the server is reachable
+      true
+    rescue => e
+      Semian.logger&.debug("[net_http] Unprotected ping failed: #{e.message}")
+      false
+    ensure
+      @semian_enabled = saved_semian_enabled
     end
 
     private