Skip to content

Commit 17a5b10

Browse files
error fixes: not navigating to facial gesture settings
1 parent 2dbe128 commit 17a5b10

File tree

4 files changed

+17
-3
lines changed

4 files changed

+17
-3
lines changed

app/src/main/java/com/sidharth/lg_motion/MainActivity.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ class MainActivity : AppCompatActivity(), ProgressIndicatorCallback {
112112
true
113113
}
114114

115-
R.id.aboutFragment, R.id.openSourceLicenseFragment, R.id.privacyPolicyFragment -> {
115+
R.id.aboutFragment, R.id.openSourceLicenseFragment, R.id.privacyPolicyFragment, R.id.facialGesturesSettingsFragment -> {
116116
activityMainBinding.bottomNavigationView?.menu?.findItem(R.id.settingsFragment)?.isChecked =
117117
true
118118
activityMainBinding.navigationRailView?.menu?.findItem(R.id.settingsFragment)?.isChecked =

app/src/main/java/com/sidharth/lg_motion/ui/settings/fragment/RootSettingsFragment.kt

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ class RootSettingsFragment : PreferenceFragmentCompat() {
4343
private val openSourceLicensePreference by lazy { findPreference<Preference>("opensource_license")!! }
4444
private val privacyPolicyPreference by lazy { findPreference<Preference>("privacy_policy")!! }
4545
private val appVersionPreference by lazy { findPreference<Preference>("app_version")!! }
46+
private val facialGestureSettings by lazy { findPreference<Preference>("face")!! }
4647

4748
private val viewModel: ProgressViewModel by activityViewModels {
4849
ProgressViewModelFactory()
@@ -206,7 +207,8 @@ class RootSettingsFragment : PreferenceFragmentCompat() {
206207
}
207208

208209
privacyPolicyPreference.setOnPreferenceClickListener {
209-
val action = RootSettingsFragmentDirections.actionSettingsFragmentToPrivacyPolicyFragment()
210+
val action =
211+
RootSettingsFragmentDirections.actionSettingsFragmentToPrivacyPolicyFragment()
210212
view?.findNavController()?.navigate(action)
211213
true
212214
}
@@ -222,6 +224,12 @@ class RootSettingsFragment : PreferenceFragmentCompat() {
222224
)
223225
true
224226
}
227+
228+
facialGestureSettings.setOnPreferenceClickListener {
229+
val action = RootSettingsFragmentDirections.actionSettingsFragmentToFacialGesturesSettingsFragment()
230+
view?.findNavController()?.navigate(action)
231+
true
232+
}
225233
}
226234

227235
private fun createShowConfirmationDialog(action: () -> Unit) {

app/src/main/res/navigation/nav_graph.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,9 @@
3737
<action
3838
android:id="@+id/action_settingsFragment_to_openSourceLicenseFragment"
3939
app:destination="@id/openSourceLicenseFragment" />
40+
<action
41+
android:id="@+id/action_settingsFragment_to_facialGesturesSettingsFragment"
42+
app:destination="@id/facialGesturesSettingsFragment" />
4043
</fragment>
4144

4245
<fragment
@@ -74,5 +77,9 @@
7477
android:name="com.sidharth.lg_motion.ui.home.fragment.AudioFragment"
7578
android:label="fragment_audio"
7679
tools:layout="@layout/fragment_audio" />
80+
<fragment
81+
android:id="@+id/facialGesturesSettingsFragment"
82+
android:name="com.sidharth.lg_motion.ui.settings.fragment.FacialGesturesSettingsFragment"
83+
android:label="FacialGesturesSettingsFragment" />
7784

7885
</navigation>

app/src/main/res/xml/root_preferences.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,6 @@
122122

123123
<Preference
124124
android:key="face"
125-
app:fragment="com.sidharth.lg_motion.ui.settings.fragment.FacialGesturesSettingsFragment"
126125
android:summary="@string/facial_gestures_summary"
127126
android:title="@string/facial_gestures_title"
128127
app:iconSpaceReserved="false" />

0 commit comments

Comments
 (0)