Skip to content

Commit 7aff1d8

Browse files
authored
include TargetFramework in log (#721)
1 parent a9204e7 commit 7aff1d8

15 files changed

+41
-21
lines changed

src/ConfigReader.Tests/ConfigReader.Tests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>net8.0</TargetFramework>
4+
<TargetFramework>net9.0</TargetFramework>
55
<OutputType>Exe</OutputType>
66
<NoWarn>$(NoWarn);xUnit1051</NoWarn>
77
<RootNamespace>testing</RootNamespace>

src/ConfigReader/ConfigReader.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFrameworks>netstandard2.0;net48;net8.0</TargetFrameworks>
4+
<TargetFrameworks>netstandard2.0;netstandard2.1;net48;net8.0;net9.0</TargetFrameworks>
55
<GeneratePackageOnBuild>false</GeneratePackageOnBuild>
66
<GenerateDocumentationFile>false</GenerateDocumentationFile>
77
</PropertyGroup>

src/ConfigReader/LogBuilder.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,12 @@ public static string BuildConfigLogMessage(string targetDirectory, ConfigResult
9292
""");
9393
}
9494

95+
#if NET48
96+
builder.AppendLine(" TargetFramework: net48");
97+
#endif
98+
#if NET9_0
99+
builder.AppendLine(" TargetFramework: net9.0");
100+
#endif
95101
return builder.ToString().Trim();
96102
}
97103

src/Directory.Build.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<Project>
33
<PropertyGroup>
44
<NoWarn>CS1591;NU1608;NU1109</NoWarn>
5-
<Version>28.0.0-beta.3</Version>
5+
<Version>28.0.0-beta.4</Version>
66
<LangVersion>preview</LangVersion>
77
<AssemblyVersion>1.0.0</AssemblyVersion>
88
<PackageTags>Markdown, Snippets, mdsnippets, documentation, MarkdownSnippets</PackageTags>

src/MarkdownSnippets.MsBuild/MarkdownSnippets.MsBuild.csproj

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,28 @@
11

22
<Project Sdk="Microsoft.NET.Sdk">
33
<PropertyGroup>
4-
<TargetFramework>netstandard2.0</TargetFramework>
4+
<TargetFrameworks>net48;net9.0</TargetFrameworks>
55
<Description>Extract code snippets from any language to be used when building documentation.</Description>
66
<DevelopmentDependency>true</DevelopmentDependency>
77
<IncludeBuildOutput>false</IncludeBuildOutput>
88
</PropertyGroup>
9+
<Target Name="ShowSdkInfo" BeforeTargets="Build">
10+
<Message Text="SDK Version: $(NETCoreSdkVersion)" Importance="high" />
11+
<Message Text="SDK Major: $(SdkMajorVersion)" Importance="high" />
12+
<Message Text="Target Framework: $(TargetFramework)" Importance="high" />
13+
<Message Text="SDK Root: $(NetCoreSdkBundledVersionsPropsPath)" Importance="high" />
14+
</Target>
915
<ItemGroup>
1016
<Compile Include="..\ConfigReader\*.cs" />
1117

12-
<Content Include=".\bin\$(Configuration)\$(TargetFramework)\MarkdownSnippets.MsBuild.dll">
18+
<TfmSpecificPackageFile Include=".\bin\$(Configuration)\$(TargetFramework)\MarkdownSnippets.MsBuild.dll">
1319
<Pack>true</Pack>
14-
<PackagePath>task</PackagePath>
15-
</Content>
16-
<Content Include="$(SolutionDir)MarkdownSnippets\bin\$(Configuration)\$(TargetFramework)\MarkdownSnippets.dll">
20+
<PackagePath>task\$(TargetFramework)</PackagePath>
21+
</TfmSpecificPackageFile>
22+
<TfmSpecificPackageFile Include="$(SolutionDir)MarkdownSnippets\bin\$(Configuration)\$(TargetFramework)\MarkdownSnippets.dll">
1723
<Pack>true</Pack>
18-
<PackagePath>task</PackagePath>
19-
</Content>
24+
<PackagePath>task\$(TargetFramework)</PackagePath>
25+
</TfmSpecificPackageFile>
2026
<Content Include="MarkdownSnippets.MsBuild.targets">
2127
<Pack>true</Pack>
2228
<PackagePath>build</PackagePath>

src/MarkdownSnippets.MsBuild/MarkdownSnippets.MsBuild.targets

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
22
<PropertyGroup>
3-
<MarkdownSnippetsAssembly>$(MSBuildThisFileDirectory)..\task\MarkdownSnippets.MsBuild.dll</MarkdownSnippetsAssembly>
3+
<MarkdownSnippetsAssembly Condition="$(MSBuildRuntimeType) == 'Core'">$(MSBuildThisFileDirectory)..\task\net9.0</MarkdownSnippetsAssembly>
4+
<MarkdownSnippetsAssembly Condition="$(MSBuildRuntimeType) != 'Core'">$(MSBuildThisFileDirectory)..\task\net48</MarkdownSnippetsAssembly>
45
</PropertyGroup>
56

67
<ItemGroup>

src/MarkdownSnippets.Tool.Tests/LogBuilderTests.BuildConfigLogMessage.verified.txt renamed to src/MarkdownSnippets.Tool.Tests/LogBuilderTests.BuildConfigLogMessage.DotNet9_0.verified.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,5 @@
2020
Dir6
2121
UrlsAsSnippets:
2222
Url1
23-
Url2
23+
Url2
24+
TargetFramework: net9.0

src/MarkdownSnippets.Tool.Tests/LogBuilderTests.BuildConfigLogMessageMinimal.verified.txt renamed to src/MarkdownSnippets.Tool.Tests/LogBuilderTests.BuildConfigLogMessageMinimal.DotNet9_0.verified.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,5 @@
1010
FileConfigPath: theConfigFilePath (exists:False)
1111
ReadOnly:
1212
WriteHeader:
13-
Header:
13+
Header:
14+
TargetFramework: net9.0

src/MarkdownSnippets.Tool.Tests/LogBuilderTests.BuildConfigLogMessageSourceTransform.verified.txt renamed to src/MarkdownSnippets.Tool.Tests/LogBuilderTests.BuildConfigLogMessageSourceTransform.DotNet9_0.verified.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,5 @@
2525
Dir6
2626
UrlsAsSnippets:
2727
Url1
28-
Url2
28+
Url2
29+
TargetFramework: net9.0

src/MarkdownSnippets.Tool.Tests/LogBuilderTests.cs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ public Task BuildConfigLogMessage()
2121
Convention = DocumentConvention.InPlaceOverwrite,
2222
};
2323
var message = LogBuilder.BuildConfigLogMessage("theRoot", config, "theConfigFilePath");
24-
return Verify(message);
24+
return Verify(message)
25+
.UniqueForTargetFrameworkAndVersion();
2526
}
2627

2728
[Fact]
@@ -45,14 +46,16 @@ public Task BuildConfigLogMessageSourceTransform()
4546
Convention = DocumentConvention.SourceTransform,
4647
};
4748
var message = LogBuilder.BuildConfigLogMessage("theRoot", config, "theConfigFilePath");
48-
return Verify(message);
49+
return Verify(message)
50+
.UniqueForTargetFrameworkAndVersion();
4951
}
5052

5153
[Fact]
5254
public Task BuildConfigLogMessageMinimal()
5355
{
5456
var config = new ConfigResult();
5557
var message = LogBuilder.BuildConfigLogMessage("theRoot", config, "theConfigFilePath");
56-
return Verify(message);
58+
return Verify(message)
59+
.UniqueForTargetFrameworkAndVersion();
5760
}
5861
}

0 commit comments

Comments
 (0)