Skip to content

Conversation

@marklagendijk
Copy link
Contributor

@marklagendijk marklagendijk commented Mar 14, 2024

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Implementation of #360

…geCache and AzureBlobStorageImageProvider.cs
@marklagendijk marklagendijk changed the title Feature: Added BlobContainerClientProvider option to AzureBlobStorageCache and AzureBlobStorageImageProvider Feature: Added BlobContainerClientProvider option to AzureBlobStorageCache and AzureBlobStorageImageProvider Mar 14, 2024
@codecov
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85%. Comparing base (3bb469c) to head (369ee18).
⚠️ Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
...b.Providers.Azure/Caching/AzureBlobStorageCache.cs 75% 0 Missing and 1 partial ⚠️
...s.Azure/Providers/AzureBlobStorageImageProvider.cs 83% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@         Coverage Diff         @@
##           main   #361   +/-   ##
===================================
- Coverage    85%    85%   -1%     
===================================
  Files        82     82           
  Lines      2349   2357    +8     
  Branches    352    355    +3     
===================================
+ Hits       2016   2021    +5     
- Misses      230    231    +1     
- Partials    103    105    +2     
Flag Coverage Δ
unittests 85% <83%> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this and sorry about the delay. I had to wait until I could make a breaking change.

@JimBobSquarePants JimBobSquarePants merged commit 83c1249 into SixLabors:main Aug 1, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants