Skip to content

Update ImageSharp, dispose asynchronously #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JimBobSquarePants merged 1 commit into from
Apr 27, 2025
Merged

Update ImageSharp, dispose asynchronously #384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ImageSharp.Web/ImageCacheMetadata.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ public async Task WriteAsync(Stream stream)
{
Dictionary<string, string> dictionary = this.ToDictionary();

using StreamWriter writer = new(stream, Encoding.UTF8);
await using StreamWriter writer = new(stream, Encoding.UTF8);
foreach (KeyValuePair<string, string> keyValuePair in dictionary)
{
// TODO: string.Create
Expand Down
4 changes: 2 additions & 2 deletions src/ImageSharp.Web/ImageSharp.Web.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<AssemblyTitle>SixLabors.ImageSharp.Web</AssemblyTitle>
Expand Down Expand Up @@ -46,7 +46,7 @@
<ItemGroup>
<FrameworkReference Include="Microsoft.AspNetCore.App" />
<PackageReference Include="Microsoft.IO.RecyclableMemoryStream" Version="3.0.1" />
<PackageReference Include="SixLabors.ImageSharp" Version="3.1.7" />
<PackageReference Include="SixLabors.ImageSharp" Version="3.1.8" />
</ItemGroup>

<Import Project="..\..\shared-infrastructure\src\SharedInfrastructure\SharedInfrastructure.projitems" Label="Shared" />
Expand Down
4 changes: 2 additions & 2 deletions src/ImageSharp.Web/Middleware/ImageSharpMiddleware.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ private async Task ProcessRequestAsync(
maxAge = sourceImageMetadata.CacheControlMaxAge;
}

using (Stream inStream = await sourceImageResolver.OpenReadAsync())
await using (Stream inStream = await sourceImageResolver.OpenReadAsync())
{
// TODO: Do we need some way to set options based upon processors?
DecoderOptions decoderOptions = await this.options.OnBeforeLoadAsync.Invoke(imageCommandContext, this.options.Configuration)
Expand Down Expand Up @@ -524,7 +524,7 @@ private async Task SendResponseAsync(
{
Guard.NotNull(cacheResolver);

using Stream cacheStream = await cacheResolver.OpenReadAsync();
await using Stream cacheStream = await cacheResolver.OpenReadAsync();
await imageContext.SendAsync(cacheStream, metadata);
}
catch (Exception ex)
Expand Down
Loading