Skip to content

Commit dfc5bd9

Browse files
authored
Update CMakeLists and README (#142)
Signed-off-by: Matthieu MOREL <[email protected]>
1 parent 9d1bcfa commit dfc5bd9

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ project(cpp2sky
1010
HOMEPAGE_URL "https://github.com/SkyAPM/cpp2sky"
1111
)
1212

13-
option(OVERRIDE_CXX_STANDARD_FLAGS "Force building with -std=c++11 even if the CXXFLAGS are configured differently" ON)
13+
option(OVERRIDE_CXX_STANDARD_FLAGS "Force building with -std=c++17 even if the CXXFLAGS are configured differently" ON)
1414
option(SPDLOG_FETCHCONTENT "Using spdlog FetchContent to build" ON)
1515
option(FMTLIB_FETCHCONTENT "Using fmt FetchContent to build" ON)
1616
option(HTTPLIB_FETCHCONTENT "Using httplib FetchContent to build" ON)

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
![cpp2sky test](https://github.com/SkyAPM/cpp2sky/workflows/cpp2sky%20test/badge.svg)
44

5-
Distributed tracing and monitor SDK in CPP for Apache SkyWalking APM. This SDK is compatible with C++ 17, C++ 14, and C++ 11.
5+
Distributed tracing and monitor SDK in CPP for Apache SkyWalking APM. This SDK requires C++17 or later.
66

77
## Build
88

@@ -36,8 +36,8 @@ cc_binary(
3636
You can compile this project, according to the following steps:
3737
```
3838
step 01: git clone [email protected]:SkyAPM/cpp2sky.git
39-
step 02: git clone -b v9.1.0 https://github.com/apache/skywalking-data-collect-protocol.git ./3rdparty/skywalking-data-collect-protocol
40-
step 03: git clone -b v1.46.6 https://github.com/grpc/grpc.git --recursive
39+
step 02: git clone -b v10.3.0 https://github.com/apache/skywalking-data-collect-protocol.git ./3rdparty/skywalking-data-collect-protocol
40+
step 03: git clone -b v1.74.1 https://github.com/grpc/grpc.git --recursive
4141
step 04: cmake -S ./grpc -B ./grpc/build && cmake --build ./grpc/build --parallel 8 --target install
4242
step 05: cmake -S . -B ./build && cmake --build ./build
4343
```
@@ -54,8 +54,8 @@ pkg_check_modules(CPP2SKY_PKG REQUIRED cpp2sky)
5454
```
5555

5656
Note:
57-
- If you want to build this project over c11, you must update grpc version(current version:v1.46.6).
58-
- Only test cmake using Centos and Ubuntu.
57+
- This project requires C++17 or later (enforced by gRPC v1.74.1 dependency).
58+
- CMake builds are tested on Ubuntu and CentOS.
5959

6060
#### Develop
6161

0 commit comments

Comments
 (0)