Merge pull request #813 from SlideRuleEarth/carlos-dev4

There is an offset sometimes when viewing polys from the request page…

Author: cugarteblair

web-client/src/components/SrMap.vue

@@ -490,13 +490,16 @@ drawPolygon.on('drawend', function (event) {
         //console.log("Original polyCoords:", rings);
 
         const projName = useMapStore().getSrViewObj().projectionName
+        const mapViewProjection = mapRef.value?.map.getView().getProjection().getCode()
         let thisProj = getProjection(projName)
+
         let flatLonLatPairs
         if (thisProj?.getUnits() !== 'degrees') {
-          //Convert each ring's coordinates to lon/lat using toLonLat
+          //Convert each ring's coordinates to lon/lat using toLonLat with EXPLICIT projection
           const convertedRings: Coordinate[][] = rings.map((ring: Coordinate[]) =>
-            ring.map((coord) => toLonLat(coord) as Coordinate)
+            ring.map((coord) => toLonLat(coord, mapViewProjection) as Coordinate)
           )
+
           //console.log("Converted polyCoords:", convertedRings);
           mapStore.polyCoords = convertedRings
           flatLonLatPairs = convertedRings.flatMap((ring) => ring)
@@ -508,6 +511,7 @@ drawPolygon.on('drawend', function (event) {
           lon: coord[0],
           lat: coord[1]
         }))
+
         if (isClockwise(srLonLatCoordinates)) {
           //console.log('poly is clockwise, reversing');
           reqParamsStore.setPoly(srLonLatCoordinates.reverse())
@@ -826,6 +830,11 @@ onMounted(async () => {
   })
   //console.log("SrMap onMounted registering proj4:",proj4);
   register(proj4 as any)
+
+  // Clear the global drawVectorSource when component mounts to prevent stale features
+  // from previous navigation sessions from appearing with incorrect coordinates
+  drawVectorSource.clear()
+
   if (mapRef.value?.map) {
     //console.log("SrMap onMounted map:",mapRef.value.map);
     mapStore.setMap(mapRef.value.map)
@@ -942,8 +951,15 @@ onMounted(async () => {
     //dumpMapLayers(map, 'SrMap onMounted');
     // Note: addRecordLayer() is now handled by watch on isTreeLoaded + allReqIds with immediate:true
     if (haveReqPoly || haveReqPin) {
-      //draw and zoom to the current reqParamsStore.poly
+      // CRITICAL FIX: Delay drawing until after OpenLayers has rendered the updated view
+      // OpenLayers rendering is asynchronous - it schedules renders on animation frames.
+      // If we draw immediately after updateReqMapView, features may be rendered with
+      // stale view transforms, causing visual offset even though coordinates are correct.
+      // requestAnimationFrame(() => {
+      //   //draw and zoom to the current reqParamsStore.poly
+      //   logger.debug('Drawing polygon after requestAnimationFrame')
       drawCurrentReqPolyAndPin()
+      //})
     }
   } else {
     logger.error('mapRef.value?.map is null in onMounted')

web-client/src/composables/SrProjections.ts

@@ -26,7 +26,10 @@ export const srProjections = ref<{ [key: string]: SrProjection }>({
     default_zoom: 2,
     min_zoom: 0,
     max_zoom: 19,
-    bbox: [-180.0, -85.06, 180.0, 85.06]
+    bbox: [-180.0, -85.06, 180.0, 85.06],
+    // CRITICAL: Define extent explicitly to prevent applyTransform from using tainted projection state
+    // Web Mercator extent must be symmetric for correct coordinate transformations
+    extent: [-20037508.342789244, -20037508.342789244, 20037508.342789244, 20037508.342789244]
   },
   'EPSG:4326': {
     // Web Mercator -- This is the 'standard' projection for web maps (coordinate units in lon lat)