Merge pull request #749 from SlideRuleEarth/carlos-dev4

Carlos dev4 Major update for log refactor, auto ESLinter

Author: cugarteblair

Makefile

@@ -172,7 +172,8 @@ lint-fix: ## Run ESLint with auto-fix
 lint-staged: ## Run lint-staged on staged files (used by pre-commit hook)
 	cd web-client && npx lint-staged
 
-pre-commit-check: lint-staged ## Manually run pre-commit checks without committing
+pre-commit-check: ## Manually run pre-commit checks without committing
+	cd web-client && npx lint-staged && npm run typecheck && npm run test:unit
 	@echo "✅ Pre-commit checks passed!"
 
 test-unit: ## Run Vitest unit tests (CI-friendly)

web-client/.eslintrc.cjs

@@ -24,13 +24,25 @@ module.exports = {
     // Warn about async functions that don't use await
     'require-await': 'warn',
     // Require functions that return promises to be marked async
-    '@typescript-eslint/promise-function-async': 'warn'
+    '@typescript-eslint/promise-function-async': 'warn',
+    // Allow unused vars that start with _
+    'no-unused-vars': ['error', {
+      argsIgnorePattern: '^_',
+      varsIgnorePattern: '^_'
+    }],
+    '@typescript-eslint/no-unused-vars': ['error', {
+      argsIgnorePattern: '^_',
+      varsIgnorePattern: '^_'
+    }]
   },
   overrides: [
     {
       files: ['tests/**/*.{ts,tsx,js,jsx}'],
       env: {
         node: true
+      },
+      globals: {
+        globalThis: 'readonly'
       }
     }
   ]

web-client/.husky/pre-commit

@@ -1 +1,2 @@
-npm test
+#!/bin/sh
+npx lint-staged && npm run typecheck && npm run test:unit

web-client/fix-unused-vars.js

@@ -0,0 +1,72 @@
+#!/usr/bin/env node
+const { exec } = require('child_process');
+const fs = require('fs');
+const path = require('path');
+
+// Get ESLint errors
+exec('ESLINT_USE_FLAT_CONFIG=false npx eslint src/ --ext .vue,.js,.jsx,.ts,.tsx --format=json', (error, stdout) => {
+  const results = JSON.parse(stdout);
+  const fixes = new Map();
+
+  results.forEach(result => {
+    const filePath = result.filePath;
+    const messages = result.messages.filter(m =>
+      m.ruleId === 'no-unused-vars' || m.ruleId === '@typescript-eslint/no-unused-vars'
+    );
+
+    messages.forEach(msg => {
+      const match = msg.message.match(/'([^']+)' is (defined|assigned)/);
+      if (match) {
+        const varName = match[1];
+        // Skip if already starts with underscore
+        if (!varName.startsWith('_')) {
+          if (!fixes.has(filePath)) {
+            fixes.set(filePath, []);
+          }
+          fixes.set(filePath, [...fixes.get(filePath), { line: msg.line, varName }]);
+        }
+      }
+    });
+  });
+
+  console.log(`Found ${fixes.size} files with unused variables to fix`);
+
+  // Apply fixes
+  let totalFixed = 0;
+  fixes.forEach((varList, filePath) => {
+    let content = fs.readFileSync(filePath, 'utf8');
+    const lines = content.split('\n');
+
+    // Group by unique var names
+    const uniqueVars = [...new Set(varList.map(v => v.varName))];
+
+    uniqueVars.forEach(varName => {
+      // Use regex to replace variable declarations/parameters
+      // Match various patterns: const varName, let varName, varName:, (varName), {varName}
+      const patterns = [
+        // Function parameters
+        new RegExp(`\\(([^)]*)\\b${varName}\\b([^)]*)\\)`, 'g'),
+        // Destructuring
+        new RegExp(`\\{([^}]*)\\b${varName}\\b([^}]*)\\}`, 'g'),
+        // Array destructuring
+        new RegExp(`\\[([^\\]]*)\\b${varName}\\b([^\\]]*)\\]`, 'g'),
+        // Variable declarations
+        new RegExp(`\\b(const|let|var)\\s+${varName}\\b`, 'g'),
+        // Type annotations
+        new RegExp(`\\b${varName}\\s*:`, 'g'),
+      ];
+
+      patterns.forEach(pattern => {
+        content = content.replace(pattern, (match) => {
+          return match.replace(new RegExp(`\\b${varName}\\b`), `_${varName}`);
+        });
+      });
+    });
+
+    fs.writeFileSync(filePath, content);
+    totalFixed += uniqueVars.length;
+    console.log(`Fixed ${uniqueVars.length} variables in ${path.basename(filePath)}`);
+  });
+
+  console.log(`\nTotal: Fixed ${totalFixed} unused variables in ${fixes.size} files`);
+});

web-client/package-lock.json

@@ -14,8 +14,8 @@
     "dev": "vite",
     "build-only": "vite build",
     "typecheck": "vue-tsc --noEmit -p tsconfig.app.json",
-    "lint": "ESLINT_USE_FLAT_CONFIG=false eslint . --ext .vue,.js,.jsx,.cjs,.mjs,.ts,.tsx,.cts,.mts",
-    "lint:fix": "ESLINT_USE_FLAT_CONFIG=false eslint . --ext .vue,.js,.jsx,.cjs,.mjs,.ts,.tsx,.cts,.mts --fix",
+    "lint": "ESLINT_USE_FLAT_CONFIG=false eslint src tests --ext .vue,.js,.jsx,.cjs,.mjs,.ts,.tsx,.cts,.mts",
+    "lint:fix": "ESLINT_USE_FLAT_CONFIG=false eslint src tests --ext .vue,.js,.jsx,.cjs,.mjs,.ts,.tsx,.cts,.mts --fix",
     "preview": "vite preview",
     "build": "run-p \"build-only {@}\" --",
     "build_with_maps": "VITE_BUILD_SOURCEMAP=true run-p \"build-only {@}\" --",
@@ -45,9 +45,10 @@
     "echarts-gl": "^2.0.9",
     "events": "^3.3.0",
     "highlight.js": "^11.11.1",
-    "intro.js": "^8.3.1",
+    "intro.js": "^8.3.2",
     "jszip": "^3.10.1",
     "lodash-es": "^4.17.21",
+    "loglevel": "^1.9.2",
     "mitt": "^3.0.1",
     "ol": "^10.6.0",
     "ol-contextmenu": "^5.5.0",
@@ -57,7 +58,7 @@
     "pinia-plugin-persistedstate": "^4.0.1",
     "primeflex": "^3.3.1",
     "primeicons": "^7.0.0",
-    "primevue": "^4.3.2",
+    "primevue": "^4.4.1",
     "sharp": "^0.34.3",
     "shpjs": "^6.1.0",
     "vue": "^3.5.6",