Skip to content

chore(DATAGO-117300): update node version to 24.11.1 #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

chore(DATAGO-117300): update node version to 24.11.1 #540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
67086dc
chore: updating node version to v24.11.1
lgh-solace Nov 12, 2025
efc74e5
chore: updating node version to v24.11.1
lgh-solace Nov 12, 2025
84a2b6c
chore: tidying
lgh-solace Nov 12, 2025
3551369
Merge branch 'main' into lgh-nodeUpdate
lgh-solace Nov 12, 2025
49e5b95
chore: updating dockerfile
lgh-solace Nov 12, 2025
2c5cc00
chore: updating lib types
lgh-solace Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
curl \
ffmpeg && \
rm -rf /var/lib/apt/lists/* && \
curl -sL https://deb.nodesource.com/setup_20.x | bash - && \
curl -sL https://deb.nodesource.com/setup_24.x | bash - && \
apt-get install -y --no-install-recommends nodejs && \
apt-get purge -y --auto-remove && \
apt-get clean && \
Expand Down Expand Up @@ -73,9 +73,9 @@
ENV SOLACE_DEV_MODE=True

# Set the following environment variables to appropriate values before deploying
ENV SESSION_SECRET_KEY="REPLACE_WITH_SESSION_SECRET_KEY"

Check warning on line 76 in Dockerfile

View workflow job for this annotation

GitHub Actions / Build linux/amd64

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "SESSION_SECRET_KEY")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

Check warning on line 76 in Dockerfile

View workflow job for this annotation

GitHub Actions / Build linux/arm64

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "SESSION_SECRET_KEY")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/
ENV LLM_SERVICE_ENDPOINT="REPLACE_WITH_LLM_SERVICE_ENDPOINT"
ENV LLM_SERVICE_API_KEY="REPLACE_WITH_LLM_SERVICE_API_KEY"

Check warning on line 78 in Dockerfile

View workflow job for this annotation

GitHub Actions / Build linux/amd64

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "LLM_SERVICE_API_KEY")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

Check warning on line 78 in Dockerfile

View workflow job for this annotation

GitHub Actions / Build linux/arm64

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "LLM_SERVICE_API_KEY")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/
ENV LLM_SERVICE_PLANNING_MODEL_NAME="REPLACE_WITH_PLANNING_MODEL_NAME"
ENV LLM_SERVICE_GENERAL_MODEL_NAME="REPLACE_WITH_GENERAL_MODEL_NAME"

Expand Down
2 changes: 1 addition & 1 deletion client/webui/frontend/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Frontend interface for Solace Agent Mesh (SAM) platform. This React application

### Prerequisites

- Node.js 18+
- Node.js version >=24.11.1 and <25.0.0
- npm, yarn, or pnpm

### Installation
Expand Down
2 changes: 1 addition & 1 deletion client/webui/frontend/cypress/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ Tests are configured for CI/CD with:

Ensure the following are installed:

- Node.js (>=20.8.10)
- Node.js version >=24.11.1 and <25.0.0
- npm or yarn
- Cypress dependencies (`npm install`)

Expand Down
Loading
Loading