Skip to content

Commit 1d774a0

Browse files
Bug Fix: Should hide the "active" but invisible clone.
1 parent e02e58e commit 1d774a0

File tree

12 files changed

+30
-29
lines changed

12 files changed

+30
-29
lines changed

dist/js/splide-renderer.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/js/splide.cjs.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*!
22
* Splide.js
3-
* Version : 3.6.0
3+
* Version : 3.6.1
44
* License : MIT
55
* Copyright: 2021 Naotoshi Fujita
66
*/
@@ -839,12 +839,12 @@ function Slide$1(Splide2, index, slideIndex, slide) {
839839
}
840840
}
841841
function updateVisibility(visible) {
842-
const ariaHidden = !visible && !isActive();
843-
setAttribute(slide, ARIA_HIDDEN, ariaHidden || null);
844-
setAttribute(slide, TAB_INDEX, !ariaHidden && options.slideFocus ? 0 : null);
842+
const hidden = !visible && (!isActive() || isClone);
843+
setAttribute(slide, ARIA_HIDDEN, hidden || null);
844+
setAttribute(slide, TAB_INDEX, !hidden && options.slideFocus ? 0 : null);
845845
if (focusableNodes) {
846846
focusableNodes.forEach((node) => {
847-
setAttribute(node, TAB_INDEX, ariaHidden ? -1 : null);
847+
setAttribute(node, TAB_INDEX, hidden ? -1 : null);
848848
});
849849
}
850850
if (visible !== hasClass(slide, CLASS_VISIBLE)) {

dist/js/splide.esm.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*!
22
* Splide.js
3-
* Version : 3.6.0
3+
* Version : 3.6.1
44
* License : MIT
55
* Copyright: 2021 Naotoshi Fujita
66
*/
@@ -835,12 +835,12 @@ function Slide$1(Splide2, index, slideIndex, slide) {
835835
}
836836
}
837837
function updateVisibility(visible) {
838-
const ariaHidden = !visible && !isActive();
839-
setAttribute(slide, ARIA_HIDDEN, ariaHidden || null);
840-
setAttribute(slide, TAB_INDEX, !ariaHidden && options.slideFocus ? 0 : null);
838+
const hidden = !visible && (!isActive() || isClone);
839+
setAttribute(slide, ARIA_HIDDEN, hidden || null);
840+
setAttribute(slide, TAB_INDEX, !hidden && options.slideFocus ? 0 : null);
841841
if (focusableNodes) {
842842
focusableNodes.forEach((node) => {
843-
setAttribute(node, TAB_INDEX, ariaHidden ? -1 : null);
843+
setAttribute(node, TAB_INDEX, hidden ? -1 : null);
844844
});
845845
}
846846
if (visible !== hasClass(slide, CLASS_VISIBLE)) {

dist/js/splide.js

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/js/splide.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/js/splide.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/js/splide.min.js.gz

5 Bytes
Binary file not shown.

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@splidejs/splide",
3-
"version": "3.6.0",
3+
"version": "3.6.1",
44
"description": "Splide is a lightweight, flexible and accessible slider/carousel. No dependencies, no Lighthouse errors.",
55
"author": "Naotoshi Fujita",
66
"license": "MIT",

src/js/components/Slides/Slide.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -190,14 +190,14 @@ export function Slide( Splide: Splide, index: number, slideIndex: number, slide:
190190
* @param visible - Set `true` if the slide is visible.
191191
*/
192192
function updateVisibility( visible: boolean ): void {
193-
const ariaHidden = ! visible && ! isActive();
193+
const hidden = ! visible && ( ! isActive() || isClone );
194194

195-
setAttribute( slide, ARIA_HIDDEN, ariaHidden || null );
196-
setAttribute( slide, TAB_INDEX, ! ariaHidden && options.slideFocus ? 0 : null );
195+
setAttribute( slide, ARIA_HIDDEN, hidden || null );
196+
setAttribute( slide, TAB_INDEX, ! hidden && options.slideFocus ? 0 : null );
197197

198198
if ( focusableNodes ) {
199199
focusableNodes.forEach( node => {
200-
setAttribute( node, TAB_INDEX, ariaHidden ? -1 : null );
200+
setAttribute( node, TAB_INDEX, hidden ? -1 : null );
201201
} );
202202
}
203203

0 commit comments

Comments
 (0)