Skip to content

Commit 5e0c2ac

Browse files
Bug Fix: Change the application order of src and srcset to suppress the NS_BINDING_ABORTED notice(#632).
1 parent 0201f9d commit 5e0c2ac

File tree

10 files changed

+18
-16
lines changed

10 files changed

+18
-16
lines changed

dist/js/splide-renderer.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/js/splide.cjs.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*!
22
* Splide.js
3-
* Version : 3.6.11
3+
* Version : 3.6.12
44
* License : MIT
55
* Copyright: 2022 Naotoshi Fujita
66
*/
@@ -2037,7 +2037,7 @@ function LazyLoad(Splide2, Components2, options) {
20372037
bind(_img, "load error", (e) => {
20382038
onLoad(data, e.type === "error");
20392039
});
2040-
["src", "srcset"].forEach((name) => {
2040+
["srcset", "src"].forEach((name) => {
20412041
if (data[name]) {
20422042
setAttribute(_img, name, data[name]);
20432043
removeAttribute(_img, name === "src" ? SRC_DATA_ATTRIBUTE : SRCSET_DATA_ATTRIBUTE);

dist/js/splide.esm.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*!
22
* Splide.js
3-
* Version : 3.6.11
3+
* Version : 3.6.12
44
* License : MIT
55
* Copyright: 2022 Naotoshi Fujita
66
*/
@@ -2033,7 +2033,7 @@ function LazyLoad(Splide2, Components2, options) {
20332033
bind(_img, "load error", (e) => {
20342034
onLoad(data, e.type === "error");
20352035
});
2036-
["src", "srcset"].forEach((name) => {
2036+
["srcset", "src"].forEach((name) => {
20372037
if (data[name]) {
20382038
setAttribute(_img, name, data[name]);
20392039
removeAttribute(_img, name === "src" ? SRC_DATA_ATTRIBUTE : SRCSET_DATA_ATTRIBUTE);

dist/js/splide.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/js/splide.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/js/splide.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/js/splide.min.js.gz

-2 Bytes
Binary file not shown.

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@splidejs/splide",
3-
"version": "3.6.11",
3+
"version": "3.6.12",
44
"description": "Splide is a lightweight, flexible and accessible slider/carousel. No dependencies, no Lighthouse errors.",
55
"author": "Naotoshi Fujita",
66
"license": "MIT",

src/js/components/LazyLoad/LazyLoad.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,15 @@ import {
55
EVENT_MOUNTED,
66
EVENT_MOVED,
77
EVENT_REFRESH,
8-
EVENT_RESIZE, EVENT_SCROLLED,
8+
EVENT_RESIZE,
9+
EVENT_SCROLLED,
910
} from '../../constants/events';
1011
import { EventInterface } from '../../constructors';
1112
import { Splide } from '../../core/Splide/Splide';
1213
import { BaseComponent, Components, Options } from '../../types';
1314
import {
14-
addClass, child,
15+
addClass,
16+
child,
1517
create,
1618
display,
1719
getAttribute,
@@ -158,7 +160,7 @@ export function LazyLoad( Splide: Splide, Components: Components, options: Optio
158160
addClass( data._Slide.slide, CLASS_LOADING );
159161
bind( _img, 'load error', e => { onLoad( data, e.type === 'error' ) } );
160162

161-
[ 'src', 'srcset' ].forEach( name => {
163+
[ 'srcset', 'src' ].forEach( name => {
162164
if ( data[ name ] ) {
163165
setAttribute( _img, name, data[ name ] );
164166
removeAttribute( _img, name === 'src' ? SRC_DATA_ATTRIBUTE : SRCSET_DATA_ATTRIBUTE );

0 commit comments

Comments
 (0)