Skip to content

Commit dab5aef

Browse files
Bug Fix: A "src" attribute was sometimes unexpectedly null.
1 parent 778235b commit dab5aef

File tree

7 files changed

+12
-12
lines changed

7 files changed

+12
-12
lines changed

dist/js/splide.esm.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*!
22
* Splide.js
3-
* Version : 2.4.7
3+
* Version : 2.4.8
44
* License : MIT
55
* Copyright: 2020 Naotoshi Fujita
66
*/
@@ -5062,8 +5062,8 @@ var SRCSET_DATA_NAME = 'data-splide-lazy-srcset';
50625062
loaded(img, spinner, Slide, true);
50635063
};
50645064

5065-
setAttribute(img, 'srcset', getAttribute(img, SRCSET_DATA_NAME));
5066-
setAttribute(img, 'src', getAttribute(img, SRC_DATA_NAME));
5065+
setAttribute(img, 'srcset', getAttribute(img, SRCSET_DATA_NAME) || '');
5066+
setAttribute(img, 'src', getAttribute(img, SRC_DATA_NAME) || '');
50675067
}
50685068
/**
50695069
* Start loading a next image in images array.

dist/js/splide.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*!
22
* Splide.js
3-
* Version : 2.4.7
3+
* Version : 2.4.8
44
* License : MIT
55
* Copyright: 2020 Naotoshi Fujita
66
*/
@@ -5052,8 +5052,8 @@ var SRCSET_DATA_NAME = 'data-splide-lazy-srcset';
50525052
loaded(img, spinner, Slide, true);
50535053
};
50545054

5055-
setAttribute(img, 'srcset', getAttribute(img, SRCSET_DATA_NAME));
5056-
setAttribute(img, 'src', getAttribute(img, SRC_DATA_NAME));
5055+
setAttribute(img, 'srcset', getAttribute(img, SRCSET_DATA_NAME) || '');
5056+
setAttribute(img, 'src', getAttribute(img, SRC_DATA_NAME) || '');
50575057
}
50585058
/**
50595059
* Start loading a next image in images array.

dist/js/splide.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/js/splide.min.js.gz

3 Bytes
Binary file not shown.

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@splidejs/splide",
3-
"version": "2.4.7",
3+
"version": "2.4.8",
44
"description": "Splide is a lightweight and powerful slider without any dependencies.",
55
"author": "Naotoshi Fujita",
66
"license": "MIT",

src/js/components/lazyload/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,8 +163,8 @@ export default ( Splide, Components, name ) => {
163163
img.onload = () => { loaded( img, spinner, Slide, false ) };
164164
img.onerror = () => { loaded( img, spinner, Slide, true ) };
165165

166-
setAttribute( img, 'srcset', getAttribute( img, SRCSET_DATA_NAME ) );
167-
setAttribute( img, 'src', getAttribute( img, SRC_DATA_NAME ) );
166+
setAttribute( img, 'srcset', getAttribute( img, SRCSET_DATA_NAME ) || '' );
167+
setAttribute( img, 'src', getAttribute( img, SRC_DATA_NAME ) || '' );
168168
}
169169

170170
/**

0 commit comments

Comments
 (0)