Skip to content

Commit b96eed3

Browse files
akhil-sumologicakhil-sumologic
committed
Addressed Review comments
1 parent 571ab1c commit b96eed3

File tree

25 files changed

+71
-71
lines changed

25 files changed

+71
-71
lines changed

‎aws/cloudtrail/examples/default/locals.tf‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ locals {
1010

1111
# AWS resource tags
1212
aws_resource_tags = {
13-
Creator = "SumoLogic"
14-
Environment = "Test"
13+
creator = "sumoLogic"
14+
environment = "test"
1515
}
1616
}

‎aws/cloudwatchlogsforwarder/examples/default/locals.tf‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ locals {
88

99
# AWS resource tags
1010
aws_resource_tags = {
11-
Creator = "SumoLogic"
12-
Environment = "Test"
11+
creator = "sumoLogic"
12+
environment = "test"
1313
}
1414
}

‎aws/cloudwatchlogsforwarder/examples/default/main.auto.tfvars‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
####### BELOW ARE REQUIRED PARAMETERS FOR TERRAFORM SCRIPT #######
2-
sumologic_environment = "<YOUR SUMO DEPLOYMENT>" # Please replace <YOUR SUMO DEPLOYMENT> (including brackets) with au, ca, de, eu, fed, jp, kr, us1 or us2.
3-
sumologic_organization_id = "<YOUR SUMO ORG ID>" # Please replace <YOUR SUMO ORG ID> (including brackets) with your Sumo Logic Organization ID.
4-
sumologic_access_id = "<YOUR SUMO ACCESS ID>" # Please replace <YOUR SUMO ACCESS ID> (including brackets) with your Sumo Logic Access ID.
5-
sumologic_access_key = "<YOUR SUMO ACCESS KEY>" # Please replace <YOUR SUMO ACCESS KEY> (including brackets) with your Sumo Logic Access KEY.
2+
sumologic_environment = "<YOUR SUMO DEPLOYMENT>" # Please replace <YOUR SUMO DEPLOYMENT> (including brackets) with au, ca, de, eu, fed, jp, kr, us1 or us2.
3+
sumologic_organization_id = "<YOUR SUMO ORG ID>" # Please replace <YOUR SUMO ORG ID> (including brackets) with your Sumo Logic Organization ID.
4+
sumologic_access_id = "<YOUR SUMO ACCESS ID>" # Please replace <YOUR SUMO ACCESS ID> (including brackets) with your Sumo Logic Access ID.
5+
sumologic_access_key = "<YOUR SUMO ACCESS KEY>" # Please replace <YOUR SUMO ACCESS KEY> (including brackets) with your Sumo Logic Access KEY.

‎aws/cloudwatchlogsforwarder/variables.tf‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ variable "auto_enable_logs_subscription_options" {
113113
EOT
114114

115115
default = {
116-
filter = "lambda"
116+
filter = "apigateway|lambda|rds"
117117
tags_filter = ""
118118
}
119119
}

‎aws/cloudwatchmetrics/examples/default/locals.tf‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ locals {
22

33
# AWS resource tags
44
aws_resource_tags = {
5-
Creator = "SumoLogic"
6-
Environment = "Test"
5+
creator = "sumoLogic"
6+
environment = "test"
77
}
88
}

‎aws/cloudwatchmetrics/examples/default/main.auto.tfvars‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
####### BELOW ARE REQUIRED PARAMETERS FOR TERRAFORM SCRIPT #######
2-
sumologic_environment = "<YOUR SUMO DEPLOYMENT>" # Please replace <YOUR SUMO DEPLOYMENT> (including brackets) with au, ca, de, eu, fed, jp, kr, us1 or us2.
3-
sumologic_organization_id = "<YOUR SUMO ORG ID>" # Please replace <YOUR SUMO ORG ID> (including brackets) with your Sumo Logic Organization ID.
4-
sumologic_access_id = "<YOUR SUMO ACCESS ID>" # Please replace <YOUR SUMO ACCESS ID> (including brackets) with your Sumo Logic Access ID.
5-
sumologic_access_key = "<YOUR SUMO ACCESS KEY>" # Please replace <YOUR SUMO ACCESS KEY> (including brackets) with your Sumo Logic Access KEY.
2+
sumologic_environment = "<YOUR SUMO DEPLOYMENT>" # Please replace <YOUR SUMO DEPLOYMENT> (including brackets) with au, ca, de, eu, fed, jp, kr, us1 or us2.
3+
sumologic_organization_id = "<YOUR SUMO ORG ID>" # Please replace <YOUR SUMO ORG ID> (including brackets) with your Sumo Logic Organization ID.
4+
sumologic_access_id = "<YOUR SUMO ACCESS ID>" # Please replace <YOUR SUMO ACCESS ID> (including brackets) with your Sumo Logic Access ID.
5+
sumologic_access_key = "<YOUR SUMO ACCESS KEY>" # Please replace <YOUR SUMO ACCESS KEY> (including brackets) with your Sumo Logic Access KEY.

‎aws/elasticloadbalancing/elb.tf‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ resource "aws_s3_bucket" "s3_bucket" {
1717

1818
bucket = local.bucket_name
1919
force_destroy = var.source_details.bucket_details.force_destroy_bucket
20-
tags = var.aws_resource_tags
20+
tags = var.aws_resource_tags
2121
}
2222

2323
resource "aws_s3_bucket_policy" "dump_access_logs_to_s3" {
@@ -78,7 +78,7 @@ resource "aws_iam_policy" "iam_policy" {
7878
}
7979

8080
resource "aws_iam_role_policy_attachment" "source-role-policy-attach" {
81-
for_each = toset(var.source_details.iam_details.create_iam_role ? ["source_iam_role"] : [])
81+
for_each = toset(var.source_details.iam_details.create_iam_role ? ["source_iam_role"] : [])
8282
role = aws_iam_role.source_iam_role["source_iam_role"].name
8383
policy_arn = aws_iam_policy.iam_policy["iam_policy"].arn
8484
}
@@ -164,7 +164,7 @@ resource "aws_serverlessapplicationrepository_cloudformation_stack" "auto_enable
164164
}
165165
lifecycle {
166166
ignore_changes = [
167-
parameters,tags
167+
parameters, tags
168168
]
169169
}
170170
tags = var.aws_resource_tags

‎aws/elasticloadbalancing/examples/default/locals.tf‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
locals {
22
# AWS account details
33
aws_account_id = data.aws_caller_identity.current.account_id
4-
aws_region = data.aws_region.current.name
4+
aws_region = data.aws_region.current.name
55

66
# S3 bucket inputs
7-
bucket_name = "aws-observability-random-${random_string.aws_random.id}"
8-
path_expression = "AWSLogs/${local.aws_account_id}/clb/${local.aws_region}/*"
7+
bucket_name = "aws-observability-random-${random_string.aws_random.id}"
8+
path_expression = "AWSLogs/${local.aws_account_id}/clb/${local.aws_region}/*"
99

1010
# AWS resource tags
1111
aws_resource_tags = {
12-
Creator = "SumoLogic"
13-
Environment = "Test"
12+
creator = "sumoLogic"
13+
environment = "test"
1414
}
1515
}

‎aws/elasticloadbalancing/examples/default/main.auto.tfvars‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
####### BELOW ARE REQUIRED PARAMETERS FOR TERRAFORM SCRIPT #######
22
# Visit - https://help.sumologic.com/Solutions/AWS_Observability_Solution/03_Set_Up_the_AWS_Observability_Solution#sumo-logic-access-configuration-required
3-
sumologic_environment = "<YOUR SUMO DEPLOYMENT>" # Please replace <YOUR SUMO DEPLOYMENT> (including brackets) with au, ca, de, eu, fed, jp, kr, us1 or us2.
4-
sumologic_access_id = "<YOUR SUMO ACCESS ID>" # Please replace <YOUR SUMO ACCESS ID> (including brackets) with your Sumo Logic Access ID.
5-
sumologic_access_key = "<YOUR SUMO ACCESS KEY>" # Please replace <YOUR SUMO ACCESS KEY> (including brackets) with your Sumo Logic Access KEY.
6-
sumologic_organization_id = "<YOUR SUMO ORG ID>" # Please replace <YOUR SUMO ORG ID> (including brackets) with your Sumo Logic Organization ID.
3+
sumologic_environment = "<YOUR SUMO DEPLOYMENT>" # Please replace <YOUR SUMO DEPLOYMENT> (including brackets) with au, ca, de, eu, fed, jp, kr, us1 or us2.
4+
sumologic_access_id = "<YOUR SUMO ACCESS ID>" # Please replace <YOUR SUMO ACCESS ID> (including brackets) with your Sumo Logic Access ID.
5+
sumologic_access_key = "<YOUR SUMO ACCESS KEY>" # Please replace <YOUR SUMO ACCESS KEY> (including brackets) with your Sumo Logic Access KEY.
6+
sumologic_organization_id = "<YOUR SUMO ORG ID>" # Please replace <YOUR SUMO ORG ID> (including brackets) with your Sumo Logic Organization ID.

‎aws/elasticloadbalancing/examples/default/main.tf‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ module "lb_module" {
1010
create_collector = true
1111
sumologic_organization_id = var.sumologic_organization_id
1212
wait_for_seconds = 20
13-
aws_resource_tags = local.aws_resource_tags
13+
aws_resource_tags = local.aws_resource_tags
1414

1515
source_details = {
1616
source_name = "Classic Load Balancer Logs (Region)"
@@ -38,7 +38,7 @@ module "lb_module" {
3838
}
3939
}
4040
auto_enable_access_logs = "Both"
41-
app_semantic_version = "1.0.17"
41+
app_semantic_version = "1.0.17"
4242
auto_enable_access_logs_options = {
4343
bucket_prefix = "classicloadbalancing"
4444
auto_enable_logging = "ELB"

0 commit comments

Comments
 (0)